Revision b16671e8f493e3df40b1fb0dff4078f391c5099a authored by Coly Li on 04 January 2021, 07:41:21 UTC, committed by Jens Axboe on 09 January 2021, 16:21:03 UTC
When large bucket feature was added, BCH_FEATURE_INCOMPAT_LARGE_BUCKET was introduced into the incompat feature set. It used bucket_size_hi (which was added at the tail of struct cache_sb_disk) to extend current 16bit bucket size to 32bit with existing bucket_size in struct cache_sb_disk. This is not a good idea, there are two obvious problems, - Bucket size is always value power of 2, if store log2(bucket size) in existing bucket_size of struct cache_sb_disk, it is unnecessary to add bucket_size_hi. - Macro csum_set() assumes d[SB_JOURNAL_BUCKETS] is the last member in struct cache_sb_disk, bucket_size_hi was added after d[] which makes csum_set calculate an unexpected super block checksum. To fix the above problems, this patch introduces a new incompat feature bit BCH_FEATURE_INCOMPAT_LOG_LARGE_BUCKET_SIZE, when this bit is set, it means bucket_size in struct cache_sb_disk stores the order of power-of-2 bucket size value. When user specifies a bucket size larger than 32768 sectors, BCH_FEATURE_INCOMPAT_LOG_LARGE_BUCKET_SIZE will be set to incompat feature set, and bucket_size stores log2(bucket size) more than store the real bucket size value. The obsoleted BCH_FEATURE_INCOMPAT_LARGE_BUCKET won't be used anymore, it is renamed to BCH_FEATURE_INCOMPAT_OBSO_LARGE_BUCKET and still only recognized by kernel driver for legacy compatible purpose. The previous bucket_size_hi is renmaed to obso_bucket_size_hi in struct cache_sb_disk and not used in bcache-tools anymore. For cache device created with BCH_FEATURE_INCOMPAT_LARGE_BUCKET feature, bcache-tools and kernel driver still recognize the feature string and display it as "obso_large_bucket". With this change, the unnecessary extra space extend of bcache on-disk super block can be avoided, and csum_set() may generate expected check sum as well. Fixes: ffa470327572 ("bcache: add bucket_size_hi into struct cache_sb_disk for large bucket") Signed-off-by: Coly Li <colyli@suse.de> Cc: stable@vger.kernel.org # 5.9+ Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 1dfc068
File | Mode | Size |
---|---|---|
9p | ||
adfs | ||
affs | ||
afs | ||
autofs | ||
befs | ||
bfs | ||
btrfs | ||
cachefiles | ||
ceph | ||
cifs | ||
coda | ||
configfs | ||
cramfs | ||
crypto | ||
debugfs | ||
devpts | ||
dlm | ||
ecryptfs | ||
efivarfs | ||
efs | ||
erofs | ||
exfat | ||
exportfs | ||
ext2 | ||
ext4 | ||
f2fs | ||
fat | ||
freevxfs | ||
fscache | ||
fuse | ||
gfs2 | ||
hfs | ||
hfsplus | ||
hostfs | ||
hpfs | ||
hugetlbfs | ||
iomap | ||
isofs | ||
jbd2 | ||
jffs2 | ||
jfs | ||
kernfs | ||
lockd | ||
minix | ||
nfs | ||
nfs_common | ||
nfsd | ||
nilfs2 | ||
nls | ||
notify | ||
ntfs | ||
ocfs2 | ||
omfs | ||
openpromfs | ||
orangefs | ||
overlayfs | ||
proc | ||
pstore | ||
qnx4 | ||
qnx6 | ||
quota | ||
ramfs | ||
reiserfs | ||
romfs | ||
squashfs | ||
sysfs | ||
sysv | ||
tracefs | ||
ubifs | ||
udf | ||
ufs | ||
unicode | ||
vboxsf | ||
verity | ||
xfs | ||
zonefs | ||
Kconfig | -rw-r--r-- | 8.5 KB |
Kconfig.binfmt | -rw-r--r-- | 7.6 KB |
Makefile | -rw-r--r-- | 4.5 KB |
aio.c | -rw-r--r-- | 56.4 KB |
anon_inodes.c | -rw-r--r-- | 4.6 KB |
attr.c | -rw-r--r-- | 9.7 KB |
bad_inode.c | -rw-r--r-- | 5.3 KB |
binfmt_aout.c | -rw-r--r-- | 8.3 KB |
binfmt_elf.c | -rw-r--r-- | 60.5 KB |
binfmt_elf_fdpic.c | -rw-r--r-- | 44.1 KB |
binfmt_em86.c | -rw-r--r-- | 2.7 KB |
binfmt_flat.c | -rw-r--r-- | 28.3 KB |
binfmt_misc.c | -rw-r--r-- | 17.3 KB |
binfmt_script.c | -rw-r--r-- | 4.2 KB |
block_dev.c | -rw-r--r-- | 47.9 KB |
buffer.c | -rw-r--r-- | 89.1 KB |
char_dev.c | -rw-r--r-- | 16.5 KB |
compat_binfmt_elf.c | -rw-r--r-- | 3.8 KB |
coredump.c | -rw-r--r-- | 27.7 KB |
d_path.c | -rw-r--r-- | 11.4 KB |
dax.c | -rw-r--r-- | 46.4 KB |
dcache.c | -rw-r--r-- | 84.7 KB |
dcookies.c | -rw-r--r-- | 7.1 KB |
direct-io.c | -rw-r--r-- | 39.5 KB |
drop_caches.c | -rw-r--r-- | 1.8 KB |
eventfd.c | -rw-r--r-- | 12.1 KB |
eventpoll.c | -rw-r--r-- | 63.8 KB |
exec.c | -rw-r--r-- | 49.3 KB |
fcntl.c | -rw-r--r-- | 23.4 KB |
fhandle.c | -rw-r--r-- | 6.8 KB |
file.c | -rw-r--r-- | 28.7 KB |
file_table.c | -rw-r--r-- | 10.2 KB |
filesystems.c | -rw-r--r-- | 6.4 KB |
fs-writeback.c | -rw-r--r-- | 74.6 KB |
fs_context.c | -rw-r--r-- | 17.2 KB |
fs_parser.c | -rw-r--r-- | 10.1 KB |
fs_pin.c | -rw-r--r-- | 1.9 KB |
fs_struct.c | -rw-r--r-- | 3.4 KB |
fs_types.c | -rw-r--r-- | 2.5 KB |
fsopen.c | -rw-r--r-- | 11.0 KB |
init.c | -rw-r--r-- | 5.9 KB |
inode.c | -rw-r--r-- | 63.1 KB |
internal.h | -rw-r--r-- | 5.1 KB |
io-wq.c | -rw-r--r-- | 29.6 KB |
io-wq.h | -rw-r--r-- | 3.6 KB |
io_uring.c | -rw-r--r-- | 240.7 KB |
ioctl.c | -rw-r--r-- | 20.9 KB |
kernel_read_file.c | -rw-r--r-- | 4.4 KB |
libfs.c | -rw-r--r-- | 39.6 KB |
locks.c | -rw-r--r-- | 80.0 KB |
mbcache.c | -rw-r--r-- | 12.0 KB |
mount.h | -rw-r--r-- | 4.2 KB |
mpage.c | -rw-r--r-- | 20.5 KB |
namei.c | -rw-r--r-- | 120.0 KB |
namespace.c | -rw-r--r-- | 98.4 KB |
no-block.c | -rw-r--r-- | 478 bytes |
nsfs.c | -rw-r--r-- | 6.6 KB |
open.c | -rw-r--r-- | 33.3 KB |
pipe.c | -rw-r--r-- | 33.7 KB |
pnode.c | -rw-r--r-- | 15.1 KB |
pnode.h | -rw-r--r-- | 1.9 KB |
posix_acl.c | -rw-r--r-- | 21.5 KB |
proc_namespace.c | -rw-r--r-- | 8.1 KB |
read_write.c | -rw-r--r-- | 39.2 KB |
readdir.c | -rw-r--r-- | 13.7 KB |
remap_range.c | -rw-r--r-- | 13.9 KB |
select.c | -rw-r--r-- | 34.5 KB |
seq_file.c | -rw-r--r-- | 24.7 KB |
signalfd.c | -rw-r--r-- | 9.0 KB |
splice.c | -rw-r--r-- | 38.7 KB |
stack.c | -rw-r--r-- | 2.5 KB |
stat.c | -rw-r--r-- | 19.8 KB |
statfs.c | -rw-r--r-- | 9.6 KB |
super.c | -rw-r--r-- | 45.2 KB |
sync.c | -rw-r--r-- | 10.5 KB |
timerfd.c | -rw-r--r-- | 13.6 KB |
userfaultfd.c | -rw-r--r-- | 52.0 KB |
utimes.c | -rw-r--r-- | 7.6 KB |
xattr.c | -rw-r--r-- | 26.2 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...