Revision b1ffb4c851f185e9051ba837c16d9b84ef688d26 authored by Andrew Worsley on 18 November 2011, 12:13:33 UTC, committed by Greg Kroah-Hartman on 18 November 2011, 19:27:16 UTC
Fix for ftdi_set_termios() glitching output

ftdi_set_termios() is constantly setting the baud rate, data bits and parity
unnecessarily on every call, . When called while characters are being
transmitted can cause the FTDI chip to corrupt the serial port bit stream
output by stalling the output half a bit during the output of a character.
Simple fix by skipping this setting if the baud rate/data bits/parity are
unchanged.

Signed-off-by: Andrew Worsley <amworsley@gmail.com>
Cc: stable <stable@vger.kernel.org>
----

  I had a brief run with strace on the getty and it was doing ioctl()s on
  each call but it didn't look relavant to the problem. I think the issue is
  that XON/XOFF flow control was being implmented via hardware - for the ixoff
  to allow the user to use XON/XOFF to control output. Unfortunately it would
  send 3 Control URBs updating all of the settings after each piece of input

  I am trying to work around the issue of gmail messing with the tab/spacing
  by submitting via SMTP via gmail which I believe should fix the issue.

  The patch is against v3.2-rc2 and compiles - but no additional testing in
  this kernel has been done.

  Thanks

   Andrew
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
1 parent 4aa3648
History
File Mode Size
Kconfig -rw-r--r-- 3.2 KB
Kconfig.iosched -rw-r--r-- 1.8 KB
Makefile -rw-r--r-- 683 bytes
blk-cgroup.c -rw-r--r-- 42.9 KB
blk-cgroup.h -rw-r--r-- 11.3 KB
blk-core.c -rw-r--r-- 76.0 KB
blk-exec.c -rw-r--r-- 3.0 KB
blk-flush.c -rw-r--r-- 13.1 KB
blk-integrity.c -rw-r--r-- 11.5 KB
blk-ioc.c -rw-r--r-- 3.7 KB
blk-iopoll.c -rw-r--r-- 5.9 KB
blk-lib.c -rw-r--r-- 3.9 KB
blk-map.c -rw-r--r-- 8.2 KB
blk-merge.c -rw-r--r-- 11.1 KB
blk-settings.c -rw-r--r-- 25.3 KB
blk-softirq.c -rw-r--r-- 4.6 KB
blk-sysfs.c -rw-r--r-- 14.7 KB
blk-tag.c -rw-r--r-- 9.9 KB
blk-throttle.c -rw-r--r-- 32.5 KB
blk-timeout.c -rw-r--r-- 5.6 KB
blk.h -rw-r--r-- 6.3 KB
bsg-lib.c -rw-r--r-- 7.6 KB
bsg.c -rw-r--r-- 23.7 KB
cfq-iosched.c -rw-r--r-- 107.9 KB
cfq.h -rw-r--r-- 3.7 KB
compat_ioctl.c -rw-r--r-- 20.7 KB
deadline-iosched.c -rw-r--r-- 11.1 KB
elevator.c -rw-r--r-- 24.1 KB
genhd.c -rw-r--r-- 44.3 KB
ioctl.c -rw-r--r-- 8.1 KB
noop-iosched.c -rw-r--r-- 2.4 KB
scsi_ioctl.c -rw-r--r-- 18.3 KB

back to top