Skip to main content

Browse the archive

swh:1:snp:eb70f1f85391e4b077c211bec36af0061c4bf937
Revision b6202a0cf154a0e0e7cbacf165a995cc37e5cd3e authored by Valentin Lorentz on 29 July 2020, 08:26:32 UTC, committed by Valentin Lorentz on 29 July 2020, 14:24:11 UTC 
Make API endpoints take Lists instead of Iterables as arguments
 
1. clients crash when they call the API with an iterator
2. some backend implementations violate the contract by assuming
   the argument is a sequence (eg. by iterating twice on it, and
   assuming the elements are the same)
3. no matter what we do, the endpoints will always get a list
   as argument in practice, because they go through the RPC framework
4. there is no concrete (ha!) advantage in taking an Iterable rather
   than a List.
1 parent 21b7730
History
Tip revision: 728c3eeaae84a7e249a712a5545cc9ba682403c3 authored by David Douard on 08 January 2021, 09:39:42 UTC
Allow to use the JAVA_HOME environment for cassandra tests
Tip revision: 728c3ee
File Mode Size
bin
docs
sql
swh
.gitignore -rw-r--r-- 136 bytes
.pre-commit-config.yaml -rw-r--r-- 1.1 KB
AUTHORS -rw-r--r-- 112 bytes
CODE_OF_CONDUCT.md -rw-r--r-- 3.3 KB
CONTRIBUTORS -rw-r--r-- 46 bytes
LICENSE -rw-r--r-- 34.3 KB
MANIFEST.in -rw-r--r-- 242 bytes
Makefile -rw-r--r-- 163 bytes
Makefile.local -rw-r--r-- 69 bytes
README.md -rw-r--r-- 4.6 KB
conftest.py -rw-r--r-- 294 bytes
mypy.ini -rw-r--r-- 1.2 KB
pyproject.toml -rw-r--r-- 39 bytes
pytest.ini -rw-r--r-- 392 bytes
requirements-swh-journal.txt -rw-r--r-- 19 bytes
requirements-swh.txt -rw-r--r-- 71 bytes
requirements-test.txt -rw-r--r-- 318 bytes
requirements.txt -rw-r--r-- 99 bytes
setup.cfg -rw-r--r-- 247 bytes
setup.py -rwxr-xr-x 2.5 KB
tox.ini -rw-r--r-- 661 bytes

README.md

back to top