Revision b7052cd7bcf3c1478796e93e3dff2b44c9e82943 authored by Stefan Hajnoczi on 18 February 2016, 18:55:54 UTC, committed by J. Bruce Fields on 23 February 2016, 18:20:16 UTC
The qword_get() function NUL-terminates its output buffer.  If the input
string is in hex format \xXXXX... and the same length as the output
buffer, there is an off-by-one:

  int qword_get(char **bpp, char *dest, int bufsize)
  {
      ...
      while (len < bufsize) {
          ...
          *dest++ = (h << 4) | l;
          len++;
      }
      ...
      *dest = '\0';
      return len;
  }

This patch ensures the NUL terminator doesn't fall outside the output
buffer.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
1 parent 18558ca
History
File Mode Size
kvm
lib
Makefile -rw-r--r-- 14 bytes

back to top