Revision b732961fc3c6eec3cf5508330cc09d6a0a2d8f9a authored by Andrew Scott on 26 September 2023, 17:31:27 UTC, committed by Alex Rickabaugh on 04 October 2023, 18:27:46 UTC
When the `ts.Project` creates the language service plugin (in this case, the Angular Language Service), it sets the project's language service to the new language service returned by the plugin create: https://sourcegraph.com/github.com/microsoft/TypeScript@b12af0fa2bbd4b015e59adcfb49988cea7f919a1/-/blob/src/server/project.ts?L2035-2044 The project may be reloaded in response to various events, such as a change to the tsconfig file, which then recreates the plugin. When this happens, the language service that gets passed to the plugin `create` function will not be the typescript language service, but rather the previous instance of the new language service returned by the last call to `create`. This commit ensures that subsequent calls to `create` for the `NgLanguageService` plugin for a project after the first call are able to retrieve and hold on to the _TypeScript_ language service. fixes https://github.com/angular/vscode-ng-language-service/issues/1923 PR Close #51912
1 parent 966ce97
| File | Mode | Size |
|---|---|---|
| .circleci | ||
| .devcontainer | ||
| .github | ||
| .husky | ||
| .ng-dev | ||
| .vscode | ||
| .yarn | ||
| aio | ||
| devtools | ||
| docs | ||
| goldens | ||
| integration | ||
| modules | ||
| packages | ||
| scripts | ||
| third_party | ||
| tools | ||
| .bazelignore | -rw-r--r-- | 1.5 KB |
| .bazelrc | -rw-r--r-- | 7.7 KB |
| .bazelversion | -rw-r--r-- | 6 bytes |
| .clang-format | -rw-r--r-- | 73 bytes |
| .editorconfig | -rw-r--r-- | 245 bytes |
| .gitattributes | -rw-r--r-- | 146 bytes |
| .gitignore | -rw-r--r-- | 948 bytes |
| .gitmessage | -rw-r--r-- | 7.2 KB |
| .mailmap | -rw-r--r-- | 51 bytes |
| .npmrc | -rw-r--r-- | 21 bytes |
| .nvmrc | -rw-r--r-- | 8 bytes |
| .prettierrc | -rw-r--r-- | 157 bytes |
| .pullapprove.yml | -rw-r--r-- | 51.3 KB |
| .yarnrc | -rw-r--r-- | 130 bytes |
| BUILD.bazel | -rw-r--r-- | 2.5 KB |
| CHANGELOG.md | -rw-r--r-- | 185.6 KB |
| CHANGELOG_ARCHIVE.md | -rw-r--r-- | 997.0 KB |
| CODE_OF_CONDUCT.md | -rw-r--r-- | 3.6 KB |
| CONTRIBUTING.md | -rw-r--r-- | 15.7 KB |
| LICENSE | -rw-r--r-- | 1.1 KB |
| README.md | -rw-r--r-- | 5.0 KB |
| SECURITY.md | -rw-r--r-- | 403 bytes |
| WORKSPACE | -rw-r--r-- | 8.8 KB |
| browser-providers.conf.d.ts | -rw-r--r-- | 387 bytes |
| browser-providers.conf.js | -rw-r--r-- | 1.9 KB |
| gulpfile.js | -rw-r--r-- | 572 bytes |
| karma-js.conf.js | -rw-r--r-- | 6.0 KB |
| package.json | -rw-r--r-- | 9.1 KB |
| packages.bzl | -rw-r--r-- | 3.1 KB |
| renovate.json | -rw-r--r-- | 3.0 KB |
| tsconfig-tslint.json | -rw-r--r-- | 171 bytes |
| tslint.json | -rw-r--r-- | 5.1 KB |
| yarn.bzl | -rw-r--r-- | 77 bytes |
| yarn.lock | -rw-r--r-- | 791.1 KB |
| yarn.lock.readme.md | -rw-r--r-- | 1.3 KB |
Computing file changes ...
