Revision b732961fc3c6eec3cf5508330cc09d6a0a2d8f9a authored by Andrew Scott on 26 September 2023, 17:31:27 UTC, committed by Alex Rickabaugh on 04 October 2023, 18:27:46 UTC
When the `ts.Project` creates the language service plugin (in this case, the Angular Language Service), it sets the project's language service to the new language service returned by the plugin create: https://sourcegraph.com/github.com/microsoft/TypeScript@b12af0fa2bbd4b015e59adcfb49988cea7f919a1/-/blob/src/server/project.ts?L2035-2044 The project may be reloaded in response to various events, such as a change to the tsconfig file, which then recreates the plugin. When this happens, the language service that gets passed to the plugin `create` function will not be the typescript language service, but rather the previous instance of the new language service returned by the last call to `create`. This commit ensures that subsequent calls to `create` for the `NgLanguageService` plugin for a project after the first call are able to retrieve and hold on to the _TypeScript_ language service. fixes https://github.com/angular/vscode-ng-language-service/issues/1923 PR Close #51912
1 parent 966ce97
| File | Mode | Size |
|---|---|---|
| content | ||
| scripts | ||
| src | ||
| tests | ||
| tools | ||
| .eslintrc.json | -rw-r--r-- | 7.5 KB |
| .gitignore | -rw-r--r-- | 696 bytes |
| .npmrc | -rw-r--r-- | 21 bytes |
| BUILD.bazel | -rw-r--r-- | 10.8 KB |
| README.md | -rw-r--r-- | 7.1 KB |
| UPDATING.md | -rw-r--r-- | 2.5 KB |
| aio_targets.bzl | -rw-r--r-- | 457 bytes |
| angular.json | -rw-r--r-- | 8.2 KB |
| database.rules.json | -rw-r--r-- | 128 bytes |
| firebase.json | -rw-r--r-- | 18.6 KB |
| karma.conf.js | -rw-r--r-- | 2.4 KB |
| local_packages_util.bzl | -rw-r--r-- | 4.9 KB |
| ngsw-config.json | -rw-r--r-- | 4.1 KB |
| ngsw-config.template.json | -rw-r--r-- | 1.8 KB |
| package.json | -rw-r--r-- | 7.1 KB |
| security-exemptions.json | -rw-r--r-- | 302 bytes |
| tsconfig.app.json | -rw-r--r-- | 334 bytes |
| tsconfig.json | -rw-r--r-- | 1.2 KB |
| tsconfig.spec.json | -rw-r--r-- | 274 bytes |
| tsconfig.worker.json | -rw-r--r-- | 230 bytes |
| yarn.lock | -rw-r--r-- | 686.5 KB |
Computing file changes ...
