Revision bb69b4ce7f93c9c94ad7719b96299790535e2d78 authored by Levi Tamasi on 13 November 2020, 01:31:28 UTC, committed by Facebook GitHub Bot on 13 November 2020, 01:33:04 UTC
Summary: https://github.com/facebook/rocksdb/pull/7461 accidentally broke `InternalStats::DumpCFStats` by making `DumpCFFileHistogram` overwrite the output of `DumpCFStatsNoFileHistogram` instead of appending to it, resulting in only the file histogram related information getting logged. The patch fixes this by reverting to appending in `DumpCFFileHistogram`. Fixes https://github.com/facebook/rocksdb/issues/7664 . Pull Request resolved: https://github.com/facebook/rocksdb/pull/7666 Test Plan: Ran `make check` and checked the info log of `db_bench`. Reviewed By: riversand963 Differential Revision: D24929051 Pulled By: ltamasi fbshipit-source-id: 636a3d5ebb5ce23de4f3fe4f03ad3f16cb2858f8
1 parent cf9d8e4
| File | Mode | Size |
|---|---|---|
| cf_options.cc | -rw-r--r-- | 46.3 KB |
| cf_options.h | -rw-r--r-- | 10.2 KB |
| configurable.cc | -rw-r--r-- | 23.8 KB |
| configurable_helper.h | -rw-r--r-- | 13.1 KB |
| configurable_test.cc | -rw-r--r-- | 29.8 KB |
| configurable_test.h | -rw-r--r-- | 4.1 KB |
| customizable.cc | -rw-r--r-- | 2.5 KB |
| customizable_helper.h | -rw-r--r-- | 8.5 KB |
| customizable_test.cc | -rw-r--r-- | 23.6 KB |
| db_options.cc | -rw-r--r-- | 39.9 KB |
| db_options.h | -rw-r--r-- | 3.9 KB |
| options.cc | -rw-r--r-- | 27.4 KB |
| options_helper.cc | -rw-r--r-- | 55.0 KB |
| options_helper.h | -rw-r--r-- | 4.5 KB |
| options_parser.cc | -rw-r--r-- | 25.4 KB |
| options_parser.h | -rw-r--r-- | 5.4 KB |
| options_settable_test.cc | -rw-r--r-- | 25.5 KB |
| options_test.cc | -rw-r--r-- | 155.4 KB |
Computing file changes ...
