Revision bb84735c80dbae6408b79b56f574ae672d2232d4 authored by René Scharfe on 23 October 2016, 17:57:30 UTC, committed by Junio C Hamano on 26 October 2016, 17:54:11 UTC
Overflow is defined for unsigned integers, but not for signed ones.

We could make the ring-buffer index in sha1_to_hex() and
get_pathname() unsigned to be on the safe side to resolve this, but
let's make it explicit that we are wrapping around at whatever the
number of elements the ring-buffer has.  The compiler is smart enough
to turn modulus into bitmask for these codepaths that use
ring-buffers of a size that is a power of 2.

Signed-off-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 23415c2
History
File Mode Size
xdiff.h -rw-r--r-- 3.6 KB
xdiffi.c -rw-r--r-- 16.5 KB
xdiffi.h -rw-r--r-- 2.0 KB
xemit.c -rw-r--r-- 7.5 KB
xemit.h -rw-r--r-- 1.2 KB
xhistogram.c -rw-r--r-- 9.0 KB
xinclude.h -rw-r--r-- 1.2 KB
xmacros.h -rw-r--r-- 1.9 KB
xmerge.c -rw-r--r-- 17.0 KB
xpatience.c -rw-r--r-- 9.9 KB
xprepare.c -rw-r--r-- 12.0 KB
xprepare.h -rw-r--r-- 1.1 KB
xtypes.h -rw-r--r-- 1.6 KB
xutils.c -rw-r--r-- 11.0 KB
xutils.h -rw-r--r-- 1.8 KB

back to top