Revision bba719b5004234e55737e7074b81b337210c511d authored by Jie Liu on 01 January 2014, 11:28:03 UTC, committed by Ben Myers on 10 January 2014, 18:38:41 UTC
With CRC check is enabled, if trying to set an attributes value just
equal to the maximum size of XATTR_SIZE_MAX would cause the v3 remote
attr write verification procedure failure, which would yield the back
trace like below:
<snip>
XFS (sda7): Internal error xfs_attr3_rmt_write_verify at line 191 of file fs/xfs/xfs_attr_remote.c
<snip>
Call Trace:
[<ffffffff816f0042>] dump_stack+0x45/0x56
[<ffffffffa0d99c8b>] xfs_error_report+0x3b/0x40 [xfs]
[<ffffffffa0d96edd>] ? _xfs_buf_ioapply+0x6d/0x390 [xfs]
[<ffffffffa0d99ce5>] xfs_corruption_error+0x55/0x80 [xfs]
[<ffffffffa0dbef6b>] xfs_attr3_rmt_write_verify+0x14b/0x1a0 [xfs]
[<ffffffffa0d96edd>] ? _xfs_buf_ioapply+0x6d/0x390 [xfs]
[<ffffffffa0d97315>] ? xfs_bdstrat_cb+0x55/0xb0 [xfs]
[<ffffffffa0d96edd>] _xfs_buf_ioapply+0x6d/0x390 [xfs]
[<ffffffff81184cda>] ? vm_map_ram+0x31a/0x460
[<ffffffff81097230>] ? wake_up_state+0x20/0x20
[<ffffffffa0d97315>] ? xfs_bdstrat_cb+0x55/0xb0 [xfs]
[<ffffffffa0d9726b>] xfs_buf_iorequest+0x6b/0xc0 [xfs]
[<ffffffffa0d97315>] xfs_bdstrat_cb+0x55/0xb0 [xfs]
[<ffffffffa0d97906>] xfs_bwrite+0x46/0x80 [xfs]
[<ffffffffa0dbfa94>] xfs_attr_rmtval_set+0x334/0x490 [xfs]
[<ffffffffa0db84aa>] xfs_attr_leaf_addname+0x24a/0x410 [xfs]
[<ffffffffa0db8893>] xfs_attr_set_int+0x223/0x470 [xfs]
[<ffffffffa0db8b76>] xfs_attr_set+0x96/0xb0 [xfs]
[<ffffffffa0db13b2>] xfs_xattr_set+0x42/0x70 [xfs]
[<ffffffff811df9b2>] generic_setxattr+0x62/0x80
[<ffffffff811e0213>] __vfs_setxattr_noperm+0x63/0x1b0
[<ffffffff81307afe>] ? evm_inode_setxattr+0xe/0x10
[<ffffffff811e0415>] vfs_setxattr+0xb5/0xc0
[<ffffffff811e054e>] setxattr+0x12e/0x1c0
[<ffffffff811c6e82>] ? final_putname+0x22/0x50
[<ffffffff811c708b>] ? putname+0x2b/0x40
[<ffffffff811cc4bf>] ? user_path_at_empty+0x5f/0x90
[<ffffffff811bdfd9>] ? __sb_start_write+0x49/0xe0
[<ffffffff81168589>] ? vm_mmap_pgoff+0x99/0xc0
[<ffffffff811e07df>] SyS_setxattr+0x8f/0xe0
[<ffffffff81700c2d>] system_call_fastpath+0x1a/0x1f
Tests:
setfattr -n user.longxattr -v `perl -e 'print "A"x65536'` testfile
This patch fix it to check the remote EA size is greater than the
XATTR_SIZE_MAX rather than more than or equal to it, because it's
valid if the specified EA value size is equal to the limitation as
per VFS setxattr interface.
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
(cherry picked from commit 85dd0707f0cad26d60f2dc574d17a5ab948d10f7)
1 parent ac8809f
| File | Mode | Size |
|---|---|---|
| fonts | ||
| lz4 | ||
| lzo | ||
| mpi | ||
| raid6 | ||
| reed_solomon | ||
| xz | ||
| zlib_deflate | ||
| zlib_inflate | ||
| .gitignore | -rw-r--r-- | 70 bytes |
| Kconfig | -rw-r--r-- | 9.8 KB |
| Kconfig.debug | -rw-r--r-- | 53.3 KB |
| Kconfig.kgdb | -rw-r--r-- | 3.1 KB |
| Kconfig.kmemcheck | -rw-r--r-- | 2.9 KB |
| Makefile | -rw-r--r-- | 5.7 KB |
| argv_split.c | -rw-r--r-- | 2.1 KB |
| asn1_decoder.c | -rw-r--r-- | 12.5 KB |
| assoc_array.c | -rw-r--r-- | 52.6 KB |
| atomic64.c | -rw-r--r-- | 4.2 KB |
| atomic64_test.c | -rw-r--r-- | 3.4 KB |
| audit.c | -rw-r--r-- | 1.2 KB |
| average.c | -rw-r--r-- | 1.9 KB |
| bcd.c | -rw-r--r-- | 261 bytes |
| bch.c | -rw-r--r-- | 35.6 KB |
| bitmap.c | -rw-r--r-- | 34.7 KB |
| bitrev.c | -rw-r--r-- | 2.1 KB |
| bsearch.c | -rw-r--r-- | 1.6 KB |
| btree.c | -rw-r--r-- | 19.2 KB |
| bug.c | -rw-r--r-- | 4.8 KB |
| build_OID_registry | -rwxr-xr-x | 4.7 KB |
| bust_spinlocks.c | -rw-r--r-- | 660 bytes |
| check_signature.c | -rw-r--r-- | 599 bytes |
| checksum.c | -rw-r--r-- | 4.9 KB |
| clz_ctz.c | -rw-r--r-- | 1009 bytes |
| clz_tab.c | -rw-r--r-- | 855 bytes |
| cmdline.c | -rw-r--r-- | 3.6 KB |
| cordic.c | -rw-r--r-- | 2.5 KB |
| cpu-notifier-error-inject.c | -rw-r--r-- | 1.2 KB |
| cpu_rmap.c | -rw-r--r-- | 7.8 KB |
| cpumask.c | -rw-r--r-- | 4.4 KB |
| crc-ccitt.c | -rw-r--r-- | 3.0 KB |
| crc-itu-t.c | -rw-r--r-- | 2.8 KB |
| crc-t10dif.c | -rw-r--r-- | 1.5 KB |
| crc16.c | -rw-r--r-- | 2.8 KB |
| crc32.c | -rw-r--r-- | 45.3 KB |
| crc32defs.h | -rw-r--r-- | 2.0 KB |
| crc7.c | -rw-r--r-- | 2.3 KB |
| crc8.c | -rw-r--r-- | 2.4 KB |
| ctype.c | -rw-r--r-- | 1.4 KB |
| debug_locks.c | -rw-r--r-- | 1.2 KB |
| debugobjects.c | -rw-r--r-- | 26.2 KB |
| dec_and_lock.c | -rw-r--r-- | 784 bytes |
| decompress.c | -rw-r--r-- | 1.5 KB |
| decompress_bunzip2.c | -rw-r--r-- | 23.4 KB |
| decompress_inflate.c | -rw-r--r-- | 3.7 KB |
| decompress_unlz4.c | -rw-r--r-- | 3.8 KB |
| decompress_unlzma.c | -rw-r--r-- | 15.8 KB |
| decompress_unlzo.c | -rw-r--r-- | 6.8 KB |
| decompress_unxz.c | -rw-r--r-- | 10.6 KB |
| devres.c | -rw-r--r-- | 10.2 KB |
| digsig.c | -rw-r--r-- | 5.5 KB |
| div64.c | -rw-r--r-- | 4.0 KB |
| dma-debug.c | -rw-r--r-- | 34.9 KB |
| dump_stack.c | -rw-r--r-- | 1.1 KB |
| dynamic_debug.c | -rw-r--r-- | 25.3 KB |
| dynamic_queue_limits.c | -rw-r--r-- | 4.3 KB |
| earlycpio.c | -rw-r--r-- | 3.9 KB |
| extable.c | -rw-r--r-- | 2.4 KB |
| fault-inject.c | -rw-r--r-- | 5.5 KB |
| fdt.c | -rw-r--r-- | 69 bytes |
| fdt_ro.c | -rw-r--r-- | 72 bytes |
| fdt_rw.c | -rw-r--r-- | 72 bytes |
| fdt_strerror.c | -rw-r--r-- | 78 bytes |
| fdt_sw.c | -rw-r--r-- | 72 bytes |
| fdt_wip.c | -rw-r--r-- | 73 bytes |
| find_last_bit.c | -rw-r--r-- | 1.1 KB |
| find_next_bit.c | -rw-r--r-- | 6.4 KB |
| flex_array.c | -rw-r--r-- | 10.9 KB |
| flex_proportions.c | -rw-r--r-- | 6.8 KB |
| gcd.c | -rw-r--r-- | 313 bytes |
| gen_crc32table.c | -rw-r--r-- | 3.2 KB |
| genalloc.c | -rw-r--r-- | 16.2 KB |
| halfmd4.c | -rw-r--r-- | 2.0 KB |
| hexdump.c | -rw-r--r-- | 7.2 KB |
| hweight.c | -rw-r--r-- | 1.9 KB |
| idr.c | -rw-r--r-- | 28.7 KB |
| inflate.c | -rw-r--r-- | 38.6 KB |
| int_sqrt.c | -rw-r--r-- | 652 bytes |
| interval_tree.c | -rw-r--r-- | 297 bytes |
| interval_tree_test_main.c | -rw-r--r-- | 2.3 KB |
| iomap.c | -rw-r--r-- | 6.5 KB |
| iomap_copy.c | -rw-r--r-- | 2.1 KB |
| iommu-helper.c | -rw-r--r-- | 1.0 KB |
| ioremap.c | -rw-r--r-- | 2.1 KB |
| iovec.c | -rw-r--r-- | 1.0 KB |
| irq_regs.c | -rw-r--r-- | 604 bytes |
| is_single_threaded.c | -rw-r--r-- | 1.3 KB |
| jedec_ddr_data.c | -rw-r--r-- | 3.0 KB |
| kasprintf.c | -rw-r--r-- | 717 bytes |
| kfifo.c | -rw-r--r-- | 12.7 KB |
| klist.c | -rw-r--r-- | 9.3 KB |
| kobject.c | -rw-r--r-- | 26.6 KB |
| kobject_uevent.c | -rw-r--r-- | 10.4 KB |
| kstrtox.c | -rw-r--r-- | 9.4 KB |
| kstrtox.h | -rw-r--r-- | 254 bytes |
| lcm.c | -rw-r--r-- | 288 bytes |
| libcrc32c.c | -rw-r--r-- | 2.1 KB |
| list_debug.c | -rw-r--r-- | 2.6 KB |
| list_sort.c | -rw-r--r-- | 7.0 KB |
| llist.c | -rw-r--r-- | 3.1 KB |
| locking-selftest-hardirq.h | -rw-r--r-- | 207 bytes |
| locking-selftest-mutex.h | -rw-r--r-- | 120 bytes |
| locking-selftest-rlock-hardirq.h | -rw-r--r-- | 74 bytes |
| locking-selftest-rlock-softirq.h | -rw-r--r-- | 74 bytes |
| locking-selftest-rlock.h | -rw-r--r-- | 158 bytes |
| locking-selftest-rsem.h | -rw-r--r-- | 163 bytes |
| locking-selftest-softirq.h | -rw-r--r-- | 207 bytes |
| locking-selftest-spin-hardirq.h | -rw-r--r-- | 73 bytes |
| locking-selftest-spin-softirq.h | -rw-r--r-- | 73 bytes |
| locking-selftest-spin.h | -rw-r--r-- | 118 bytes |
| locking-selftest-wlock-hardirq.h | -rw-r--r-- | 74 bytes |
| locking-selftest-wlock-softirq.h | -rw-r--r-- | 74 bytes |
| locking-selftest-wlock.h | -rw-r--r-- | 158 bytes |
| locking-selftest-wsem.h | -rw-r--r-- | 163 bytes |
| locking-selftest.c | -rw-r--r-- | 40.1 KB |
| lockref.c | -rw-r--r-- | 3.7 KB |
| lru_cache.c | -rw-r--r-- | 19.2 KB |
| md5.c | -rw-r--r-- | 3.7 KB |
| memory-notifier-error-inject.c | -rw-r--r-- | 1.1 KB |
| memweight.c | -rw-r--r-- | 999 bytes |
| net_utils.c | -rw-r--r-- | 588 bytes |
| nlattr.c | -rw-r--r-- | 12.4 KB |
| notifier-error-inject.c | -rw-r--r-- | 2.7 KB |
| notifier-error-inject.h | -rw-r--r-- | 614 bytes |
| of-reconfig-notifier-error-inject.c | -rw-r--r-- | 1.3 KB |
| oid_registry.c | -rw-r--r-- | 3.8 KB |
| parser.c | -rw-r--r-- | 6.2 KB |
| pci_iomap.c | -rw-r--r-- | 1.4 KB |
| percpu-refcount.c | -rw-r--r-- | 5.7 KB |
| percpu_counter.c | -rw-r--r-- | 5.3 KB |
| percpu_ida.c | -rw-r--r-- | 9.6 KB |
| percpu_test.c | -rw-r--r-- | 3.2 KB |
| plist.c | -rw-r--r-- | 4.7 KB |
| pm-notifier-error-inject.c | -rw-r--r-- | 1.1 KB |
| prio_heap.c | -rw-r--r-- | 1.4 KB |
| proportions.c | -rw-r--r-- | 9.3 KB |
| radix-tree.c | -rw-r--r-- | 40.0 KB |
| random32.c | -rw-r--r-- | 12.3 KB |
| ratelimit.c | -rw-r--r-- | 1.5 KB |
| rational.c | -rw-r--r-- | 1.5 KB |
| rbtree.c | -rw-r--r-- | 15.0 KB |
| rbtree_test.c | -rw-r--r-- | 5.3 KB |
| reciprocal_div.c | -rw-r--r-- | 218 bytes |
| scatterlist.c | -rw-r--r-- | 17.8 KB |
| sha1.c | -rw-r--r-- | 6.1 KB |
| show_mem.c | -rw-r--r-- | 1.1 KB |
| smp_processor_id.c | -rw-r--r-- | 1.1 KB |
| sort.c | -rw-r--r-- | 2.5 KB |
| stmp_device.c | -rw-r--r-- | 2.1 KB |
| string.c | -rw-r--r-- | 16.2 KB |
| string_helpers.c | -rw-r--r-- | 3.6 KB |
| strncpy_from_user.c | -rw-r--r-- | 2.9 KB |
| strnlen_user.c | -rw-r--r-- | 3.6 KB |
| swiotlb.c | -rw-r--r-- | 26.8 KB |
| syscall.c | -rw-r--r-- | 2.4 KB |
| test-kstrtox.c | -rw-r--r-- | 17.4 KB |
| test-string_helpers.c | -rw-r--r-- | 2.5 KB |
| textsearch.c | -rw-r--r-- | 9.6 KB |
| timerqueue.c | -rw-r--r-- | 3.1 KB |
| ts_bm.c | -rw-r--r-- | 5.3 KB |
| ts_fsm.c | -rw-r--r-- | 10.6 KB |
| ts_kmp.c | -rw-r--r-- | 4.3 KB |
| ucs2_string.c | -rw-r--r-- | 1.2 KB |
| usercopy.c | -rw-r--r-- | 197 bytes |
| uuid.c | -rw-r--r-- | 1.3 KB |
| vsprintf.c | -rw-r--r-- | 58.3 KB |
Computing file changes ...
