Revision bd13b2b874eceb4677cd26eebdc5f45cc52fa400 authored by Nicholas Kazlauskas on 01 February 2019, 14:36:59 UTC, committed by Alex Deucher on 08 April 2019, 15:33:40 UTC
[Why] If the cursor pos passed from DM is less than the plane_state->dst_rect top left corner then the unsigned cursor pos wraps around to a large positive number since cursor pos is a u32. There was an attempt to guard against this in hubp1_cursor_set_position by checking the src_x_offset and src_y_offset and offseting the cursor hotspot within hubp1_cursor_set_position. However, the cursor position itself is still being programmed incorrectly as a large value. This manifests itself visually as the cursor disappearing or containing strange artifacts near the middle of the screen on raven. [How] Don't subtract the destination rect top left corner from the pos but add it to the hotspot instead. This happens before the pos gets passed into hubp1_cursor_set_position. This achieves the same result but avoids the subtraction wrap around. With this fix the original cursor programming logic can be used again. v2: add hunk that got dropped accidently when this patch was originally committed. (Alex) Fixes: 0921c41e1902831 ("drm/amd/display: Fix negative cursor pos programming") Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> Reviewed-by: Charlene Liu <Charlene.Liu@amd.com> Acked-by: Leo Li <sunpeng.li@amd.com> Acked-by: Murton Liu <Murton.Liu@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent c1cefe1
File | Mode | Size |
---|---|---|
firmware_loader | ||
power | ||
regmap | ||
test | ||
Kconfig | -rw-r--r-- | 6.6 KB |
Makefile | -rw-r--r-- | 955 bytes |
arch_topology.c | -rw-r--r-- | 6.5 KB |
attribute_container.c | -rw-r--r-- | 11.9 KB |
base.h | -rw-r--r-- | 6.4 KB |
bus.c | -rw-r--r-- | 30.8 KB |
cacheinfo.c | -rw-r--r-- | 16.9 KB |
class.c | -rw-r--r-- | 14.8 KB |
component.c | -rw-r--r-- | 20.5 KB |
container.c | -rw-r--r-- | 814 bytes |
core.c | -rw-r--r-- | 87.1 KB |
cpu.c | -rw-r--r-- | 14.1 KB |
dd.c | -rw-r--r-- | 31.6 KB |
devcon.c | -rw-r--r-- | 4.8 KB |
devcoredump.c | -rw-r--r-- | 9.3 KB |
devres.c | -rw-r--r-- | 27.1 KB |
devtmpfs.c | -rw-r--r-- | 9.1 KB |
driver.c | -rw-r--r-- | 5.8 KB |
firmware.c | -rw-r--r-- | 606 bytes |
hypervisor.c | -rw-r--r-- | 536 bytes |
init.c | -rw-r--r-- | 768 bytes |
isa.c | -rw-r--r-- | 3.8 KB |
map.c | -rw-r--r-- | 3.3 KB |
memory.c | -rw-r--r-- | 19.9 KB |
module.c | -rw-r--r-- | 2.0 KB |
node.c | -rw-r--r-- | 18.4 KB |
pinctrl.c | -rw-r--r-- | 2.7 KB |
platform-msi.c | -rw-r--r-- | 10.6 KB |
platform.c | -rw-r--r-- | 37.5 KB |
property.c | -rw-r--r-- | 32.8 KB |
soc.c | -rw-r--r-- | 6.2 KB |
swnode.c | -rw-r--r-- | 16.0 KB |
syscore.c | -rw-r--r-- | 3.2 KB |
topology.c | -rw-r--r-- | 3.2 KB |
transport_class.c | -rw-r--r-- | 9.3 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...