Revision bd13b2b874eceb4677cd26eebdc5f45cc52fa400 authored by Nicholas Kazlauskas on 01 February 2019, 14:36:59 UTC, committed by Alex Deucher on 08 April 2019, 15:33:40 UTC
[Why] If the cursor pos passed from DM is less than the plane_state->dst_rect top left corner then the unsigned cursor pos wraps around to a large positive number since cursor pos is a u32. There was an attempt to guard against this in hubp1_cursor_set_position by checking the src_x_offset and src_y_offset and offseting the cursor hotspot within hubp1_cursor_set_position. However, the cursor position itself is still being programmed incorrectly as a large value. This manifests itself visually as the cursor disappearing or containing strange artifacts near the middle of the screen on raven. [How] Don't subtract the destination rect top left corner from the pos but add it to the hotspot instead. This happens before the pos gets passed into hubp1_cursor_set_position. This achieves the same result but avoids the subtraction wrap around. With this fix the original cursor programming logic can be used again. v2: add hunk that got dropped accidently when this patch was originally committed. (Alex) Fixes: 0921c41e1902831 ("drm/amd/display: Fix negative cursor pos programming") Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> Reviewed-by: Charlene Liu <Charlene.Liu@amd.com> Acked-by: Leo Li <sunpeng.li@amd.com> Acked-by: Murton Liu <Murton.Liu@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent c1cefe1
File | Mode | Size |
---|---|---|
samsung | ||
tegra | ||
Kconfig | -rw-r--r-- | 5.2 KB |
Makefile | -rw-r--r-- | 1.0 KB |
Makefile.asm-offsets | -rw-r--r-- | 163 bytes |
atmel-ebi.c | -rw-r--r-- | 14.7 KB |
atmel-sdramc.c | -rw-r--r-- | 2.3 KB |
brcmstb_dpfe.c | -rw-r--r-- | 18.7 KB |
da8xx-ddrctl.c | -rw-r--r-- | 4.1 KB |
emif-asm-offsets.c | -rw-r--r-- | 633 bytes |
emif.c | -rw-r--r-- | 54.7 KB |
emif.h | -rw-r--r-- | 19.6 KB |
fsl-corenet-cf.c | -rw-r--r-- | 6.7 KB |
fsl_ifc.c | -rw-r--r-- | 8.9 KB |
jz4780-nemc.c | -rw-r--r-- | 9.7 KB |
mtk-smi.c | -rw-r--r-- | 11.3 KB |
mvebu-devbus.c | -rw-r--r-- | 9.9 KB |
of_memory.c | -rw-r--r-- | 4.8 KB |
of_memory.h | -rw-r--r-- | 1.1 KB |
omap-gpmc.c | -rw-r--r-- | 68.8 KB |
pl172.c | -rw-r--r-- | 8.1 KB |
pl353-smc.c | -rw-r--r-- | 12.2 KB |
ti-aemif.c | -rw-r--r-- | 12.6 KB |
ti-emif-pm.c | -rw-r--r-- | 9.5 KB |
ti-emif-sram-pm.S | -rw-r--r-- | 9.9 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...