Revision bd13b2b874eceb4677cd26eebdc5f45cc52fa400 authored by Nicholas Kazlauskas on 01 February 2019, 14:36:59 UTC, committed by Alex Deucher on 08 April 2019, 15:33:40 UTC
[Why] If the cursor pos passed from DM is less than the plane_state->dst_rect top left corner then the unsigned cursor pos wraps around to a large positive number since cursor pos is a u32. There was an attempt to guard against this in hubp1_cursor_set_position by checking the src_x_offset and src_y_offset and offseting the cursor hotspot within hubp1_cursor_set_position. However, the cursor position itself is still being programmed incorrectly as a large value. This manifests itself visually as the cursor disappearing or containing strange artifacts near the middle of the screen on raven. [How] Don't subtract the destination rect top left corner from the pos but add it to the hotspot instead. This happens before the pos gets passed into hubp1_cursor_set_position. This achieves the same result but avoids the subtraction wrap around. With this fix the original cursor programming logic can be used again. v2: add hunk that got dropped accidently when this patch was originally committed. (Alex) Fixes: 0921c41e1902831 ("drm/amd/display: Fix negative cursor pos programming") Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> Reviewed-by: Charlene Liu <Charlene.Liu@amd.com> Acked-by: Leo Li <sunpeng.li@amd.com> Acked-by: Murton Liu <Murton.Liu@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent c1cefe1
File | Mode | Size |
---|---|---|
actions | ||
aspeed | ||
bcm | ||
berlin | ||
cirrus | ||
freescale | ||
intel | ||
mediatek | ||
meson | ||
mvebu | ||
nomadik | ||
nuvoton | ||
pxa | ||
qcom | ||
samsung | ||
sh-pfc | ||
sirf | ||
spear | ||
sprd | ||
stm32 | ||
sunxi | ||
tegra | ||
ti | ||
uniphier | ||
vt8500 | ||
zte | ||
Kconfig | -rw-r--r-- | 10.2 KB |
Makefile | -rw-r--r-- | 2.7 KB |
core.c | -rw-r--r-- | 56.2 KB |
core.h | -rw-r--r-- | 8.1 KB |
devicetree.c | -rw-r--r-- | 11.1 KB |
devicetree.h | -rw-r--r-- | 1.7 KB |
pinconf-generic.c | -rw-r--r-- | 12.1 KB |
pinconf.c | -rw-r--r-- | 9.4 KB |
pinconf.h | -rw-r--r-- | 3.3 KB |
pinctrl-amd.c | -rw-r--r-- | 25.8 KB |
pinctrl-amd.h | -rw-r--r-- | 6.7 KB |
pinctrl-artpec6.c | -rw-r--r-- | 26.0 KB |
pinctrl-as3722.c | -rw-r--r-- | 17.2 KB |
pinctrl-at91-pio4.c | -rw-r--r-- | 31.6 KB |
pinctrl-at91.c | -rw-r--r-- | 51.7 KB |
pinctrl-at91.h | -rw-r--r-- | 3.7 KB |
pinctrl-axp209.c | -rw-r--r-- | 12.8 KB |
pinctrl-coh901.c | -rw-r--r-- | 20.5 KB |
pinctrl-coh901.h | -rw-r--r-- | 237 bytes |
pinctrl-da850-pupd.c | -rw-r--r-- | 5.3 KB |
pinctrl-digicolor.c | -rw-r--r-- | 8.7 KB |
pinctrl-falcon.c | -rw-r--r-- | 14.6 KB |
pinctrl-gemini.c | -rw-r--r-- | 77.1 KB |
pinctrl-ingenic.c | -rw-r--r-- | 52.1 KB |
pinctrl-lantiq.c | -rw-r--r-- | 8.8 KB |
pinctrl-lantiq.h | -rw-r--r-- | 3.6 KB |
pinctrl-lpc18xx.c | -rw-r--r-- | 42.2 KB |
pinctrl-max77620.c | -rw-r--r-- | 18.1 KB |
pinctrl-mcp23s08.c | -rw-r--r-- | 30.2 KB |
pinctrl-ocelot.c | -rw-r--r-- | 20.2 KB |
pinctrl-oxnas.c | -rw-r--r-- | 36.2 KB |
pinctrl-palmas.c | -rw-r--r-- | 32.6 KB |
pinctrl-pic32.c | -rw-r--r-- | 81.3 KB |
pinctrl-pic32.h | -rw-r--r-- | 3.0 KB |
pinctrl-pistachio.c | -rw-r--r-- | 40.7 KB |
pinctrl-rk805.c | -rw-r--r-- | 12.3 KB |
pinctrl-rockchip.c | -rw-r--r-- | 95.2 KB |
pinctrl-rza1.c | -rw-r--r-- | 36.9 KB |
pinctrl-rza2.c | -rw-r--r-- | 14.2 KB |
pinctrl-rzn1.c | -rw-r--r-- | 25.6 KB |
pinctrl-single.c | -rw-r--r-- | 47.9 KB |
pinctrl-st.c | -rw-r--r-- | 47.0 KB |
pinctrl-sx150x.c | -rw-r--r-- | 29.2 KB |
pinctrl-tb10x.c | -rw-r--r-- | 27.0 KB |
pinctrl-u300.c | -rw-r--r-- | 36.1 KB |
pinctrl-utils.c | -rw-r--r-- | 3.7 KB |
pinctrl-utils.h | -rw-r--r-- | 1.7 KB |
pinctrl-xway.c | -rw-r--r-- | 65.8 KB |
pinctrl-zynq.c | -rw-r--r-- | 42.6 KB |
pinmux.c | -rw-r--r-- | 20.6 KB |
pinmux.h | -rw-r--r-- | 4.0 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...