Skip to main content

Browse the archive

https://github.com/torvalds/linux
23 October 2021, 00:29:24 UTC
Revision be6cef69ba570ebb327eba1ef6438f7af49aaf86 authored by Dmitry Bogdanov on 30 August 2019, 12:08:38 UTC, committed by David S. Miller on 01 September 2019, 02:07:11 UTC 
net: aquantia: fix out of memory condition on rx side
 
On embedded environments with hard memory limits it is a normal although
rare case when skb can't be allocated on rx part under high traffic.

In such OOM cases napi_complete_done() was not called.
So the napi object became in an invalid state like it is "scheduled".
Kernel do not re-schedules the poll of that napi object.

Consequently, kernel can not remove that object the system hangs on
`ifconfig down` waiting for a poll.

We are fixing this by gracefully closing napi poll routine with correct
invocation of napi_complete_done.

This was reproduced with artificially failing the allocation of skb to
simulate an "out of memory" error case and check that traffic does
not get stuck.

Fixes: 970a2e9864b0 ("net: ethernet: aquantia: Vector operations")
Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
Signed-off-by: Dmitry Bogdanov <dmitry.bogdanov@aquantia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 5c47e3b
History
Tip revision: be6cef69ba570ebb327eba1ef6438f7af49aaf86 authored by Dmitry Bogdanov on 30 August 2019, 12:08:38 UTC
net: aquantia: fix out of memory condition on rx side
Tip revision: be6cef6
File Mode Size
deprecated
dual
exceptions
preferred
back to top