Revision beb44ec3ebf665f60b3aa9cccb99e7c305a7472f authored by Siying Dong on 16 April 2019, 18:59:35 UTC, committed by Facebook Github Bot on 16 April 2019, 19:03:07 UTC
Summary: Dummy cache size of 1MB is too large for small block sizes. Our GetDefaultCacheShardBits() use min_shard_size = 512L * 1024L to determine number of shards, so 1MB will excceeds the size of the whole shard and make the cache excceeds the budget. Change it to 256KB accordingly. There shouldn't be obvious performance impact, since inserting a cache entry every 256KB of memtable inserts is still infrequently enough. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5175 Differential Revision: D14954289 Pulled By: siying fbshipit-source-id: 2c275255c1ac3992174e06529e44c55538325c94
1 parent f1239d5
| File | Mode | Size |
|---|---|---|
| cache_bench.cc | -rw-r--r-- | 7.4 KB |
| cache_test.cc | -rw-r--r-- | 20.0 KB |
| clock_cache.cc | -rw-r--r-- | 25.9 KB |
| clock_cache.h | -rw-r--r-- | 601 bytes |
| lru_cache.cc | -rw-r--r-- | 15.7 KB |
| lru_cache.h | -rw-r--r-- | 10.5 KB |
| lru_cache_test.cc | -rw-r--r-- | 6.0 KB |
| sharded_cache.cc | -rw-r--r-- | 5.0 KB |
| sharded_cache.h | -rw-r--r-- | 4.1 KB |
Computing file changes ...
