https://github.com/torvalds/linux
Revision beb69f15a095245c5cc62389eea93002b41d2eb9 authored by Gustavo A. R. Silva on 23 March 2020, 22:23:01 UTC, committed by Gustavo A. R. Silva on 18 April 2020, 20:44:54 UTC
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on. Also, notice that, dynamic memory allocations won't be affected by this change: "Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1] This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
1 parent 1921994
Tip revision: beb69f15a095245c5cc62389eea93002b41d2eb9 authored by Gustavo A. R. Silva on 23 March 2020, 22:23:01 UTC
energy_model.h: Replace zero-length array with flexible-array member
energy_model.h: Replace zero-length array with flexible-array member
Tip revision: beb69f1
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 73.5 KB |
Makefile | -rw-r--r-- | 1.2 KB |
calibrate.c | -rw-r--r-- | 8.6 KB |
do_mounts.c | -rw-r--r-- | 16.0 KB |
do_mounts.h | -rw-r--r-- | 1.1 KB |
do_mounts_initrd.c | -rw-r--r-- | 3.4 KB |
do_mounts_md.c | -rw-r--r-- | 7.9 KB |
do_mounts_rd.c | -rw-r--r-- | 8.1 KB |
init_task.c | -rw-r--r-- | 5.4 KB |
initramfs.c | -rw-r--r-- | 14.5 KB |
main.c | -rw-r--r-- | 35.8 KB |
noinitramfs.c | -rw-r--r-- | 873 bytes |
version.c | -rw-r--r-- | 1.3 KB |
Computing file changes ...