Revision bf1f9a08970726a97daa5a22002e4aa2a7df121f authored by Kristiyan Kostadinov on 16 September 2023, 07:35:39 UTC, committed by Pawel Kozlowski on 18 September 2023, 08:46:38 UTC
Another try at deflaking the tests on Windows. I'm trying a couple of fixes here: 1. I noticed that it's usually the indexer tests that fail during flaky runs. These tests also happen to be the only ones that don't pass in the `files` argument of `NgtscTestEnvironment.setup`. When `files` isn't passed in, we don't hit the file path that sets up the `MockFileSystem`. With these changes I make it so that we always initialize the mock file system. 2. The missing file system error usually comes from the `absoluteFrom` call that initializes the optional `workingDir` argument. My theory is that because it's a default value for an argument, it gets called too early before everything is initialized. These changes move the `absoluteFrom` call further down until it's needed. PR Close #51804
1 parent 3b46066
File | Mode | Size |
---|---|---|
README.md | -rw-r--r-- | 2.5 KB |
recommended-Dockerfile | -rw-r--r-- | 687 bytes |
recommended-devcontainer.json | -rw-r--r-- | 579 bytes |
Computing file changes ...