Revision c06c4c01c5891220ec212c497678477a7d55f89c authored by Adam Simpkins on 04 April 2019, 19:05:42 UTC, committed by Facebook Github Bot on 04 April 2019, 19:12:11 UTC
Summary: Annotate all of the logging functions to inform the compiler that these use printf-style formatting arguments. This allows the compiler to emit warnings if the format arguments are incorrect. This also fixes many problems reported now that format string checking is enabled. Many of these are simply mix-ups in the argument type (e.g, int vs uint64_t), but in several cases the wrong number of arguments were being passed in which can cause the code to crash. The primary motivation for this was to fix the log message in `DBImpl::SwitchMemtable()` which caused a segfault due to an extra %s format parameter with no argument supplied. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5089 Differential Revision: D14574795 Pulled By: simpkins fbshipit-source-id: 0921b03f0743652bf4ae21e414ff54b3bb65422a
1 parent f0edf9d
File | Mode | Size |
---|---|---|
buckify_rocksdb.py | -rw-r--r-- | 5.1 KB |
rocks_test_runner.sh | -rwxr-xr-x | 196 bytes |
targets_builder.py | -rw-r--r-- | 2.0 KB |
targets_cfg.py | -rw-r--r-- | 3.6 KB |
util.py | -rw-r--r-- | 3.1 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...