Revision c4efe484b5f0d768e23c9731082fec827723e738 authored by Qian Cai on 29 March 2019, 03:44:16 UTC, committed by Linus Torvalds on 29 March 2019, 17:01:37 UTC
When start_isolate_page_range() returned -EBUSY in __offline_pages(), it
calls memory_notify(MEM_CANCEL_OFFLINE, &arg) with an uninitialized
"arg". As the result, it triggers warnings below. Also, it is only
necessary to notify MEM_CANCEL_OFFLINE after MEM_GOING_OFFLINE.
page:ffffea0001200000 count:1 mapcount:0 mapping:0000000000000000
index:0x0
flags: 0x3fffe000001000(reserved)
raw: 003fffe000001000 ffffea0001200008 ffffea0001200008 0000000000000000
raw: 0000000000000000 0000000000000000 00000001ffffffff 0000000000000000
page dumped because: unmovable page
WARNING: CPU: 25 PID: 1665 at mm/kasan/common.c:665
kasan_mem_notifier+0x34/0x23b
CPU: 25 PID: 1665 Comm: bash Tainted: G W 5.0.0+ #94
Hardware name: HP ProLiant DL180 Gen9/ProLiant DL180 Gen9, BIOS U20
10/25/2017
RIP: 0010:kasan_mem_notifier+0x34/0x23b
RSP: 0018:ffff8883ec737890 EFLAGS: 00010206
RAX: 0000000000000246 RBX: ff10f0f4435f1000 RCX: f887a7a21af88000
RDX: dffffc0000000000 RSI: 0000000000000020 RDI: ffff8881f221af88
RBP: ffff8883ec737898 R08: ffff888000000000 R09: ffffffffb0bddcd0
R10: ffffed103e857088 R11: ffff8881f42b8443 R12: dffffc0000000000
R13: 00000000fffffff9 R14: dffffc0000000000 R15: 0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000560fbd31d730 CR3: 00000004049c6003 CR4: 00000000001606a0
Call Trace:
notifier_call_chain+0xbf/0x130
__blocking_notifier_call_chain+0x76/0xc0
blocking_notifier_call_chain+0x16/0x20
memory_notify+0x1b/0x20
__offline_pages+0x3e2/0x1210
offline_pages+0x11/0x20
memory_block_action+0x144/0x300
memory_subsys_offline+0xe5/0x170
device_offline+0x13f/0x1e0
state_store+0xeb/0x110
dev_attr_store+0x3f/0x70
sysfs_kf_write+0x104/0x150
kernfs_fop_write+0x25c/0x410
__vfs_write+0x66/0x120
vfs_write+0x15a/0x4f0
ksys_write+0xd2/0x1b0
__x64_sys_write+0x73/0xb0
do_syscall_64+0xeb/0xb78
entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x7f14f75cc3b8
RSP: 002b:00007ffe84d01d68 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 0000000000000008 RCX: 00007f14f75cc3b8
RDX: 0000000000000008 RSI: 0000563f8e433d70 RDI: 0000000000000001
RBP: 0000563f8e433d70 R08: 000000000000000a R09: 00007ffe84d018f0
R10: 000000000000000a R11: 0000000000000246 R12: 00007f14f789e780
R13: 0000000000000008 R14: 00007f14f7899740 R15: 0000000000000008
Link: http://lkml.kernel.org/r/20190320204255.53571-1-cai@lca.pw
Fixes: 7960509329c2 ("mm, memory_hotplug: print reason for the offlining failure")
Reviewed-by: Oscar Salvador <osalvador@suse.de>
Acked-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Qian Cai <cai@lca.pw>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: <stable@vger.kernel.org> [5.0.x]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent fcfc2aa
| File | Mode | Size |
|---|---|---|
| kasan | ||
| Kconfig | -rw-r--r-- | 24.6 KB |
| Kconfig.debug | -rw-r--r-- | 4.3 KB |
| Makefile | -rw-r--r-- | 3.5 KB |
| backing-dev.c | -rw-r--r-- | 27.0 KB |
| balloon_compaction.c | -rw-r--r-- | 5.5 KB |
| cleancache.c | -rw-r--r-- | 9.9 KB |
| cma.c | -rw-r--r-- | 14.1 KB |
| cma.h | -rw-r--r-- | 573 bytes |
| cma_debug.c | -rw-r--r-- | 4.5 KB |
| compaction.c | -rw-r--r-- | 74.7 KB |
| debug.c | -rw-r--r-- | 5.9 KB |
| debug_page_ref.c | -rw-r--r-- | 1.4 KB |
| dmapool.c | -rw-r--r-- | 13.9 KB |
| early_ioremap.c | -rw-r--r-- | 6.8 KB |
| fadvise.c | -rw-r--r-- | 5.3 KB |
| failslab.c | -rw-r--r-- | 1.4 KB |
| filemap.c | -rw-r--r-- | 95.4 KB |
| frame_vector.c | -rw-r--r-- | 6.4 KB |
| frontswap.c | -rw-r--r-- | 14.2 KB |
| gup.c | -rw-r--r-- | 54.9 KB |
| gup_benchmark.c | -rw-r--r-- | 2.7 KB |
| highmem.c | -rw-r--r-- | 11.7 KB |
| hmm.c | -rw-r--r-- | 33.2 KB |
| huge_memory.c | -rw-r--r-- | 81.8 KB |
| hugetlb.c | -rw-r--r-- | 133.0 KB |
| hugetlb_cgroup.c | -rw-r--r-- | 10.9 KB |
| hwpoison-inject.c | -rw-r--r-- | 3.2 KB |
| init-mm.c | -rw-r--r-- | 1.2 KB |
| internal.h | -rw-r--r-- | 17.3 KB |
| interval_tree.c | -rw-r--r-- | 3.1 KB |
| khugepaged.c | -rw-r--r-- | 48.1 KB |
| kmemleak-test.c | -rw-r--r-- | 3.2 KB |
| kmemleak.c | -rw-r--r-- | 60.2 KB |
| ksm.c | -rw-r--r-- | 89.4 KB |
| list_lru.c | -rw-r--r-- | 14.6 KB |
| maccess.c | -rw-r--r-- | 3.1 KB |
| madvise.c | -rw-r--r-- | 22.9 KB |
| memblock.c | -rw-r--r-- | 54.9 KB |
| memcontrol.c | -rw-r--r-- | 169.9 KB |
| memfd.c | -rw-r--r-- | 7.8 KB |
| memory-failure.c | -rw-r--r-- | 52.1 KB |
| memory.c | -rw-r--r-- | 124.5 KB |
| memory_hotplug.c | -rw-r--r-- | 48.7 KB |
| mempolicy.c | -rw-r--r-- | 72.4 KB |
| mempool.c | -rw-r--r-- | 15.8 KB |
| memtest.c | -rw-r--r-- | 2.8 KB |
| migrate.c | -rw-r--r-- | 76.7 KB |
| mincore.c | -rw-r--r-- | 6.7 KB |
| mlock.c | -rw-r--r-- | 22.6 KB |
| mm_init.c | -rw-r--r-- | 4.8 KB |
| mmap.c | -rw-r--r-- | 99.9 KB |
| mmu_context.c | -rw-r--r-- | 1.3 KB |
| mmu_gather.c | -rw-r--r-- | 6.3 KB |
| mmu_notifier.c | -rw-r--r-- | 11.5 KB |
| mmzone.c | -rw-r--r-- | 2.4 KB |
| mprotect.c | -rw-r--r-- | 15.6 KB |
| mremap.c | -rw-r--r-- | 19.3 KB |
| msync.c | -rw-r--r-- | 2.6 KB |
| nommu.c | -rw-r--r-- | 47.6 KB |
| oom_kill.c | -rw-r--r-- | 30.3 KB |
| page-writeback.c | -rw-r--r-- | 84.4 KB |
| page_alloc.c | -rw-r--r-- | 232.7 KB |
| page_counter.c | -rw-r--r-- | 6.6 KB |
| page_ext.c | -rw-r--r-- | 11.0 KB |
| page_idle.c | -rw-r--r-- | 5.5 KB |
| page_io.c | -rw-r--r-- | 10.5 KB |
| page_isolation.c | -rw-r--r-- | 9.2 KB |
| page_owner.c | -rw-r--r-- | 15.1 KB |
| page_poison.c | -rw-r--r-- | 3.0 KB |
| page_vma_mapped.c | -rw-r--r-- | 7.6 KB |
| pagewalk.c | -rw-r--r-- | 8.7 KB |
| percpu-internal.h | -rw-r--r-- | 5.9 KB |
| percpu-km.c | -rw-r--r-- | 3.0 KB |
| percpu-stats.c | -rw-r--r-- | 5.7 KB |
| percpu-vm.c | -rw-r--r-- | 10.3 KB |
| percpu.c | -rw-r--r-- | 85.7 KB |
| pgtable-generic.c | -rw-r--r-- | 5.3 KB |
| process_vm_access.c | -rw-r--r-- | 10.0 KB |
| quicklist.c | -rw-r--r-- | 2.4 KB |
| readahead.c | -rw-r--r-- | 16.5 KB |
| rmap.c | -rw-r--r-- | 53.7 KB |
| rodata_test.c | -rw-r--r-- | 1.4 KB |
| shmem.c | -rw-r--r-- | 104.8 KB |
| slab.c | -rw-r--r-- | 111.2 KB |
| slab.h | -rw-r--r-- | 14.6 KB |
| slab_common.c | -rw-r--r-- | 39.1 KB |
| slob.c | -rw-r--r-- | 16.2 KB |
| slub.c | -rw-r--r-- | 143.1 KB |
| sparse-vmemmap.c | -rw-r--r-- | 6.6 KB |
| sparse.c | -rw-r--r-- | 21.4 KB |
| swap.c | -rw-r--r-- | 28.6 KB |
| swap_cgroup.c | -rw-r--r-- | 5.2 KB |
| swap_slots.c | -rw-r--r-- | 9.4 KB |
| swap_state.c | -rw-r--r-- | 22.4 KB |
| swapfile.c | -rw-r--r-- | 91.6 KB |
| truncate.c | -rw-r--r-- | 26.4 KB |
| usercopy.c | -rw-r--r-- | 9.5 KB |
| userfaultfd.c | -rw-r--r-- | 16.0 KB |
| util.c | -rw-r--r-- | 20.0 KB |
| vmacache.c | -rw-r--r-- | 2.7 KB |
| vmalloc.c | -rw-r--r-- | 70.9 KB |
| vmpressure.c | -rw-r--r-- | 13.9 KB |
| vmscan.c | -rw-r--r-- | 122.8 KB |
| vmstat.c | -rw-r--r-- | 51.6 KB |
| workingset.c | -rw-r--r-- | 19.1 KB |
| z3fold.c | -rw-r--r-- | 30.6 KB |
| zbud.c | -rw-r--r-- | 18.2 KB |
| zpool.c | -rw-r--r-- | 10.7 KB |
| zsmalloc.c | -rw-r--r-- | 60.4 KB |
| zswap.c | -rw-r--r-- | 34.7 KB |
Computing file changes ...
