Revision c6d04f2ecf368fdfb2151cd10a1febf6404441cf authored by Sagar Vemuri on 30 March 2017, 18:57:05 UTC, committed by Facebook Github Bot on 30 March 2017, 19:09:21 UTC
Summary:
Operations like Seek/Next/Prev sometimes take too long to complete when there are many internal keys to be skipped. Adding an option, max_skippable_internal_keys -- which could be used to set a threshold for the maximum number of keys that can be skipped, will help to address these cases where it is much better to fail a request (as incomplete) than to wait for a considerable time for the request to complete.

This feature -- to fail an iterator seek request as incomplete, is disabled by default when max_skippable_internal_keys = 0. It is enabled only when max_skippable_internal_keys > 0.

This feature is based on the discussion mentioned in the PR https://github.com/facebook/rocksdb/pull/1084.
Closes https://github.com/facebook/rocksdb/pull/2000

Differential Revision: D4753223

Pulled By: sagar0

fbshipit-source-id: 1c973f7
1 parent 58179ec
History
File Mode Size
dump
rdb
CMakeLists.txt -rw-r--r-- 544 bytes
Dockerfile -rw-r--r-- 81 bytes
auto_sanity_test.sh -rwxr-xr-x 2.6 KB
benchmark.sh -rwxr-xr-x 16.5 KB
benchmark_leveldb.sh -rwxr-xr-x 5.1 KB
check_format_compatible.sh -rwxr-xr-x 3.8 KB
db_bench.cc -rw-r--r-- 851 bytes
db_bench_tool.cc -rw-r--r-- 178.2 KB
db_bench_tool_test.cc -rw-r--r-- 9.7 KB
db_crashtest.py -rw-r--r-- 13.2 KB
db_repl_stress.cc -rw-r--r-- 4.5 KB
db_sanity_test.cc -rw-r--r-- 8.4 KB
db_stress.cc -rw-r--r-- 84.1 KB
dbench_monitor -rwxr-xr-x 2.6 KB
generate_random_db.sh -rwxr-xr-x 726 bytes
ldb.cc -rw-r--r-- 602 bytes
ldb_cmd.cc -rw-r--r-- 93.4 KB
ldb_cmd_impl.h -rw-r--r-- 14.0 KB
ldb_cmd_test.cc -rw-r--r-- 1.8 KB
ldb_test.py -rw-r--r-- 23.6 KB
ldb_tool.cc -rw-r--r-- 4.4 KB
pflag -rwxr-xr-x 4.0 KB
reduce_levels_test.cc -rw-r--r-- 5.2 KB
regression_test.sh -rwxr-xr-x 14.8 KB
rocksdb_dump_test.sh -rwxr-xr-x 325 bytes
run_flash_bench.sh -rwxr-xr-x 13.4 KB
run_leveldb.sh -rwxr-xr-x 6.2 KB
sample-dump.dmp -rw-r--r-- 100 bytes
sst_dump.cc -rw-r--r-- 611 bytes
sst_dump_test.cc -rw-r--r-- 6.4 KB
sst_dump_tool.cc -rw-r--r-- 22.0 KB
sst_dump_tool_imp.h -rw-r--r-- 2.7 KB
verify_random_db.sh -rwxr-xr-x 710 bytes
write_stress.cc -rw-r--r-- 10.8 KB
write_stress_runner.py -rw-r--r-- 2.2 KB

back to top