Revision c6d464a9da7291e776b5a017f0a5d33d61f2518b authored by Adam Retter on 28 February 2017, 00:26:12 UTC, committed by Facebook Github Bot on 28 February 2017, 00:39:12 UTC
Summary:
I have manually audited the entire RocksJava code base.

Sorry for the large pull-request, I have broken it down into many small atomic commits though.

My initial intention was to fix the warnings that appear when running RocksJava on Java 8 with `-Xcheck:jni`, for example when running `make jtest` you would see many errors similar to:

```
WARNING in native method: JNI call made without checking exceptions when required to from CallObjectMethod
WARNING in native method: JNI call made without checking exceptions when required to from CallVoidMethod
WARNING in native method: JNI call made without checking exceptions when required to from CallStaticVoidMethod
...
```

A few of those warnings still remain, however they seem to come directly from the JVM and are not directly related to RocksJava; I am in contact with the OpenJDK hostpot-dev mailing list about these - http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-February/025981.html.

As a result of fixing these, I realised we were not r
Closes https://github.com/facebook/rocksdb/pull/1890

Differential Revision: D4591758

Pulled By: siying

fbshipit-source-id: 7f7fdf4
1 parent be3e556
History
File Mode Size
amalgamate.py -rwxr-xr-x 4.6 KB
build_detect_platform -rwxr-xr-x 15.8 KB
cont_integration.sh -rwxr-xr-x 3.4 KB
dependencies.sh -rw-r--r-- 2.0 KB
dependencies_4.8.1.sh -rw-r--r-- 2.1 KB
dockerbuild.sh -rwxr-xr-x 68 bytes
error_filter.py -rw-r--r-- 6.0 KB
fb_compile_mongo.sh -rwxr-xr-x 1.4 KB
fbcode_config.sh -rw-r--r-- 4.3 KB
fbcode_config4.8.1.sh -rw-r--r-- 3.4 KB
format-diff.sh -rwxr-xr-x 3.6 KB
gnu_parallel -rwxr-xr-x 238.6 KB
make_new_version.sh -rwxr-xr-x 1.2 KB
make_package.sh -rwxr-xr-x 2.6 KB
precommit_checker.py -rwxr-xr-x 5.5 KB
regression_build_test.sh -rwxr-xr-x 11.2 KB
rocksdb-lego-determinator -rwxr-xr-x 21.5 KB
run_ci_db_test.ps1 -rw-r--r-- 9.2 KB
update_dependencies.sh -rwxr-xr-x 3.7 KB
version.sh -rwxr-xr-x 687 bytes

back to top