Skip to main content

Browse the archive

https://github.com/torvalds/linux
23 October 2021, 00:29:24 UTC
Revision cc976614f59bd8e45de8ce988a6bcb5de711d994 authored by Masahiro Yamada on 30 December 2019, 13:20:06 UTC, committed by Masahiro Yamada on 03 January 2020, 15:00:48 UTC 
gen_initramfs_list.sh: fix 'bad variable name' error
 
Prior to commit 858805b336be ("kbuild: add $(BASH) to run scripts with
bash-extension"), this shell script was almost always run by bash since
bash is usually installed on the system by default.

Now, this script is run by sh, which might be a symlink to dash. On such
distributions, the following code emits an error:

  local dev=`LC_ALL=C ls -l "${location}"`

You can reproduce the build error, for example by setting
CONFIG_INITRAMFS_SOURCE="/dev".

    GEN     usr/initramfs_data.cpio.gz
  ./usr/gen_initramfs_list.sh: 131: local: 1: bad variable name
  make[1]: *** [usr/Makefile:61: usr/initramfs_data.cpio.gz] Error 2

This is because `LC_ALL=C ls -l "${location}"` contains spaces.
Surrounding it with double-quotes fixes the error.

Fixes: 858805b336be ("kbuild: add $(BASH) to run scripts with bash-extension")
Reported-by: Jory A. Pratt <anarchy@gentoo.org>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
1 parent 46cf053
History
Tip revision: cc976614f59bd8e45de8ce988a6bcb5de711d994 authored by Masahiro Yamada on 30 December 2019, 13:20:06 UTC
gen_initramfs_list.sh: fix 'bad variable name' error
Tip revision: cc97661
File Mode Size
ac97
aoa
arm
atmel
core
drivers
firewire
hda
i2c
isa
mips
oss
parisc
pci
pcmcia
ppc
sh
soc
sparc
spi
synth
usb
x86
xen
Kconfig -rw-r--r-- 2.8 KB
Makefile -rw-r--r-- 554 bytes
ac97_bus.c -rw-r--r-- 2.9 KB
last.c -rw-r--r-- 628 bytes
sound_core.c -rw-r--r-- 14.3 KB
back to top