Revision cc976614f59bd8e45de8ce988a6bcb5de711d994 authored by Masahiro Yamada on 30 December 2019, 13:20:06 UTC, committed by Masahiro Yamada on 03 January 2020, 15:00:48 UTC
Prior to commit 858805b336be ("kbuild: add $(BASH) to run scripts with bash-extension"), this shell script was almost always run by bash since bash is usually installed on the system by default. Now, this script is run by sh, which might be a symlink to dash. On such distributions, the following code emits an error: local dev=`LC_ALL=C ls -l "${location}"` You can reproduce the build error, for example by setting CONFIG_INITRAMFS_SOURCE="/dev". GEN usr/initramfs_data.cpio.gz ./usr/gen_initramfs_list.sh: 131: local: 1: bad variable name make[1]: *** [usr/Makefile:61: usr/initramfs_data.cpio.gz] Error 2 This is because `LC_ALL=C ls -l "${location}"` contains spaces. Surrounding it with double-quotes fixes the error. Fixes: 858805b336be ("kbuild: add $(BASH) to run scripts with bash-extension") Reported-by: Jory A. Pratt <anarchy@gentoo.org> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
1 parent 46cf053
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 71.5 KB |
Makefile | -rw-r--r-- | 1.2 KB |
calibrate.c | -rw-r--r-- | 8.6 KB |
do_mounts.c | -rw-r--r-- | 16.1 KB |
do_mounts.h | -rw-r--r-- | 1.1 KB |
do_mounts_initrd.c | -rw-r--r-- | 3.4 KB |
do_mounts_md.c | -rw-r--r-- | 7.9 KB |
do_mounts_rd.c | -rw-r--r-- | 8.1 KB |
init_task.c | -rw-r--r-- | 5.3 KB |
initramfs.c | -rw-r--r-- | 14.5 KB |
main.c | -rw-r--r-- | 30.4 KB |
noinitramfs.c | -rw-r--r-- | 873 bytes |
version.c | -rw-r--r-- | 1.3 KB |
Computing file changes ...