Revision cdf5b3962f33d0a05af040097173d8cc827a7d73 authored by Trent Apted on 12 March 2018, 04:02:04 UTC, committed by Blink WPT Bot on 12 March 2018, 04:10:37 UTC
This reverts commit af1c15b16f99d290799c83d34c111bce52447026.

Reason for revert: suspected for persistent failures on Win7 Tests (dbg)(1)

Unexpected Failures:
* external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services.https.html
* external/wpt/bluetooth/service/getCharacteristic/gen-blocklisted-characteristic.https.html
* external/wpt/bluetooth/service/getCharacteristics/blocklisted-characteristics.https.html
* external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html
* external/wpt/upgrade-insecure-requests/link-upgrade.sub.https.html

since

https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/66761

errors like

15:59:42.310 5904 worker/4 external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html crashed, (stderr lines):
15:59:42.311 5904   CONSOLE MESSAGE: line 255: Web Bluetooth is experimental on this platform. See https://github.com/WebBluetoothCG/web-bluetooth/blob/gh-pages/implementation-status.md
15:59:42.327 1300 [1691/5755] external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html failed unexpectedly (content_shell crashed [pid=5644])

Original change's description:
> bluetooth: Use DeviceUUID in FakeBluetooth
>
> This change refactors the Web Bluetooth test API to use the
> DeviceUUIDs helper class defined in BluetoothDevice. Additionally,
> this change finishes the implementation of SimulateGATTServicesChanged,
> and as a result, tests are updated to set the next discovery response
> before calling this interface.
>
> BUG=719826
>
> Change-Id: I0f986eb7afe6fbf7ebaa80ac4b633d46a027b80d
> Reviewed-on: https://chromium-review.googlesource.com/939984
> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541577}

TBR=cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 719826
Change-Id: I02bb7066c6f1282191f7a24e91b3d2c5614b8104
Reviewed-on: https://chromium-review.googlesource.com/958741
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542421}
1 parent 9c9d8f2
History
File Mode Size
DOMParser-parseFromString-html.html -rw-r--r-- 2.5 KB
DOMParser-parseFromString-xml-doctype.html -rw-r--r-- 1.4 KB
DOMParser-parseFromString-xml-internal-subset.html -rw-r--r-- 1.3 KB
DOMParser-parseFromString-xml.html -rw-r--r-- 2.3 KB
OWNERS -rw-r--r-- 17 bytes
XMLSerializer-serializeToString.html -rw-r--r-- 2.4 KB
createContextualFragment.html -rw-r--r-- 7.5 KB
innerhtml-01.xhtml -rw-r--r-- 1.1 KB
innerhtml-03.xhtml -rw-r--r-- 2.2 KB
innerhtml-04.html -rw-r--r-- 815 bytes
innerhtml-05.xhtml -rw-r--r-- 948 bytes
innerhtml-06.html -rw-r--r-- 493 bytes
innerhtml-07.html -rw-r--r-- 1.5 KB
innerhtml-mxss.sub.html -rw-r--r-- 1.6 KB
insert-adjacent.html -rw-r--r-- 985 bytes
insert_adjacent_html-xhtml.xhtml -rw-r--r-- 3.9 KB
insert_adjacent_html.html -rw-r--r-- 4.2 KB
insert_adjacent_html.js -rw-r--r-- 1.5 KB
outerhtml-01.html -rw-r--r-- 536 bytes
outerhtml-02.html -rw-r--r-- 1.8 KB
style_attribute_html.html -rw-r--r-- 1.9 KB
xml-serialization.xhtml -rw-r--r-- 3.9 KB
xmldomparser.html -rw-r--r-- 384 bytes

back to top