Revision cdf5b3962f33d0a05af040097173d8cc827a7d73 authored by Trent Apted on 12 March 2018, 04:02:04 UTC, committed by Blink WPT Bot on 12 March 2018, 04:10:37 UTC
This reverts commit af1c15b16f99d290799c83d34c111bce52447026.

Reason for revert: suspected for persistent failures on Win7 Tests (dbg)(1)

Unexpected Failures:
* external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services.https.html
* external/wpt/bluetooth/service/getCharacteristic/gen-blocklisted-characteristic.https.html
* external/wpt/bluetooth/service/getCharacteristics/blocklisted-characteristics.https.html
* external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html
* external/wpt/upgrade-insecure-requests/link-upgrade.sub.https.html

since

https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/66761

errors like

15:59:42.310 5904 worker/4 external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html crashed, (stderr lines):
15:59:42.311 5904   CONSOLE MESSAGE: line 255: Web Bluetooth is experimental on this platform. See https://github.com/WebBluetoothCG/web-bluetooth/blob/gh-pages/implementation-status.md
15:59:42.327 1300 [1691/5755] external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html failed unexpectedly (content_shell crashed [pid=5644])

Original change's description:
> bluetooth: Use DeviceUUID in FakeBluetooth
>
> This change refactors the Web Bluetooth test API to use the
> DeviceUUIDs helper class defined in BluetoothDevice. Additionally,
> this change finishes the implementation of SimulateGATTServicesChanged,
> and as a result, tests are updated to set the next discovery response
> before calling this interface.
>
> BUG=719826
>
> Change-Id: I0f986eb7afe6fbf7ebaa80ac4b633d46a027b80d
> Reviewed-on: https://chromium-review.googlesource.com/939984
> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541577}

TBR=cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 719826
Change-Id: I02bb7066c6f1282191f7a24e91b3d2c5614b8104
Reviewed-on: https://chromium-review.googlesource.com/958741
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542421}
1 parent 9c9d8f2
History
File Mode Size
OWNERS -rw-r--r-- 85 bytes
README.md -rw-r--r-- 1.2 KB
a-element-origin-xhtml.xhtml -rw-r--r-- 428 bytes
a-element-origin.html -rw-r--r-- 261 bytes
a-element-origin.js -rw-r--r-- 945 bytes
a-element-xhtml.xhtml -rw-r--r-- 421 bytes
a-element.html -rw-r--r-- 254 bytes
a-element.js -rw-r--r-- 1.7 KB
data-uri-fragment.html -rw-r--r-- 1.2 KB
failure.html -rw-r--r-- 1.3 KB
historical.any.js -rw-r--r-- 909 bytes
interfaces.any.js -rw-r--r-- 445 bytes
setters_tests.json -rw-r--r-- 57.3 KB
toascii.json -rw-r--r-- 4.5 KB
toascii.window.js -rw-r--r-- 1.9 KB
url-constructor.html -rw-r--r-- 4.3 KB
url-origin.html -rw-r--r-- 1.0 KB
url-setters.html -rw-r--r-- 2.0 KB
url-tojson.html -rw-r--r-- 330 bytes
urlencoded-parser.html -rw-r--r-- 2.9 KB
urlsearchparams-append.html -rw-r--r-- 1.7 KB
urlsearchparams-constructor.html -rw-r--r-- 7.8 KB
urlsearchparams-delete.html -rw-r--r-- 2.1 KB
urlsearchparams-foreach.html -rw-r--r-- 1.0 KB
urlsearchparams-get.html -rw-r--r-- 1.3 KB
urlsearchparams-getall.html -rw-r--r-- 1.6 KB
urlsearchparams-has.html -rw-r--r-- 1.2 KB
urlsearchparams-set.html -rw-r--r-- 1.2 KB
urlsearchparams-sort.html -rw-r--r-- 1.6 KB
urlsearchparams-stringifier.html -rw-r--r-- 4.0 KB
urltestdata.json -rw-r--r-- 143.5 KB

README.md

back to top