Revision cf9d8e45c08dee5b6d607c71078a225d4af26a21 authored by Yanqin Jin on 12 November 2020, 19:40:52 UTC, committed by Facebook GitHub Bot on 12 November 2020, 19:43:24 UTC
Summary:
https://github.com/facebook/rocksdb/issues/7556 enables `CompactionIterator` to perform garbage collection during compaction according
to a lower bound (user-defined) timestamp `full_history_ts_low_`.

This PR adds a data member `full_history_ts_low_` of type `std::string` to `CompactionJob`, and
`full_history_ts_low_` does not change during compaction. `CompactionJob` will pass a pointer to this
data member to the `CompactionIterator` used during compaction.

Also refactored compaction_job_test.cc to re-use some existing code, which is actually the majority of this PR.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/7657

Test Plan: make check

Reviewed By: ltamasi

Differential Revision: D24913803

Pulled By: riversand963

fbshipit-source-id: 11ad5329ddac365667152e7b3b02f84182c0ca8e
1 parent 0dc437d
History
File Mode Size
composite_env_wrapper.h -rw-r--r-- 40.9 KB
env.cc -rw-r--r-- 14.0 KB
env_basic_test.cc -rw-r--r-- 13.7 KB
env_chroot.cc -rw-r--r-- 12.6 KB
env_chroot.h -rw-r--r-- 704 bytes
env_encryption.cc -rw-r--r-- 41.0 KB
env_encryption_ctr.h -rw-r--r-- 5.0 KB
env_hdfs.cc -rw-r--r-- 19.6 KB
env_posix.cc -rw-r--r-- 16.4 KB
env_test.cc -rw-r--r-- 70.6 KB
file_system.cc -rw-r--r-- 4.4 KB
file_system_tracer.cc -rw-r--r-- 18.1 KB
file_system_tracer.h -rw-r--r-- 15.5 KB
fs_posix.cc -rw-r--r-- 33.6 KB
io_posix.cc -rw-r--r-- 45.0 KB
io_posix.h -rw-r--r-- 14.7 KB
io_posix_test.cc -rw-r--r-- 4.2 KB
mock_env.cc -rw-r--r-- 33.6 KB
mock_env.h -rw-r--r-- 1.2 KB
mock_env_test.cc -rw-r--r-- 2.7 KB

back to top