Revision d07875bd0d1517185534b5f9eef469426ba42cb9 authored by Julia Lawall on 29 December 2013, 22:47:37 UTC, committed by Roland Dreier on 12 February 2014, 19:11:09 UTC
Set the return variable to an error code as done elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Roland Dreier <roland@purestorage.com>
1 parent 38dbfb5
History

back to top