Revision d21d40605bca7bd5fc23ef03d4c1ca1f48bc2cae authored by Kuniyuki Iwashima on 01 April 2024, 21:10:04 UTC, committed by Jakub Kicinski on 03 April 2024, 02:10:57 UTC
syzkaller reported infinite recursive calls of fib6_dump_done() during netlink socket destruction. [1] From the log, syzkaller sent an AF_UNSPEC RTM_GETROUTE message, and then the response was generated. The following recvmmsg() resumed the dump for IPv6, but the first call of inet6_dump_fib() failed at kzalloc() due to the fault injection. [0] 12:01:34 executing program 3: r0 = socket$nl_route(0x10, 0x3, 0x0) sendmsg$nl_route(r0, ... snip ...) recvmmsg(r0, ... snip ...) (fail_nth: 8) Here, fib6_dump_done() was set to nlk_sk(sk)->cb.done, and the next call of inet6_dump_fib() set it to nlk_sk(sk)->cb.args[3]. syzkaller stopped receiving the response halfway through, and finally netlink_sock_destruct() called nlk_sk(sk)->cb.done(). fib6_dump_done() calls fib6_dump_end() and nlk_sk(sk)->cb.done() if it is still not NULL. fib6_dump_end() rewrites nlk_sk(sk)->cb.done() by nlk_sk(sk)->cb.args[3], but it has the same function, not NULL, calling itself recursively and hitting the stack guard page. To avoid the issue, let's set the destructor after kzalloc(). [0]: FAULT_INJECTION: forcing a failure. name failslab, interval 1, probability 0, space 0, times 0 CPU: 1 PID: 432110 Comm: syz-executor.3 Not tainted 6.8.0-12821-g537c2e91d354-dirty #11 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org 04/01/2014 Call Trace: <TASK> dump_stack_lvl (lib/dump_stack.c:117) should_fail_ex (lib/fault-inject.c:52 lib/fault-inject.c:153) should_failslab (mm/slub.c:3733) kmalloc_trace (mm/slub.c:3748 mm/slub.c:3827 mm/slub.c:3992) inet6_dump_fib (./include/linux/slab.h:628 ./include/linux/slab.h:749 net/ipv6/ip6_fib.c:662) rtnl_dump_all (net/core/rtnetlink.c:4029) netlink_dump (net/netlink/af_netlink.c:2269) netlink_recvmsg (net/netlink/af_netlink.c:1988) ____sys_recvmsg (net/socket.c:1046 net/socket.c:2801) ___sys_recvmsg (net/socket.c:2846) do_recvmmsg (net/socket.c:2943) __x64_sys_recvmmsg (net/socket.c:3041 net/socket.c:3034 net/socket.c:3034) [1]: BUG: TASK stack guard page was hit at 00000000f2fa9af1 (stack is 00000000b7912430..000000009a436beb) stack guard page: 0000 [#1] PREEMPT SMP KASAN CPU: 1 PID: 223719 Comm: kworker/1:3 Not tainted 6.8.0-12821-g537c2e91d354-dirty #11 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org 04/01/2014 Workqueue: events netlink_sock_destruct_work RIP: 0010:fib6_dump_done (net/ipv6/ip6_fib.c:570) Code: 3c 24 e8 f3 e9 51 fd e9 28 fd ff ff 66 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 f3 0f 1e fa 41 57 41 56 41 55 41 54 55 48 89 fd <53> 48 8d 5d 60 e8 b6 4d 07 fd 48 89 da 48 b8 00 00 00 00 00 fc ff RSP: 0018:ffffc9000d980000 EFLAGS: 00010293 RAX: 0000000000000000 RBX: ffffffff84405990 RCX: ffffffff844059d3 RDX: ffff8881028e0000 RSI: ffffffff84405ac2 RDI: ffff88810c02f358 RBP: ffff88810c02f358 R08: 0000000000000007 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000224 R12: 0000000000000000 R13: ffff888007c82c78 R14: ffff888007c82c68 R15: ffff888007c82c68 FS: 0000000000000000(0000) GS:ffff88811b100000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffffc9000d97fff8 CR3: 0000000102309002 CR4: 0000000000770ef0 PKRU: 55555554 Call Trace: <#DF> </#DF> <TASK> fib6_dump_done (net/ipv6/ip6_fib.c:572 (discriminator 1)) fib6_dump_done (net/ipv6/ip6_fib.c:572 (discriminator 1)) ... fib6_dump_done (net/ipv6/ip6_fib.c:572 (discriminator 1)) fib6_dump_done (net/ipv6/ip6_fib.c:572 (discriminator 1)) netlink_sock_destruct (net/netlink/af_netlink.c:401) __sk_destruct (net/core/sock.c:2177 (discriminator 2)) sk_destruct (net/core/sock.c:2224) __sk_free (net/core/sock.c:2235) sk_free (net/core/sock.c:2246) process_one_work (kernel/workqueue.c:3259) worker_thread (kernel/workqueue.c:3329 kernel/workqueue.c:3416) kthread (kernel/kthread.c:388) ret_from_fork (arch/x86/kernel/process.c:153) ret_from_fork_asm (arch/x86/entry/entry_64.S:256) Modules linked in: Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: syzkaller <syzkaller@googlegroups.com> Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com> Reviewed-by: Eric Dumazet <edumazet@google.com> Reviewed-by: David Ahern <dsahern@kernel.org> Link: https://lore.kernel.org/r/20240401211003.25274-1-kuniyu@amazon.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 5d872c9
File | Mode | Size |
---|---|---|
atomic | ||
basic | ||
clang-tools | ||
coccinelle | ||
dtc | ||
dummy-tools | ||
gcc-plugins | ||
gdb | ||
genksyms | ||
kconfig | ||
ksymoops | ||
mod | ||
package | ||
selinux | ||
tracing | ||
.gitignore | -rw-r--r-- | 214 bytes |
Kbuild.include | -rw-r--r-- | 9.9 KB |
Kconfig.include | -rw-r--r-- | 2.6 KB |
Lindent | -rwxr-xr-x | 502 bytes |
Makefile | -rw-r--r-- | 2.0 KB |
Makefile.asm-generic | -rw-r--r-- | 1.8 KB |
Makefile.btf | -rw-r--r-- | 638 bytes |
Makefile.build | -rw-r--r-- | 17.3 KB |
Makefile.clang | -rw-r--r-- | 1.6 KB |
Makefile.clean | -rw-r--r-- | 1.9 KB |
Makefile.compiler | -rw-r--r-- | 2.7 KB |
Makefile.debug | -rw-r--r-- | 1.1 KB |
Makefile.defconf | -rw-r--r-- | 1.2 KB |
Makefile.dtbinst | -rw-r--r-- | 1.0 KB |
Makefile.extrawarn | -rw-r--r-- | 7.1 KB |
Makefile.gcc-plugins | -rw-r--r-- | 2.6 KB |
Makefile.headersinst | -rw-r--r-- | 2.9 KB |
Makefile.host | -rw-r--r-- | 5.9 KB |
Makefile.kasan | -rw-r--r-- | 2.5 KB |
Makefile.kcov | -rw-r--r-- | 333 bytes |
Makefile.kcsan | -rw-r--r-- | 1004 bytes |
Makefile.kmsan | -rw-r--r-- | 208 bytes |
Makefile.lib | -rw-r--r-- | 21.2 KB |
Makefile.modfinal | -rw-r--r-- | 2.6 KB |
Makefile.modinst | -rw-r--r-- | 3.7 KB |
Makefile.modpost | -rw-r--r-- | 4.7 KB |
Makefile.package | -rw-r--r-- | 8.7 KB |
Makefile.randstruct | -rw-r--r-- | 511 bytes |
Makefile.ubsan | -rw-r--r-- | 984 bytes |
Makefile.userprogs | -rw-r--r-- | 1.6 KB |
Makefile.vdsoinst | -rw-r--r-- | 1.1 KB |
Makefile.vmlinux | -rw-r--r-- | 1.5 KB |
Makefile.vmlinux_o | -rw-r--r-- | 3.3 KB |
as-version.sh | -rwxr-xr-x | 2.0 KB |
asn1_compiler.c | -rw-r--r-- | 35.3 KB |
bloat-o-meter | -rwxr-xr-x | 3.8 KB |
bootgraph.pl | -rwxr-xr-x | 5.6 KB |
bpf_doc.py | -rwxr-xr-x | 31.7 KB |
cc-can-link.sh | -rwxr-xr-x | 166 bytes |
cc-version.sh | -rwxr-xr-x | 1.4 KB |
check-git | -rwxr-xr-x | 298 bytes |
check-sysctl-docs | -rwxr-xr-x | 3.7 KB |
check-uapi.sh | -rwxr-xr-x | 15.0 KB |
check_extable.sh | -rwxr-xr-x | 4.9 KB |
checkdeclares.pl | -rwxr-xr-x | 1.1 KB |
checkincludes.pl | -rwxr-xr-x | 1.9 KB |
checkkconfigsymbols.py | -rwxr-xr-x | 15.7 KB |
checkpatch.pl | -rwxr-xr-x | 233.2 KB |
checkstack.pl | -rwxr-xr-x | 6.0 KB |
checksyscalls.sh | -rwxr-xr-x | 7.5 KB |
checkversion.pl | -rwxr-xr-x | 2.2 KB |
cleanfile | -rwxr-xr-x | 3.5 KB |
cleanpatch | -rwxr-xr-x | 5.1 KB |
coccicheck | -rwxr-xr-x | 7.9 KB |
config | -rwxr-xr-x | 4.7 KB |
const_structs.checkpatch | -rw-r--r-- | 1.4 KB |
decode_stacktrace.sh | -rwxr-xr-x | 7.6 KB |
decodecode | -rwxr-xr-x | 4.9 KB |
depmod.sh | -rwxr-xr-x | 697 bytes |
dev-needs.sh | -rwxr-xr-x | 6.1 KB |
diffconfig | -rwxr-xr-x | 4.1 KB |
documentation-file-ref-check | -rwxr-xr-x | 5.7 KB |
export_report.pl | -rwxr-xr-x | 4.5 KB |
extract-ikconfig | -rwxr-xr-x | 1.7 KB |
extract-module-sig.pl | -rwxr-xr-x | 3.7 KB |
extract-sys-certs.pl | -rwxr-xr-x | 3.7 KB |
extract-vmlinux | -rwxr-xr-x | 1.7 KB |
extract_xc3028.pl | -rwxr-xr-x | 44.6 KB |
faddr2line | -rwxr-xr-x | 8.6 KB |
file-size.sh | -rwxr-xr-x | 86 bytes |
find-unused-docs.sh | -rwxr-xr-x | 1.3 KB |
gcc-x86_32-has-stack-protector.sh | -rwxr-xr-x | 408 bytes |
gcc-x86_64-has-stack-protector.sh | -rwxr-xr-x | 198 bytes |
gen-randstruct-seed.sh | -rwxr-xr-x | 228 bytes |
generate_initcall_order.pl | -rwxr-xr-x | 5.9 KB |
generate_rust_analyzer.py | -rwxr-xr-x | 4.8 KB |
generate_rust_target.rs | -rw-r--r-- | 5.7 KB |
get_abi.pl | -rwxr-xr-x | 25.4 KB |
get_dvb_firmware | -rwxr-xr-x | 24.5 KB |
get_feat.pl | -rwxr-xr-x | 14.6 KB |
get_maintainer.pl | -rwxr-xr-x | 67.6 KB |
gfp-translate | -rwxr-xr-x | 1.7 KB |
git.orderFile | -rw-r--r-- | 564 bytes |
head-object-list.txt | -rw-r--r-- | 1.4 KB |
headerdep.pl | -rwxr-xr-x | 3.5 KB |
headers_install.sh | -rwxr-xr-x | 2.8 KB |
insert-sys-cert.c | -rw-r--r-- | 8.9 KB |
install.sh | -rwxr-xr-x | 986 bytes |
jobserver-exec | -rwxr-xr-x | 2.6 KB |
kallsyms.c | -rw-r--r-- | 18.9 KB |
kernel-doc | -rwxr-xr-x | 77.1 KB |
ld-version.sh | -rwxr-xr-x | 1.7 KB |
leaking_addresses.pl | -rwxr-xr-x | 14.6 KB |
link-vmlinux.sh | -rwxr-xr-x | 7.6 KB |
makelst | -rwxr-xr-x | 808 bytes |
markup_oops.pl | -rwxr-xr-x | 7.9 KB |
min-tool-version.sh | -rwxr-xr-x | 630 bytes |
misc-check | -rwxr-xr-x | 509 bytes |
mkcompile_h | -rwxr-xr-x | 642 bytes |
mksysmap | -rwxr-xr-x | 2.6 KB |
mkuboot.sh | -rwxr-xr-x | 414 bytes |
module.lds.S | -rw-r--r-- | 1.4 KB |
modules-check.sh | -rwxr-xr-x | 443 bytes |
nsdeps | -rw-r--r-- | 1.6 KB |
objdiff | -rwxr-xr-x | 2.8 KB |
objdump-func | -rwxr-xr-x | 848 bytes |
orc_hash.sh | -rw-r--r-- | 316 bytes |
pahole-version.sh | -rwxr-xr-x | 269 bytes |
parse-maintainers.pl | -rwxr-xr-x | 4.5 KB |
patch-kernel | -rwxr-xr-x | 9.9 KB |
profile2linkerlist.pl | -rwxr-xr-x | 414 bytes |
prune-kernel | -rwxr-xr-x | 912 bytes |
recordmcount.c | -rw-r--r-- | 17.5 KB |
recordmcount.h | -rw-r--r-- | 19.4 KB |
recordmcount.pl | -rwxr-xr-x | 17.3 KB |
relocs_check.sh | -rwxr-xr-x | 717 bytes |
remove-stale-files | -rwxr-xr-x | 1.3 KB |
rust_is_available.sh | -rwxr-xr-x | 9.2 KB |
rust_is_available_bindgen_libclang.h | -rw-r--r-- | 91 bytes |
rust_is_available_test.py | -rwxr-xr-x | 17.7 KB |
rustdoc_test_builder.rs | -rw-r--r-- | 3.2 KB |
rustdoc_test_gen.rs | -rw-r--r-- | 9.5 KB |
setlocalversion | -rwxr-xr-x | 4.6 KB |
show_delta | -rwxr-xr-x | 3.0 KB |
sign-file.c | -rw-r--r-- | 9.9 KB |
sorttable.c | -rw-r--r-- | 7.7 KB |
sorttable.h | -rw-r--r-- | 12.9 KB |
spdxcheck-test.sh | -rw-r--r-- | 284 bytes |
spdxcheck.py | -rwxr-xr-x | 15.2 KB |
spdxexclude | -rw-r--r-- | 417 bytes |
spelling.txt | -rw-r--r-- | 34.2 KB |
sphinx-pre-install | -rwxr-xr-x | 25.1 KB |
split-man.pl | -rwxr-xr-x | 604 bytes |
stackdelta | -rwxr-xr-x | 1.8 KB |
stackusage | -rwxr-xr-x | 794 bytes |
subarch.include | -rw-r--r-- | 647 bytes |
syscallhdr.sh | -rwxr-xr-x | 1.9 KB |
syscallnr.sh | -rwxr-xr-x | 1.5 KB |
syscalltbl.sh | -rwxr-xr-x | 1.5 KB |
tags.sh | -rwxr-xr-x | 10.7 KB |
test_fortify.sh | -rw-r--r-- | 2.2 KB |
tools-support-relr.sh | -rwxr-xr-x | 726 bytes |
unifdef.c | -rw-r--r-- | 34.8 KB |
ver_linux | -rwxr-xr-x | 2.6 KB |
xen-hypercalls.sh | -rwxr-xr-x | 386 bytes |
xz_wrap.sh | -rwxr-xr-x | 516 bytes |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...