Revision d280289e799dcdf5913e8935bffe136d7594e26d authored by Jean Delvare on 01 September 2008, 15:44:05 UTC, committed by Jaroslav Kysela on 09 September 2008, 07:11:07 UTC
The error handling in neo1973_init is incorrect: * If platform_device_add fails, we go on with the rest of the initialization instead of bailing out. Things will break when the module is removed (platform_device_unregister called on a device that wasn't registered.) * If i2c_add_driver fails, we return an error so the module will not load, but we don't unregister neo1973_snd_device, so we are leaking resources. Add the missing error handling. Signed-off-by: Jean Delvare <khali@linux-fr.org> Cc: Tim Niemeyer <reddog@mastersword.de> Cc: Graeme Gregory <graeme@openmoko.org> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
1 parent dfdf34b
| File | Mode | Size |
|---|---|---|
| 9p | ||
| adfs | ||
| affs | ||
| afs | ||
| autofs | ||
| autofs4 | ||
| befs | ||
| bfs | ||
| cifs | ||
| coda | ||
| configfs | ||
| cramfs | ||
| debugfs | ||
| devpts | ||
| dlm | ||
| ecryptfs | ||
| efs | ||
| exportfs | ||
| ext2 | ||
| ext3 | ||
| ext4 | ||
| fat | ||
| freevxfs | ||
| fuse | ||
| gfs2 | ||
| hfs | ||
| hfsplus | ||
| hostfs | ||
| hpfs | ||
| hppfs | ||
| hugetlbfs | ||
| isofs | ||
| jbd | ||
| jbd2 | ||
| jffs2 | ||
| jfs | ||
| lockd | ||
| minix | ||
| msdos | ||
| ncpfs | ||
| nfs | ||
| nfs_common | ||
| nfsd | ||
| nls | ||
| ntfs | ||
| ocfs2 | ||
| omfs | ||
| openpromfs | ||
| partitions | ||
| proc | ||
| qnx4 | ||
| ramfs | ||
| reiserfs | ||
| romfs | ||
| smbfs | ||
| sysfs | ||
| sysv | ||
| ubifs | ||
| udf | ||
| ufs | ||
| vfat | ||
| xfs | ||
| Kconfig | -rw-r--r-- | 73.8 KB |
| Kconfig.binfmt | -rw-r--r-- | 5.4 KB |
| Makefile | -rw-r--r-- | 3.9 KB |
| aio.c | -rw-r--r-- | 45.9 KB |
| anon_inodes.c | -rw-r--r-- | 4.9 KB |
| attr.c | -rw-r--r-- | 4.8 KB |
| bad_inode.c | -rw-r--r-- | 8.0 KB |
| binfmt_aout.c | -rw-r--r-- | 14.7 KB |
| binfmt_elf.c | -rw-r--r-- | 53.7 KB |
| binfmt_elf_fdpic.c | -rw-r--r-- | 47.4 KB |
| binfmt_em86.c | -rw-r--r-- | 2.8 KB |
| binfmt_flat.c | -rw-r--r-- | 26.6 KB |
| binfmt_misc.c | -rw-r--r-- | 15.1 KB |
| binfmt_script.c | -rw-r--r-- | 2.7 KB |
| binfmt_som.c | -rw-r--r-- | 7.5 KB |
| bio-integrity.c | -rw-r--r-- | 19.4 KB |
| bio.c | -rw-r--r-- | 32.3 KB |
| block_dev.c | -rw-r--r-- | 30.6 KB |
| buffer.c | -rw-r--r-- | 87.8 KB |
| char_dev.c | -rw-r--r-- | 13.2 KB |
| compat.c | -rw-r--r-- | 53.3 KB |
| compat_binfmt_elf.c | -rw-r--r-- | 3.4 KB |
| compat_ioctl.c | -rw-r--r-- | 81.0 KB |
| dcache.c | -rw-r--r-- | 60.0 KB |
| dcookies.c | -rw-r--r-- | 6.3 KB |
| direct-io.c | -rw-r--r-- | 34.0 KB |
| dnotify.c | -rw-r--r-- | 4.6 KB |
| dquot.c | -rw-r--r-- | 62.2 KB |
| drop_caches.c | -rw-r--r-- | 1.6 KB |
| eventfd.c | -rw-r--r-- | 5.3 KB |
| eventpoll.c | -rw-r--r-- | 35.9 KB |
| exec.c | -rw-r--r-- | 42.1 KB |
| fcntl.c | -rw-r--r-- | 13.4 KB |
| fifo.c | -rw-r--r-- | 3.2 KB |
| file.c | -rw-r--r-- | 12.1 KB |
| file_table.c | -rw-r--r-- | 9.8 KB |
| filesystems.c | -rw-r--r-- | 5.5 KB |
| fs-writeback.c | -rw-r--r-- | 22.4 KB |
| generic_acl.c | -rw-r--r-- | 4.2 KB |
| inode.c | -rw-r--r-- | 37.7 KB |
| inotify.c | -rw-r--r-- | 20.2 KB |
| inotify_user.c | -rw-r--r-- | 18.8 KB |
| internal.h | -rw-r--r-- | 1.4 KB |
| ioctl.c | -rw-r--r-- | 4.5 KB |
| ioprio.c | -rw-r--r-- | 5.0 KB |
| libfs.c | -rw-r--r-- | 21.1 KB |
| locks.c | -rw-r--r-- | 57.2 KB |
| mbcache.c | -rw-r--r-- | 18.3 KB |
| mpage.c | -rw-r--r-- | 19.8 KB |
| namei.c | -rw-r--r-- | 69.8 KB |
| namespace.c | -rw-r--r-- | 58.4 KB |
| nfsctl.c | -rw-r--r-- | 2.4 KB |
| no-block.c | -rw-r--r-- | 663 bytes |
| open.c | -rw-r--r-- | 26.4 KB |
| pipe.c | -rw-r--r-- | 24.2 KB |
| pnode.c | -rw-r--r-- | 8.9 KB |
| pnode.h | -rw-r--r-- | 1.1 KB |
| posix_acl.c | -rw-r--r-- | 8.5 KB |
| quota.c | -rw-r--r-- | 12.2 KB |
| quota_v1.c | -rw-r--r-- | 5.9 KB |
| quota_v2.c | -rw-r--r-- | 20.2 KB |
| read_write.c | -rw-r--r-- | 17.4 KB |
| read_write.h | -rw-r--r-- | 542 bytes |
| readdir.c | -rw-r--r-- | 6.9 KB |
| select.c | -rw-r--r-- | 20.8 KB |
| seq_file.c | -rw-r--r-- | 12.6 KB |
| signalfd.c | -rw-r--r-- | 7.1 KB |
| splice.c | -rw-r--r-- | 38.9 KB |
| stack.c | -rw-r--r-- | 1.1 KB |
| stat.c | -rw-r--r-- | 10.6 KB |
| super.c | -rw-r--r-- | 22.8 KB |
| sync.c | -rw-r--r-- | 7.1 KB |
| timerfd.c | -rw-r--r-- | 6.8 KB |
| utimes.c | -rw-r--r-- | 5.6 KB |
| xattr.c | -rw-r--r-- | 15.0 KB |
| xattr_acl.c | -rw-r--r-- | 2.3 KB |
Computing file changes ...
