Revision d378834840907326ac9d448056d957d13cc3718f authored by Ingo Molnar on 03 July 2006, 07:25:14 UTC, committed by Linus Torvalds on 03 July 2006, 22:27:08 UTC
ieee1394 reuses the skb infrastructure of the networking code, and uses two skb-head queues: ->pending_packet_queue and hpsbpkt_queue. The latter is used in the usual fashion: processed from a kernel thread. The other one, ->pending_packet_queue is also processed from hardirq context (f.e. in hpsb_bus_reset()), which is not what the networking code usually does (which completes from softirq or process context). This locking assymetry can be totally correct if done carefully, but it can also be dangerous if networking helper functions are reused, which could assume traditional networking use. It would probably be more robust to push this completion into a workqueue - but technically the code can be 100% correct, and lockdep has to be taught about it. The solution is to split the ->pending_packet_queue skb-head->lock class from the networking lock-class by using a private lock-validator key. Has no effect on non-lockdep kernels. Signed-off-by: Ingo Molnar <mingo@elte.hu> Cc: Stefan Richter <stefanr@s5r6.in-berlin.de> Cc: Jody McIntyre <scjody@modernduck.com> Cc: Ben Collins <bcollins@debian.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
1 parent c636618
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 1.1 KB |
Kconfig.iosched | -rw-r--r-- | 1.9 KB |
Makefile | -rw-r--r-- | 333 bytes |
as-iosched.c | -rw-r--r-- | 45.4 KB |
blktrace.c | -rw-r--r-- | 11.8 KB |
cfq-iosched.c | -rw-r--r-- | 57.9 KB |
deadline-iosched.c | -rw-r--r-- | 18.6 KB |
elevator.c | -rw-r--r-- | 20.3 KB |
genhd.c | -rw-r--r-- | 16.6 KB |
ioctl.c | -rw-r--r-- | 7.4 KB |
ll_rw_blk.c | -rw-r--r-- | 99.3 KB |
noop-iosched.c | -rw-r--r-- | 2.5 KB |
scsi_ioctl.c | -rw-r--r-- | 16.4 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...