Revision d38a2b7a9c939e6d7329ab92b96559ccebf7b135 authored by Muchun Song on 24 July 2020, 04:15:27 UTC, committed by Linus Torvalds on 24 July 2020, 19:42:41 UTC
If the kmem_cache refcount is greater than one, we should not mark the root kmem_cache as dying. If we mark the root kmem_cache dying incorrectly, the non-root kmem_cache can never be destroyed. It resulted in memory leak when memcg was destroyed. We can use the following steps to reproduce. 1) Use kmem_cache_create() to create a new kmem_cache named A. 2) Coincidentally, the kmem_cache A is an alias for kmem_cache B, so the refcount of B is just increased. 3) Use kmem_cache_destroy() to destroy the kmem_cache A, just decrease the B's refcount but mark the B as dying. 4) Create a new memory cgroup and alloc memory from the kmem_cache B. It leads to create a non-root kmem_cache for allocating memory. 5) When destroy the memory cgroup created in the step 4), the non-root kmem_cache can never be destroyed. If we repeat steps 4) and 5), this will cause a lot of memory leak. So only when refcount reach zero, we mark the root kmem_cache as dying. Fixes: 92ee383f6daa ("mm: fix race between kmem_cache destroy, create and deactivate") Signed-off-by: Muchun Song <songmuchun@bytedance.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Reviewed-by: Shakeel Butt <shakeelb@google.com> Acked-by: Roman Gushchin <guro@fb.com> Cc: Vlastimil Babka <vbabka@suse.cz> Cc: Christoph Lameter <cl@linux.com> Cc: Pekka Enberg <penberg@kernel.org> Cc: David Rientjes <rientjes@google.com> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com> Cc: Shakeel Butt <shakeelb@google.com> Cc: <stable@vger.kernel.org> Link: http://lkml.kernel.org/r/20200716165103.83462-1-songmuchun@bytedance.com Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 8d22a93
File | Mode | Size |
---|---|---|
asymmetric_keys | ||
async_tx | ||
842.c | -rw-r--r-- | 3.7 KB |
Kconfig | -rw-r--r-- | 54.8 KB |
Makefile | -rw-r--r-- | 7.4 KB |
acompress.c | -rw-r--r-- | 4.5 KB |
adiantum.c | -rw-r--r-- | 19.6 KB |
aead.c | -rw-r--r-- | 7.2 KB |
aegis.h | -rw-r--r-- | 1.8 KB |
aegis128-core.c | -rw-r--r-- | 13.1 KB |
aegis128-neon-inner.c | -rw-r--r-- | 6.3 KB |
aegis128-neon.c | -rw-r--r-- | 1.9 KB |
aes_generic.c | -rw-r--r-- | 57.6 KB |
aes_ti.c | -rw-r--r-- | 2.0 KB |
af_alg.c | -rw-r--r-- | 25.6 KB |
ahash.c | -rw-r--r-- | 16.2 KB |
akcipher.c | -rw-r--r-- | 4.0 KB |
algapi.c | -rw-r--r-- | 28.6 KB |
algboss.c | -rw-r--r-- | 5.9 KB |
algif_aead.c | -rw-r--r-- | 15.8 KB |
algif_hash.c | -rw-r--r-- | 9.6 KB |
algif_rng.c | -rw-r--r-- | 5.2 KB |
algif_skcipher.c | -rw-r--r-- | 9.8 KB |
ansi_cprng.c | -rw-r--r-- | 10.7 KB |
anubis.c | -rw-r--r-- | 27.8 KB |
api.c | -rw-r--r-- | 13.6 KB |
arc4.c | -rw-r--r-- | 1.8 KB |
authenc.c | -rw-r--r-- | 13.3 KB |
authencesn.c | -rw-r--r-- | 14.4 KB |
blake2b_generic.c | -rw-r--r-- | 9.3 KB |
blake2s_generic.c | -rw-r--r-- | 5.0 KB |
blowfish_common.c | -rw-r--r-- | 15.5 KB |
blowfish_generic.c | -rw-r--r-- | 3.2 KB |
camellia_generic.c | -rw-r--r-- | 34.2 KB |
cast5_generic.c | -rw-r--r-- | 20.5 KB |
cast6_generic.c | -rw-r--r-- | 9.1 KB |
cast_common.c | -rw-r--r-- | 12.9 KB |
cbc.c | -rw-r--r-- | 2.2 KB |
ccm.c | -rw-r--r-- | 23.8 KB |
cfb.c | -rw-r--r-- | 6.1 KB |
chacha20poly1305.c | -rw-r--r-- | 17.9 KB |
chacha_generic.c | -rw-r--r-- | 3.9 KB |
cipher.c | -rw-r--r-- | 2.5 KB |
cmac.c | -rw-r--r-- | 7.5 KB |
compress.c | -rw-r--r-- | 921 bytes |
crc32_generic.c | -rw-r--r-- | 3.7 KB |
crc32c_generic.c | -rw-r--r-- | 4.1 KB |
crct10dif_common.c | -rw-r--r-- | 3.6 KB |
crct10dif_generic.c | -rw-r--r-- | 3.1 KB |
cryptd.c | -rw-r--r-- | 28.4 KB |
crypto_engine.c | -rw-r--r-- | 15.4 KB |
crypto_null.c | -rw-r--r-- | 5.3 KB |
crypto_user_base.c | -rw-r--r-- | 12.0 KB |
crypto_user_stat.c | -rw-r--r-- | 9.6 KB |
ctr.c | -rw-r--r-- | 9.8 KB |
cts.c | -rw-r--r-- | 11.7 KB |
curve25519-generic.c | -rw-r--r-- | 2.2 KB |
deflate.c | -rw-r--r-- | 7.7 KB |
des_generic.c | -rw-r--r-- | 3.3 KB |
dh.c | -rw-r--r-- | 4.7 KB |
dh_helper.c | -rw-r--r-- | 3.4 KB |
drbg.c | -rw-r--r-- | 59.6 KB |
ecb.c | -rw-r--r-- | 2.4 KB |
ecc.c | -rw-r--r-- | 38.3 KB |
ecc.h | -rw-r--r-- | 7.6 KB |
ecc_curve_defs.h | -rw-r--r-- | 1.9 KB |
ecdh.c | -rw-r--r-- | 3.9 KB |
ecdh_helper.c | -rw-r--r-- | 2.1 KB |
echainiv.c | -rw-r--r-- | 4.1 KB |
ecrdsa.c | -rw-r--r-- | 8.3 KB |
ecrdsa_defs.h | -rw-r--r-- | 7.2 KB |
ecrdsa_params.asn1 | -rw-r--r-- | 142 bytes |
ecrdsa_pub_key.asn1 | -rw-r--r-- | 57 bytes |
essiv.c | -rw-r--r-- | 17.7 KB |
fcrypt.c | -rw-r--r-- | 18.0 KB |
fips.c | -rw-r--r-- | 1.7 KB |
gcm.c | -rw-r--r-- | 30.7 KB |
geniv.c | -rw-r--r-- | 4.1 KB |
gf128mul.c | -rw-r--r-- | 12.4 KB |
ghash-generic.c | -rw-r--r-- | 4.8 KB |
hash_info.c | -rw-r--r-- | 1.9 KB |
hmac.c | -rw-r--r-- | 6.4 KB |
internal.h | -rw-r--r-- | 3.3 KB |
jitterentropy-kcapi.c | -rw-r--r-- | 6.2 KB |
jitterentropy.c | -rw-r--r-- | 25.2 KB |
jitterentropy.h | -rw-r--r-- | 643 bytes |
keywrap.c | -rw-r--r-- | 9.5 KB |
khazad.c | -rw-r--r-- | 51.8 KB |
kpp.c | -rw-r--r-- | 2.7 KB |
lrw.c | -rw-r--r-- | 10.5 KB |
lz4.c | -rw-r--r-- | 3.3 KB |
lz4hc.c | -rw-r--r-- | 3.4 KB |
lzo-rle.c | -rw-r--r-- | 3.4 KB |
lzo.c | -rw-r--r-- | 3.3 KB |
md4.c | -rw-r--r-- | 5.9 KB |
md5.c | -rw-r--r-- | 7.4 KB |
memneq.c | -rw-r--r-- | 6.1 KB |
michael_mic.c | -rw-r--r-- | 3.5 KB |
nhpoly1305.c | -rw-r--r-- | 7.8 KB |
ofb.c | -rw-r--r-- | 2.4 KB |
pcbc.c | -rw-r--r-- | 4.6 KB |
pcrypt.c | -rw-r--r-- | 9.4 KB |
poly1305_generic.c | -rw-r--r-- | 3.7 KB |
proc.c | -rw-r--r-- | 2.5 KB |
ripemd.h | -rw-r--r-- | 1013 bytes |
rmd128.c | -rw-r--r-- | 10.0 KB |
rmd160.c | -rw-r--r-- | 12.4 KB |
rmd256.c | -rw-r--r-- | 10.3 KB |
rmd320.c | -rw-r--r-- | 12.8 KB |
rng.c | -rw-r--r-- | 4.8 KB |
rsa-pkcs1pad.c | -rw-r--r-- | 17.4 KB |
rsa.c | -rw-r--r-- | 5.3 KB |
rsa_helper.c | -rw-r--r-- | 4.0 KB |
rsaprivkey.asn1 | -rw-r--r-- | 316 bytes |
rsapubkey.asn1 | -rw-r--r-- | 82 bytes |
salsa20_generic.c | -rw-r--r-- | 6.0 KB |
scatterwalk.c | -rw-r--r-- | 2.0 KB |
scompress.c | -rw-r--r-- | 6.8 KB |
seed.c | -rw-r--r-- | 17.2 KB |
seqiv.c | -rw-r--r-- | 4.8 KB |
serpent_generic.c | -rw-r--r-- | 21.5 KB |
sha1_generic.c | -rw-r--r-- | 2.3 KB |
sha256_generic.c | -rw-r--r-- | 3.3 KB |
sha3_generic.c | -rw-r--r-- | 8.0 KB |
sha512_generic.c | -rw-r--r-- | 7.8 KB |
shash.c | -rw-r--r-- | 15.1 KB |
simd.c | -rw-r--r-- | 13.4 KB |
skcipher.c | -rw-r--r-- | 25.0 KB |
sm3_generic.c | -rw-r--r-- | 4.1 KB |
sm4_generic.c | -rw-r--r-- | 6.2 KB |
streebog_generic.c | -rw-r--r-- | 57.6 KB |
tcrypt.c | -rw-r--r-- | 78.7 KB |
tcrypt.h | -rw-r--r-- | 4.2 KB |
tea.c | -rw-r--r-- | 6.5 KB |
testmgr.c | -rw-r--r-- | 144.9 KB |
testmgr.h | -rw-r--r-- | 1.2 MB |
tgr192.c | -rw-r--r-- | 30.3 KB |
twofish_common.c | -rw-r--r-- | 37.1 KB |
twofish_generic.c | -rw-r--r-- | 5.6 KB |
vmac.c | -rw-r--r-- | 18.8 KB |
wp512.c | -rw-r--r-- | 59.8 KB |
xcbc.c | -rw-r--r-- | 6.6 KB |
xor.c | -rw-r--r-- | 3.4 KB |
xts.c | -rw-r--r-- | 11.6 KB |
xxhash_generic.c | -rw-r--r-- | 2.4 KB |
zstd.c | -rw-r--r-- | 5.0 KB |
Computing file changes ...