Revision d6e199016cf36ce3c790202db79e55b561789e24 authored by Maysam Yabandeh on 12 December 2019, 21:48:50 UTC, committed by myabandeh on 12 December 2019, 21:54:29 UTC
Summary: This change fixes a source issue that caused compile time error which breaks build for many fbcode services in that setup. The size() member function of channel is a const member, so member variables accessed within it are implicitly const as well. This caused error when clang fails to resolve to a constructor that takes std::mutex because the suitable constructor got rejected due to loss of constness for its argument. The fix is to add mutable modifier to the lock_ member of channel. Pull Request resolved: https://github.com/facebook/rocksdb/pull/6161 Differential Revision: D18967685 Pulled By: maysamyabandeh fbshipit-source-id: 698b6a5153c3c92eeacb842c467aa28cc350d432
1 parent 92453f2
| File | Mode | Size |
|---|---|---|
| win | ||
| README | -rw-r--r-- | 405 bytes |
| jemalloc_helper.h | -rw-r--r-- | 3.4 KB |
| likely.h | -rw-r--r-- | 690 bytes |
| malloc.h | -rw-r--r-- | 656 bytes |
| port.h | -rw-r--r-- | 834 bytes |
| port_dirent.h | -rw-r--r-- | 1.0 KB |
| port_example.h | -rw-r--r-- | 3.5 KB |
| port_posix.cc | -rw-r--r-- | 6.1 KB |
| port_posix.h | -rw-r--r-- | 5.8 KB |
| stack_trace.cc | -rw-r--r-- | 3.5 KB |
| stack_trace.h | -rw-r--r-- | 648 bytes |
| sys_time.h | -rw-r--r-- | 1.1 KB |
| util_logger.h | -rw-r--r-- | 823 bytes |
| xpress.h | -rw-r--r-- | 687 bytes |
Computing file changes ...
