Revision d6e199016cf36ce3c790202db79e55b561789e24 authored by Maysam Yabandeh on 12 December 2019, 21:48:50 UTC, committed by myabandeh on 12 December 2019, 21:54:29 UTC
Summary: This change fixes a source issue that caused compile time error which breaks build for many fbcode services in that setup. The size() member function of channel is a const member, so member variables accessed within it are implicitly const as well. This caused error when clang fails to resolve to a constructor that takes std::mutex because the suitable constructor got rejected due to loss of constness for its argument. The fix is to add mutable modifier to the lock_ member of channel. Pull Request resolved: https://github.com/facebook/rocksdb/pull/6161 Differential Revision: D18967685 Pulled By: maysamyabandeh fbshipit-source-id: 698b6a5153c3c92eeacb842c467aa28cc350d432
1 parent 92453f2
| File | Mode | Size |
|---|---|---|
| adaptive | ||
| block_based | ||
| cuckoo | ||
| plain | ||
| block_fetcher.cc | -rw-r--r-- | 9.7 KB |
| block_fetcher.h | -rw-r--r-- | 4.4 KB |
| cleanable_test.cc | -rw-r--r-- | 6.4 KB |
| format.cc | -rw-r--r-- | 16.6 KB |
| format.h | -rw-r--r-- | 12.6 KB |
| get_context.cc | -rw-r--r-- | 13.1 KB |
| get_context.h | -rw-r--r-- | 7.5 KB |
| internal_iterator.h | -rw-r--r-- | 6.6 KB |
| iter_heap.h | -rw-r--r-- | 1.2 KB |
| iterator.cc | -rw-r--r-- | 6.7 KB |
| iterator_wrapper.h | -rw-r--r-- | 3.6 KB |
| merger_test.cc | -rw-r--r-- | 4.5 KB |
| merging_iterator.cc | -rw-r--r-- | 13.6 KB |
| merging_iterator.h | -rw-r--r-- | 2.1 KB |
| meta_blocks.cc | -rw-r--r-- | 19.8 KB |
| meta_blocks.h | -rw-r--r-- | 6.2 KB |
| mock_table.cc | -rw-r--r-- | 4.5 KB |
| mock_table.h | -rw-r--r-- | 6.1 KB |
| multiget_context.h | -rw-r--r-- | 8.3 KB |
| persistent_cache_helper.cc | -rw-r--r-- | 4.2 KB |
| persistent_cache_helper.h | -rw-r--r-- | 1.5 KB |
| persistent_cache_options.h | -rw-r--r-- | 1.0 KB |
| scoped_arena_iterator.h | -rw-r--r-- | 1.6 KB |
| sst_file_reader.cc | -rw-r--r-- | 3.0 KB |
| sst_file_reader_test.cc | -rw-r--r-- | 5.0 KB |
| sst_file_writer.cc | -rw-r--r-- | 10.9 KB |
| sst_file_writer_collectors.h | -rw-r--r-- | 3.1 KB |
| table_builder.h | -rw-r--r-- | 6.6 KB |
| table_properties.cc | -rw-r--r-- | 10.4 KB |
| table_properties_internal.h | -rw-r--r-- | 1.0 KB |
| table_reader.h | -rw-r--r-- | 5.8 KB |
| table_reader_bench.cc | -rw-r--r-- | 12.6 KB |
| table_reader_caller.h | -rw-r--r-- | 1.5 KB |
| table_test.cc | -rw-r--r-- | 159.2 KB |
| two_level_iterator.cc | -rw-r--r-- | 6.3 KB |
| two_level_iterator.h | -rw-r--r-- | 1.7 KB |
Computing file changes ...
