Revision da9846ae15186d491d6e21ebbb5051e1d3c7f652 authored by Tejun Heo on 29 January 2014, 17:04:03 UTC, committed by Greg Kroah-Hartman on 05 February 2014, 19:44:04 UTC
kernfs_deactivate() forgot to check whether KERNFS_LOCKDEP is set before performing lockdep annotations and ends up feeding uninitialized lockdep_map to lockdep triggering warning like the following on USB stick hotunplug. usb 1-2: USB disconnect, device number 2 INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. CPU: 1 PID: 62 Comm: khubd Not tainted 3.13.0-work+ #82 Hardware name: empty empty/S3992, BIOS 080011 10/26/2007 ffff880065ca7f60 ffff88013a4ffa08 ffffffff81cfb6bd 0000000000000002 ffff88013a4ffac8 ffffffff810f8530 ffff88013a4fc710 0000000000000002 ffff880100000000 ffffffff82a3db50 0000000000000001 ffff88013a4fc710 Call Trace: [<ffffffff81cfb6bd>] dump_stack+0x4e/0x7a [<ffffffff810f8530>] __lock_acquire+0x1910/0x1e70 [<ffffffff810f931a>] lock_acquire+0x9a/0x1d0 [<ffffffff8127c75e>] kernfs_deactivate+0xee/0x130 [<ffffffff8127d4c8>] kernfs_addrm_finish+0x38/0x60 [<ffffffff8127d701>] kernfs_remove_by_name_ns+0x51/0xa0 [<ffffffff8127b4f1>] remove_files.isra.1+0x41/0x80 [<ffffffff8127b7e7>] sysfs_remove_group+0x47/0xa0 [<ffffffff8127b873>] sysfs_remove_groups+0x33/0x50 [<ffffffff8177d66d>] device_remove_attrs+0x4d/0x80 [<ffffffff8177e25e>] device_del+0x12e/0x1d0 [<ffffffff819722c2>] usb_disconnect+0x122/0x1a0 [<ffffffff819749b5>] hub_thread+0x3c5/0x1290 [<ffffffff810c6a6d>] kthread+0xed/0x110 [<ffffffff81d0a56c>] ret_from_fork+0x7c/0xb0 Fix it by making kernfs_deactivate() perform lockdep annotations only if KERNFS_LOCKDEP is set. Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: Fabio Estevam <festevam@gmail.com> Reported-by: Alan Stern <stern@rowland.harvard.edu> Reported-by: Jiri Kosina <jkosina@suse.cz> Reported-by: Dave Jones <davej@redhat.com> Tested-by: Fabio Estevam <fabio.estevam@freescale.com> Tested-by: Jiri Kosina <jkosina@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 38dbfb5
| File | Mode | Size |
|---|---|---|
| ABI | ||
| DocBook | ||
| EDID | ||
| PCI | ||
| RCU | ||
| accounting | ||
| acpi | ||
| aoe | ||
| arm | ||
| arm64 | ||
| auxdisplay | ||
| backlight | ||
| blackfin | ||
| block | ||
| blockdev | ||
| bus-devices | ||
| cdrom | ||
| cgroups | ||
| connector | ||
| console | ||
| cpu-freq | ||
| cpuidle | ||
| cris | ||
| crypto | ||
| development-process | ||
| device-mapper | ||
| devicetree | ||
| driver-model | ||
| dvb | ||
| early-userspace | ||
| extcon | ||
| fault-injection | ||
| fb | ||
| filesystems | ||
| firmware_class | ||
| fmc | ||
| frv | ||
| gpio | ||
| hid | ||
| hwmon | ||
| i2c | ||
| i2o | ||
| ia64 | ||
| ide | ||
| infiniband | ||
| input | ||
| ioctl | ||
| isdn | ||
| ja_JP | ||
| kbuild | ||
| kdump | ||
| ko_KR | ||
| laptops | ||
| leds | ||
| m68k | ||
| make | ||
| memory-devices | ||
| metag | ||
| mic | ||
| mips | ||
| misc-devices | ||
| mmc | ||
| mn10300 | ||
| mtd | ||
| namespaces | ||
| netlabel | ||
| networking | ||
| nfc | ||
| parisc | ||
| pcmcia | ||
| power | ||
| powerpc | ||
| pps | ||
| prctl | ||
| pti | ||
| ptp | ||
| rapidio | ||
| s390 | ||
| scheduler | ||
| scsi | ||
| security | ||
| serial | ||
| sh | ||
| sound | ||
| spi | ||
| sysctl | ||
| target | ||
| thermal | ||
| timers | ||
| tpm | ||
| trace | ||
| usb | ||
| vDSO | ||
| video4linux | ||
| virtual | ||
| vm | ||
| w1 | ||
| watchdog | ||
| wimax | ||
| x86 | ||
| xtensa | ||
| zh_CN | ||
| .gitignore | -rw-r--r-- | 107 bytes |
| 00-INDEX | -rw-r--r-- | 16.6 KB |
| BUG-HUNTING | -rw-r--r-- | 8.1 KB |
| Changes | -rw-r--r-- | 11.5 KB |
| CodingStyle | -rw-r--r-- | 30.8 KB |
| DMA-API-HOWTO.txt | -rw-r--r-- | 31.6 KB |
| DMA-API.txt | -rw-r--r-- | 27.5 KB |
| DMA-ISA-LPC.txt | -rw-r--r-- | 5.2 KB |
| DMA-attributes.txt | -rw-r--r-- | 4.5 KB |
| HOWTO | -rw-r--r-- | 27.2 KB |
| IPMI.txt | -rw-r--r-- | 26.1 KB |
| IRQ-affinity.txt | -rw-r--r-- | 2.5 KB |
| IRQ-domain.txt | -rw-r--r-- | 6.9 KB |
| IRQ.txt | -rw-r--r-- | 962 bytes |
| Intel-IOMMU.txt | -rw-r--r-- | 3.8 KB |
| Makefile | -rw-r--r-- | 174 bytes |
| ManagementStyle | -rw-r--r-- | 12.9 KB |
| SAK.txt | -rw-r--r-- | 2.8 KB |
| SM501.txt | -rw-r--r-- | 2.8 KB |
| SecurityBugs | -rw-r--r-- | 1.8 KB |
| SubmitChecklist | -rw-r--r-- | 4.4 KB |
| SubmittingDrivers | -rw-r--r-- | 6.3 KB |
| SubmittingPatches | -rw-r--r-- | 29.3 KB |
| VGA-softcursor.txt | -rw-r--r-- | 2.0 KB |
| applying-patches.txt | -rw-r--r-- | 19.5 KB |
| assoc_array.txt | -rw-r--r-- | 20.0 KB |
| atomic_ops.txt | -rw-r--r-- | 21.7 KB |
| bad_memory.txt | -rw-r--r-- | 1.1 KB |
| basic_profiling.txt | -rw-r--r-- | 1.7 KB |
| bcache.txt | -rw-r--r-- | 16.4 KB |
| binfmt_misc.txt | -rw-r--r-- | 5.9 KB |
| braille-console.txt | -rw-r--r-- | 1.4 KB |
| bt8xxgpio.txt | -rw-r--r-- | 4.3 KB |
| btmrvl.txt | -rw-r--r-- | 2.9 KB |
| bus-virt-phys-mapping.txt | -rw-r--r-- | 7.9 KB |
| cachetlb.txt | -rw-r--r-- | 17.1 KB |
| circular-buffers.txt | -rw-r--r-- | 8.4 KB |
| clk.txt | -rw-r--r-- | 9.6 KB |
| coccinelle.txt | -rw-r--r-- | 9.0 KB |
| cpu-hotplug.txt | -rw-r--r-- | 15.7 KB |
| cpu-load.txt | -rw-r--r-- | 3.0 KB |
| cputopology.txt | -rw-r--r-- | 3.8 KB |
| crc32.txt | -rw-r--r-- | 8.5 KB |
| dcdbas.txt | -rw-r--r-- | 3.6 KB |
| debugging-modules.txt | -rw-r--r-- | 954 bytes |
| debugging-via-ohci1394.txt | -rw-r--r-- | 7.3 KB |
| dell_rbu.txt | -rw-r--r-- | 4.9 KB |
| devices.txt | -rw-r--r-- | 115.8 KB |
| digsig.txt | -rw-r--r-- | 2.8 KB |
| dma-buf-sharing.txt | -rw-r--r-- | 20.7 KB |
| dmaengine.txt | -rw-r--r-- | 7.6 KB |
| dmatest.txt | -rw-r--r-- | 3.4 KB |
| dontdiff | -rw-r--r-- | 2.5 KB |
| dynamic-debug-howto.txt | -rw-r--r-- | 12.6 KB |
| edac.txt | -rw-r--r-- | 24.3 KB |
| efi-stub.txt | -rw-r--r-- | 2.3 KB |
| eisa.txt | -rw-r--r-- | 7.1 KB |
| email-clients.txt | -rw-r--r-- | 8.6 KB |
| flexible-arrays.txt | -rw-r--r-- | 5.5 KB |
| futex-requeue-pi.txt | -rw-r--r-- | 5.0 KB |
| gcov.txt | -rw-r--r-- | 7.6 KB |
| highuid.txt | -rw-r--r-- | 2.4 KB |
| hw_random.txt | -rw-r--r-- | 3.5 KB |
| hwspinlock.txt | -rw-r--r-- | 12.1 KB |
| init.txt | -rw-r--r-- | 2.5 KB |
| initrd.txt | -rw-r--r-- | 14.1 KB |
| intel_txt.txt | -rw-r--r-- | 10.2 KB |
| io-mapping.txt | -rw-r--r-- | 3.2 KB |
| io_ordering.txt | -rw-r--r-- | 1.9 KB |
| iostats.txt | -rw-r--r-- | 8.0 KB |
| irqflags-tracing.txt | -rw-r--r-- | 2.6 KB |
| isapnp.txt | -rw-r--r-- | 433 bytes |
| java.txt | -rw-r--r-- | 10.7 KB |
| kernel-doc-nano-HOWTO.txt | -rw-r--r-- | 11.7 KB |
| kernel-docs.txt | -rw-r--r-- | 33.1 KB |
| kernel-parameters.txt | -rw-r--r-- | 124.6 KB |
| kernel-per-CPU-kthreads.txt | -rw-r--r-- | 12.1 KB |
| kmemcheck.txt | -rw-r--r-- | 29.9 KB |
| kmemleak.txt | -rw-r--r-- | 7.9 KB |
| kobject.txt | -rw-r--r-- | 18.0 KB |
| kprobes.txt | -rw-r--r-- | 29.5 KB |
| kref.txt | -rw-r--r-- | 8.4 KB |
| ldm.txt | -rw-r--r-- | 3.8 KB |
| local_ops.txt | -rw-r--r-- | 6.1 KB |
| lockdep-design.txt | -rw-r--r-- | 11.6 KB |
| lockstat.txt | -rw-r--r-- | 11.1 KB |
| lockup-watchdogs.txt | -rw-r--r-- | 3.1 KB |
| logo.gif | -rw-r--r-- | 16.0 KB |
| logo.txt | -rw-r--r-- | 563 bytes |
| magic-number.txt | -rw-r--r-- | 9.7 KB |
| md.txt | -rw-r--r-- | 25.3 KB |
| media-framework.txt | -rw-r--r-- | 14.7 KB |
| memory-barriers.txt | -rw-r--r-- | 102.0 KB |
| memory-hotplug.txt | -rw-r--r-- | 16.1 KB |
| module-signing.txt | -rw-r--r-- | 8.6 KB |
| mono.txt | -rw-r--r-- | 2.5 KB |
| mutex-design.txt | -rw-r--r-- | 5.8 KB |
| nommu-mmap.txt | -rw-r--r-- | 12.7 KB |
| numastat.txt | -rw-r--r-- | 836 bytes |
| oops-tracing.txt | -rw-r--r-- | 12.5 KB |
| padata.txt | -rw-r--r-- | 7.3 KB |
| parport-lowlevel.txt | -rw-r--r-- | 32.2 KB |
| parport.txt | -rw-r--r-- | 8.8 KB |
| percpu-rw-semaphore.txt | -rw-r--r-- | 1.1 KB |
| phy.txt | -rw-r--r-- | 6.6 KB |
| pi-futex.txt | -rw-r--r-- | 5.7 KB |
| pinctrl.txt | -rw-r--r-- | 50.0 KB |
| pnp.txt | -rw-r--r-- | 6.8 KB |
| preempt-locking.txt | -rw-r--r-- | 5.2 KB |
| printk-formats.txt | -rw-r--r-- | 7.5 KB |
| pwm.txt | -rw-r--r-- | 4.3 KB |
| ramoops.txt | -rw-r--r-- | 4.6 KB |
| rbtree.txt | -rw-r--r-- | 13.3 KB |
| remoteproc.txt | -rw-r--r-- | 12.3 KB |
| rfkill.txt | -rw-r--r-- | 4.7 KB |
| robust-futex-ABI.txt | -rw-r--r-- | 8.7 KB |
| robust-futexes.txt | -rw-r--r-- | 9.4 KB |
| rpmsg.txt | -rw-r--r-- | 13.5 KB |
| rt-mutex-design.txt | -rw-r--r-- | 32.8 KB |
| rt-mutex.txt | -rw-r--r-- | 3.5 KB |
| rtc.txt | -rw-r--r-- | 15.6 KB |
| serial-console.txt | -rw-r--r-- | 4.0 KB |
| sgi-ioc4.txt | -rw-r--r-- | 2.0 KB |
| sgi-visws.txt | -rw-r--r-- | 678 bytes |
| smsc_ece1099.txt | -rw-r--r-- | 2.4 KB |
| sparse.txt | -rw-r--r-- | 3.8 KB |
| spinlocks.txt | -rw-r--r-- | 6.5 KB |
| stable_api_nonsense.txt | -rw-r--r-- | 9.2 KB |
| stable_kernel_rules.txt | -rw-r--r-- | 4.4 KB |
| static-keys.txt | -rw-r--r-- | 11.9 KB |
| svga.txt | -rw-r--r-- | 14.1 KB |
| sysfs-rules.txt | -rw-r--r-- | 8.1 KB |
| sysrq.txt | -rw-r--r-- | 11.7 KB |
| this_cpu_ops.txt | -rw-r--r-- | 6.4 KB |
| unaligned-memory-access.txt | -rw-r--r-- | 10.4 KB |
| unicode.txt | -rw-r--r-- | 6.5 KB |
| unshare.txt | -rw-r--r-- | 13.1 KB |
| vfio.txt | -rw-r--r-- | 15.9 KB |
| vgaarbiter.txt | -rw-r--r-- | 8.1 KB |
| video-output.txt | -rw-r--r-- | 1.1 KB |
| vme_api.txt | -rw-r--r-- | 13.2 KB |
| volatile-considered-harmful.txt | -rw-r--r-- | 5.6 KB |
| workqueue.txt | -rw-r--r-- | 14.7 KB |
| ww-mutex-design.txt | -rw-r--r-- | 12.4 KB |
| xz.txt | -rw-r--r-- | 5.7 KB |
| zorro.txt | -rw-r--r-- | 2.9 KB |
Computing file changes ...
