Revision dbd12944017dd1bdd191cd6a15e63d09c6c16204 authored by Parker Moore on 21 July 2016, 00:58:57 UTC, committed by Junio C Hamano on 22 July 2016, 17:54:11 UTC
Running `make all` in `contrib/persistent-https` results in a
failure on Go 1.7 and above.
Specifically, the error is:
go build -o git-remote-persistent-https \
-ldflags "-X main._BUILD_EMBED_LABEL 1468613136"
# _/Users/parkr/github/git/contrib/persistent-https
/usr/local/Cellar/go/1.7rc1/libexec/pkg/tool/darwin_amd64/link: -X
flag requires argument of the form importpath.name=value
make: *** [git-remote-persistent-https] Error 2
This `name=value` syntax for the -X flag was introduced in Go v1.5
(released Aug 19, 2015):
- release notes: https://golang.org/doc/go1.5#link
- commit: https://github.com/golang/go/commit/12795c02f3d6fc54ece09a86e70aaa40a94d5131
In Go v1.7, support for the old syntax was removed:
- release notes: https://tip.golang.org/doc/go1.7#compiler
- commit: https://github.com/golang/go/commit/51b624e6a29b135ce0fadb22b678acf4998ff16f
Add '=' between the symbol and its value for recent versions of Go,
while leaving it out for older ones.
Signed-off-by: Parker Moore <parkrmoore@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent e465796
| File | Mode | Size |
|---|---|---|
| nedmalloc | ||
| poll | ||
| regex | ||
| vcbuild | ||
| win32 | ||
| apple-common-crypto.h | -rw-r--r-- | 2.6 KB |
| basename.c | -rw-r--r-- | 334 bytes |
| bswap.h | -rw-r--r-- | 4.6 KB |
| fopen.c | -rw-r--r-- | 931 bytes |
| gmtime.c | -rw-r--r-- | 605 bytes |
| hstrerror.c | -rw-r--r-- | 513 bytes |
| inet_ntop.c | -rw-r--r-- | 4.8 KB |
| inet_pton.c | -rw-r--r-- | 6.8 KB |
| memmem.c | -rw-r--r-- | 752 bytes |
| mingw.c | -rw-r--r-- | 54.1 KB |
| mingw.h | -rw-r--r-- | 13.5 KB |
| mkdir.c | -rw-r--r-- | 468 bytes |
| mkdtemp.c | -rw-r--r-- | 153 bytes |
| mmap.c | -rw-r--r-- | 692 bytes |
| msvc.c | -rw-r--r-- | 113 bytes |
| msvc.h | -rw-r--r-- | 570 bytes |
| obstack.c | -rw-r--r-- | 13.8 KB |
| obstack.h | -rw-r--r-- | 19.1 KB |
| pread.c | -rw-r--r-- | 433 bytes |
| precompose_utf8.c | -rw-r--r-- | 4.5 KB |
| precompose_utf8.h | -rw-r--r-- | 1.3 KB |
| qsort.c | -rw-r--r-- | 1.1 KB |
| setenv.c | -rw-r--r-- | 857 bytes |
| sha1-chunked.c | -rw-r--r-- | 362 bytes |
| sha1-chunked.h | -rw-r--r-- | 81 bytes |
| snprintf.c | -rw-r--r-- | 1.5 KB |
| stat.c | -rw-r--r-- | 1.1 KB |
| strcasestr.c | -rw-r--r-- | 431 bytes |
| strlcpy.c | -rw-r--r-- | 247 bytes |
| strtoimax.c | -rw-r--r-- | 214 bytes |
| strtoumax.c | -rw-r--r-- | 217 bytes |
| terminal.c | -rw-r--r-- | 2.5 KB |
| terminal.h | -rw-r--r-- | 142 bytes |
| unsetenv.c | -rw-r--r-- | 591 bytes |
| win32.h | -rw-r--r-- | 878 bytes |
| win32mmap.c | -rw-r--r-- | 907 bytes |
| winansi.c | -rw-r--r-- | 13.9 KB |
Computing file changes ...
