Revision dc24f8b4ecd3d6c4153a1ec1bc2006ab32a41b8d authored by Paolo Abeni on 26 February 2020, 11:19:03 UTC, committed by David S. Miller on 27 February 2020, 04:49:50 UTC
syzbot noted that the master MPTCP socket lacks the icsk_sync_mss
callback, and was able to trigger a null pointer dereference:
BUG: kernel NULL pointer dereference, address: 0000000000000000
PGD 8e171067 P4D 8e171067 PUD 93fa2067 PMD 0
Oops: 0010 [#1] PREEMPT SMP KASAN
CPU: 0 PID: 8984 Comm: syz-executor066 Not tainted 5.6.0-rc2-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:0x0
Code: Bad RIP value.
RSP: 0018:ffffc900020b7b80 EFLAGS: 00010246
RAX: 1ffff110124ba600 RBX: 0000000000000000 RCX: ffff88809fefa600
RDX: ffff8880994cdb18 RSI: 0000000000000000 RDI: ffff8880925d3140
RBP: ffffc900020b7bd8 R08: ffffffff870225be R09: fffffbfff140652a
R10: fffffbfff140652a R11: 0000000000000000 R12: ffff8880925d35d0
R13: ffff8880925d3140 R14: dffffc0000000000 R15: 1ffff110124ba6ba
FS: 0000000001a0b880(0000) GS:ffff8880aea00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffffffffffffd6 CR3: 00000000a6d6f000 CR4: 00000000001406f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
cipso_v4_sock_setattr+0x34b/0x470 net/ipv4/cipso_ipv4.c:1888
netlbl_sock_setattr+0x2a7/0x310 net/netlabel/netlabel_kapi.c:989
smack_netlabel security/smack/smack_lsm.c:2425 [inline]
smack_inode_setsecurity+0x3da/0x4a0 security/smack/smack_lsm.c:2716
security_inode_setsecurity+0xb2/0x140 security/security.c:1364
__vfs_setxattr_noperm+0x16f/0x3e0 fs/xattr.c:197
vfs_setxattr fs/xattr.c:224 [inline]
setxattr+0x335/0x430 fs/xattr.c:451
__do_sys_fsetxattr fs/xattr.c:506 [inline]
__se_sys_fsetxattr+0x130/0x1b0 fs/xattr.c:495
__x64_sys_fsetxattr+0xbf/0xd0 fs/xattr.c:495
do_syscall_64+0xf7/0x1c0 arch/x86/entry/common.c:294
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x440199
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 fb 13 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffcadc19e48 EFLAGS: 00000246 ORIG_RAX: 00000000000000be
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 0000000000440199
RDX: 0000000020000200 RSI: 00000000200001c0 RDI: 0000000000000003
RBP: 00000000006ca018 R08: 0000000000000003 R09: 00000000004002c8
R10: 0000000000000009 R11: 0000000000000246 R12: 0000000000401a20
R13: 0000000000401ab0 R14: 0000000000000000 R15: 0000000000000000
Modules linked in:
CR2: 0000000000000000
Address the issue adding a dummy icsk_sync_mss callback.
To properly sync the subflows mss and options list we need some
additional infrastructure, which will land to net-next.
Reported-by: syzbot+f4dfece964792d80b139@syzkaller.appspotmail.com
Fixes: 2303f994b3e1 ("mptcp: Associate MPTCP context with TCP socket")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 4f31c53
| File | Mode | Size |
|---|---|---|
| kasan | ||
| Kconfig | -rw-r--r-- | 24.1 KB |
| Kconfig.debug | -rw-r--r-- | 5.3 KB |
| Makefile | -rw-r--r-- | 3.9 KB |
| backing-dev.c | -rw-r--r-- | 28.5 KB |
| balloon_compaction.c | -rw-r--r-- | 8.2 KB |
| cleancache.c | -rw-r--r-- | 9.8 KB |
| cma.c | -rw-r--r-- | 14.3 KB |
| cma.h | -rw-r--r-- | 573 bytes |
| cma_debug.c | -rw-r--r-- | 4.5 KB |
| compaction.c | -rw-r--r-- | 74.8 KB |
| debug.c | -rw-r--r-- | 6.4 KB |
| debug_page_ref.c | -rw-r--r-- | 1.4 KB |
| dmapool.c | -rw-r--r-- | 13.8 KB |
| early_ioremap.c | -rw-r--r-- | 6.8 KB |
| fadvise.c | -rw-r--r-- | 5.4 KB |
| failslab.c | -rw-r--r-- | 1.4 KB |
| filemap.c | -rw-r--r-- | 96.1 KB |
| frame_vector.c | -rw-r--r-- | 6.5 KB |
| frontswap.c | -rw-r--r-- | 14.2 KB |
| gup.c | -rw-r--r-- | 70.9 KB |
| gup_benchmark.c | -rw-r--r-- | 2.9 KB |
| highmem.c | -rw-r--r-- | 11.7 KB |
| hmm.c | -rw-r--r-- | 19.2 KB |
| huge_memory.c | -rw-r--r-- | 85.1 KB |
| hugetlb.c | -rw-r--r-- | 136.5 KB |
| hugetlb_cgroup.c | -rw-r--r-- | 15.6 KB |
| hwpoison-inject.c | -rw-r--r-- | 2.8 KB |
| init-mm.c | -rw-r--r-- | 1.2 KB |
| internal.h | -rw-r--r-- | 17.7 KB |
| interval_tree.c | -rw-r--r-- | 3.1 KB |
| khugepaged.c | -rw-r--r-- | 55.0 KB |
| kmemleak-test.c | -rw-r--r-- | 2.6 KB |
| kmemleak.c | -rw-r--r-- | 56.2 KB |
| ksm.c | -rw-r--r-- | 89.2 KB |
| list_lru.c | -rw-r--r-- | 14.6 KB |
| maccess.c | -rw-r--r-- | 7.9 KB |
| madvise.c | -rw-r--r-- | 28.9 KB |
| mapping_dirty_helpers.c | -rw-r--r-- | 9.6 KB |
| memblock.c | -rw-r--r-- | 58.3 KB |
| memcontrol.c | -rw-r--r-- | 184.4 KB |
| memfd.c | -rw-r--r-- | 7.9 KB |
| memory-failure.c | -rw-r--r-- | 51.5 KB |
| memory.c | -rw-r--r-- | 130.6 KB |
| memory_hotplug.c | -rw-r--r-- | 47.0 KB |
| mempolicy.c | -rw-r--r-- | 74.8 KB |
| mempool.c | -rw-r--r-- | 15.8 KB |
| memremap.c | -rw-r--r-- | 12.1 KB |
| memtest.c | -rw-r--r-- | 2.8 KB |
| migrate.c | -rw-r--r-- | 77.2 KB |
| mincore.c | -rw-r--r-- | 7.6 KB |
| mlock.c | -rw-r--r-- | 22.7 KB |
| mm_init.c | -rw-r--r-- | 4.8 KB |
| mmap.c | -rw-r--r-- | 100.1 KB |
| mmu_context.c | -rw-r--r-- | 1.3 KB |
| mmu_gather.c | -rw-r--r-- | 8.4 KB |
| mmu_notifier.c | -rw-r--r-- | 34.2 KB |
| mmzone.c | -rw-r--r-- | 2.4 KB |
| mprotect.c | -rw-r--r-- | 15.5 KB |
| mremap.c | -rw-r--r-- | 19.4 KB |
| msync.c | -rw-r--r-- | 2.7 KB |
| nommu.c | -rw-r--r-- | 45.6 KB |
| oom_kill.c | -rw-r--r-- | 30.2 KB |
| page-writeback.c | -rw-r--r-- | 84.8 KB |
| page_alloc.c | -rw-r--r-- | 241.3 KB |
| page_counter.c | -rw-r--r-- | 6.6 KB |
| page_ext.c | -rw-r--r-- | 10.9 KB |
| page_idle.c | -rw-r--r-- | 5.5 KB |
| page_io.c | -rw-r--r-- | 10.8 KB |
| page_isolation.c | -rw-r--r-- | 8.5 KB |
| page_owner.c | -rw-r--r-- | 16.0 KB |
| page_poison.c | -rw-r--r-- | 3.0 KB |
| page_vma_mapped.c | -rw-r--r-- | 7.7 KB |
| pagewalk.c | -rw-r--r-- | 14.2 KB |
| percpu-internal.h | -rw-r--r-- | 6.3 KB |
| percpu-km.c | -rw-r--r-- | 3.0 KB |
| percpu-stats.c | -rw-r--r-- | 5.7 KB |
| percpu-vm.c | -rw-r--r-- | 10.3 KB |
| percpu.c | -rw-r--r-- | 91.3 KB |
| pgtable-generic.c | -rw-r--r-- | 5.6 KB |
| process_vm_access.c | -rw-r--r-- | 9.9 KB |
| ptdump.c | -rw-r--r-- | 3.4 KB |
| readahead.c | -rw-r--r-- | 16.5 KB |
| rmap.c | -rw-r--r-- | 55.0 KB |
| rodata_test.c | -rw-r--r-- | 1.3 KB |
| shmem.c | -rw-r--r-- | 107.6 KB |
| shuffle.c | -rw-r--r-- | 5.7 KB |
| shuffle.h | -rw-r--r-- | 1.5 KB |
| slab.c | -rw-r--r-- | 105.5 KB |
| slab.h | -rw-r--r-- | 19.3 KB |
| slab_common.c | -rw-r--r-- | 44.0 KB |
| slob.c | -rw-r--r-- | 18.0 KB |
| slub.c | -rw-r--r-- | 143.3 KB |
| sparse-vmemmap.c | -rw-r--r-- | 6.9 KB |
| sparse.c | -rw-r--r-- | 25.5 KB |
| swap.c | -rw-r--r-- | 31.0 KB |
| swap_cgroup.c | -rw-r--r-- | 5.2 KB |
| swap_slots.c | -rw-r--r-- | 9.4 KB |
| swap_state.c | -rw-r--r-- | 22.4 KB |
| swapfile.c | -rw-r--r-- | 95.0 KB |
| truncate.c | -rw-r--r-- | 26.7 KB |
| usercopy.c | -rw-r--r-- | 9.5 KB |
| userfaultfd.c | -rw-r--r-- | 15.7 KB |
| util.c | -rw-r--r-- | 22.2 KB |
| vmacache.c | -rw-r--r-- | 2.7 KB |
| vmalloc.c | -rw-r--r-- | 93.4 KB |
| vmpressure.c | -rw-r--r-- | 13.9 KB |
| vmscan.c | -rw-r--r-- | 124.6 KB |
| vmstat.c | -rw-r--r-- | 51.9 KB |
| workingset.c | -rw-r--r-- | 20.5 KB |
| z3fold.c | -rw-r--r-- | 46.6 KB |
| zbud.c | -rw-r--r-- | 18.2 KB |
| zpool.c | -rw-r--r-- | 11.2 KB |
| zsmalloc.c | -rw-r--r-- | 62.0 KB |
| zswap.c | -rw-r--r-- | 35.1 KB |
Computing file changes ...
