Revision dc93f0dcb436dfd24a06c5b3c0f4c5cd9296e8e5 authored by Trevor Wu on 01 June 2023, 03:33:18 UTC, committed by Mark Brown on 01 June 2023, 11:30:36 UTC
During mt8195_afe_init_clock(), mt8195_audsys_clk_register() was called
followed by several other devm functions. At mt8195_afe_deinit_clock()
located at mt8195_afe_pcm_dev_remove(), mt8195_audsys_clk_unregister()
was called.

However, there was an issue with the order in which these functions were
called. Specifically, the remove callback of platform_driver was called
before devres released the resource, resulting in a use-after-free issue
during remove time.

At probe time, the order of calls was:
1. mt8195_audsys_clk_register
2. afe_priv->clk = devm_kcalloc
3. afe_priv->clk[i] = devm_clk_get

At remove time, the order of calls was:
1. mt8195_audsys_clk_unregister
3. free afe_priv->clk[i]
2. free afe_priv->clk

To resolve the problem, we can utilize devm_add_action_or_reset() in
mt8195_audsys_clk_register() so that the remove order can be changed to
3->2->1.

Fixes: 6746cc858259 ("ASoC: mediatek: mt8195: add platform driver")
Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20230601033318.10408-3-trevor.wu@mediatek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent fd67a7a
History
File Mode Size
.gitignore -rw-r--r-- 120 bytes
Kconfig -rw-r--r-- 5.4 KB
Makefile -rw-r--r-- 3.2 KB
blacklist.c -rw-r--r-- 9.5 KB
blacklist.h -rw-r--r-- 135 bytes
blacklist_hashes.c -rw-r--r-- 147 bytes
check-blacklist-hashes.awk -rwxr-xr-x 1.0 KB
default_x509.genkey -rw-r--r-- 407 bytes
extract-cert.c -rw-r--r-- 3.7 KB
revocation_certificates.S -rw-r--r-- 495 bytes
system_certificates.S -rw-r--r-- 1017 bytes
system_keyring.c -rw-r--r-- 10.3 KB

back to top