Revision dd757ffde0117af50ea22c295469389f84501f11 authored by Maysam Yabandeh on 20 August 2019, 18:38:15 UTC, committed by myabandeh on 18 September 2019, 21:39:45 UTC
Summary:
The comments of snap_refresh_nanos advertise that the snapshot refresh feature will be disabled when the option is set to 0. This contract is however not honored in the code: https://github.com/facebook/rocksdb/pull/5278
The patch fixes that and also adds an assert to ensure that the feature is not used when the option  is zero.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5724

Differential Revision: D16918185

Pulled By: maysamyabandeh

fbshipit-source-id: fec167287df7d85093e087fc39c0eb243e3bbd7e
1 parent fdc56e2
History
File Mode Size
advisor
dump
rdb
CMakeLists.txt -rw-r--r-- 544 bytes
Dockerfile -rw-r--r-- 81 bytes
analyze_txn_stress_test.sh -rwxr-xr-x 3.7 KB
auto_sanity_test.sh -rwxr-xr-x 2.8 KB
benchmark.sh -rwxr-xr-x 17.0 KB
benchmark_leveldb.sh -rwxr-xr-x 5.2 KB
blob_dump.cc -rw-r--r-- 3.3 KB
check_format_compatible.sh -rwxr-xr-x 6.6 KB
db_bench.cc -rw-r--r-- 813 bytes
db_bench_tool.cc -rw-r--r-- 223.8 KB
db_bench_tool_test.cc -rw-r--r-- 9.6 KB
db_crashtest.py -rw-r--r-- 14.7 KB
db_repl_stress.cc -rw-r--r-- 4.5 KB
db_sanity_test.cc -rw-r--r-- 8.4 KB
db_stress.cc -rw-r--r-- 150.9 KB
dbench_monitor -rwxr-xr-x 2.6 KB
generate_random_db.sh -rwxr-xr-x 806 bytes
ingest_external_sst.sh -rwxr-xr-x 403 bytes
ldb.cc -rw-r--r-- 572 bytes
ldb_cmd.cc -rw-r--r-- 104.7 KB
ldb_cmd_impl.h -rw-r--r-- 15.6 KB
ldb_cmd_test.cc -rw-r--r-- 3.9 KB
ldb_test.py -rw-r--r-- 26.2 KB
ldb_tool.cc -rw-r--r-- 4.7 KB
pflag -rwxr-xr-x 4.0 KB
reduce_levels_test.cc -rw-r--r-- 5.2 KB
regression_test.sh -rwxr-xr-x 15.9 KB
report_lite_binary_size.sh -rwxr-xr-x 1.3 KB
rocksdb_dump_test.sh -rwxr-xr-x 436 bytes
run_flash_bench.sh -rwxr-xr-x 13.5 KB
run_leveldb.sh -rwxr-xr-x 6.3 KB
sample-dump.dmp -rw-r--r-- 100 bytes
sst_dump.cc -rw-r--r-- 581 bytes
sst_dump_test.cc -rw-r--r-- 7.0 KB
sst_dump_tool.cc -rw-r--r-- 23.3 KB
sst_dump_tool_imp.h -rw-r--r-- 2.9 KB
trace_analyzer.cc -rw-r--r-- 709 bytes
trace_analyzer_test.cc -rw-r--r-- 27.5 KB
trace_analyzer_tool.cc -rw-r--r-- 68.1 KB
trace_analyzer_tool.h -rw-r--r-- 9.8 KB
verify_random_db.sh -rwxr-xr-x 1.1 KB
write_external_sst.sh -rwxr-xr-x 527 bytes
write_stress.cc -rw-r--r-- 10.9 KB
write_stress_runner.py -rw-r--r-- 2.4 KB

back to top