Revision dda5690defe4af62ee120f055e98e40d97e4c760 authored by Zheng Liu on 21 July 2013, 02:03:20 UTC, committed by Theodore Ts'o on 21 July 2013, 02:03:20 UTC
When we try to open a file with O_TMPFILE flag, we will trigger a bug. The root cause is that in ext4_orphan_add() we check ->i_nlink == 0 and this check always fails because we set ->i_nlink = 1 in inode_init_always(). We can use the following program to trigger it: int main(int argc, char *argv[]) { int fd; fd = open(argv[1], O_TMPFILE, 0666); if (fd < 0) { perror("open "); return -1; } close(fd); return 0; } The oops message looks like this: kernel: kernel BUG at fs/ext3/namei.c:1992! kernel: invalid opcode: 0000 [#1] SMP kernel: Modules linked in: ext4 jbd2 crc16 cpufreq_ondemand ipv6 dm_mirror dm_region_hash dm_log dm_mod parport_pc parport serio_raw sg dcdbas pcspkr i2c_i801 ehci_pci ehci_hcd button acpi_cpufreq mperf e1000e ptp pps_core ttm drm_kms_helper drm hwmon i2c_algo_bit i2c_core ext3 jbd sd_mod ahci libahci libata scsi_mod uhci_hcd kernel: CPU: 0 PID: 2882 Comm: tst_tmpfile Not tainted 3.11.0-rc1+ #4 kernel: Hardware name: Dell Inc. OptiPlex 780 /0V4W66, BIOS A05 08/11/2010 kernel: task: ffff880112d30050 ti: ffff8801124d4000 task.ti: ffff8801124d4000 kernel: RIP: 0010:[<ffffffffa00db5ae>] [<ffffffffa00db5ae>] ext3_orphan_add+0x6a/0x1eb [ext3] kernel: RSP: 0018:ffff8801124d5cc8 EFLAGS: 00010202 kernel: RAX: 0000000000000000 RBX: ffff880111510128 RCX: ffff8801114683a0 kernel: RDX: 0000000000000000 RSI: ffff880111510128 RDI: ffff88010fcf65a8 kernel: RBP: ffff8801124d5d18 R08: 0080000000000000 R09: ffffffffa00d3b7f kernel: R10: ffff8801114683a0 R11: ffff8801032a2558 R12: 0000000000000000 kernel: R13: ffff88010fcf6800 R14: ffff8801032a2558 R15: ffff8801115100d8 kernel: FS: 00007f5d172b5700(0000) GS:ffff880117c00000(0000) knlGS:0000000000000000 kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b kernel: CR2: 00007f5d16df15d0 CR3: 0000000110b1d000 CR4: 00000000000407f0 kernel: Stack: kernel: 000000000000000c ffff8801048a7dc8 ffff8801114685a8 ffffffffa00b80d7 kernel: ffff8801124d5e38 ffff8801032a2558 ffff88010ce24d68 0000000000000000 kernel: ffff88011146b300 ffff8801124d5d44 ffff8801124d5d78 ffffffffa00db7e1 kernel: Call Trace: kernel: [<ffffffffa00b80d7>] ? journal_start+0x8c/0xbd [jbd] kernel: [<ffffffffa00db7e1>] ext3_tmpfile+0xb2/0x13b [ext3] kernel: [<ffffffff821076f8>] path_openat+0x11f/0x5e7 kernel: [<ffffffff821c86b4>] ? list_del+0x11/0x30 kernel: [<ffffffff82065fa2>] ? __dequeue_entity+0x33/0x38 kernel: [<ffffffff82107cd5>] do_filp_open+0x3f/0x8d kernel: [<ffffffff82112532>] ? __alloc_fd+0x50/0x102 kernel: [<ffffffff820f9296>] do_sys_open+0x13b/0x1cd kernel: [<ffffffff820f935c>] SyS_open+0x1e/0x20 kernel: [<ffffffff82398c02>] system_call_fastpath+0x16/0x1b kernel: Code: 39 c7 0f 85 67 01 00 00 0f b7 03 25 00 f0 00 00 3d 00 40 00 00 74 18 3d 00 80 00 00 74 11 3d 00 a0 00 00 74 0a 83 7b 48 00 74 04 <0f> 0b eb fe 49 8b 85 50 03 00 00 4c 89 f6 48 c7 c7 c0 99 0e a0 kernel: RIP [<ffffffffa00db5ae>] ext3_orphan_add+0x6a/0x1eb [ext3] kernel: RSP <ffff8801124d5cc8> Here we couldn't call clear_nlink() directly because in d_tmpfile() we will call inode_dec_link_count() to decrease ->i_nlink. So this commit tries to call d_tmpfile() before ext4_orphan_add() to fix this problem. Signed-off-by: Zheng Liu <wenqing.lz@taobao.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> Cc: Jan Kara <jack@suse.cz> Cc: Al Viro <viro@zeniv.linux.org.uk>
1 parent e94bd34
File | Mode | Size |
---|---|---|
9p | ||
adfs | ||
affs | ||
afs | ||
autofs4 | ||
befs | ||
bfs | ||
btrfs | ||
cachefiles | ||
ceph | ||
cifs | ||
coda | ||
configfs | ||
cramfs | ||
debugfs | ||
devpts | ||
dlm | ||
ecryptfs | ||
efivarfs | ||
efs | ||
exofs | ||
exportfs | ||
ext2 | ||
ext3 | ||
ext4 | ||
f2fs | ||
fat | ||
freevxfs | ||
fscache | ||
fuse | ||
gfs2 | ||
hfs | ||
hfsplus | ||
hostfs | ||
hpfs | ||
hppfs | ||
hugetlbfs | ||
isofs | ||
jbd | ||
jbd2 | ||
jffs2 | ||
jfs | ||
lockd | ||
logfs | ||
minix | ||
ncpfs | ||
nfs | ||
nfs_common | ||
nfsd | ||
nilfs2 | ||
nls | ||
notify | ||
ntfs | ||
ocfs2 | ||
omfs | ||
openpromfs | ||
proc | ||
pstore | ||
qnx4 | ||
qnx6 | ||
quota | ||
ramfs | ||
reiserfs | ||
romfs | ||
squashfs | ||
sysfs | ||
sysv | ||
ubifs | ||
udf | ||
ufs | ||
xfs | ||
Kconfig | -rw-r--r-- | 6.0 KB |
Kconfig.binfmt | -rw-r--r-- | 7.2 KB |
Makefile | -rw-r--r-- | 4.2 KB |
aio.c | -rw-r--r-- | 32.7 KB |
anon_inodes.c | -rw-r--r-- | 6.4 KB |
attr.c | -rw-r--r-- | 7.0 KB |
bad_inode.c | -rw-r--r-- | 7.7 KB |
binfmt_aout.c | -rw-r--r-- | 11.2 KB |
binfmt_elf.c | -rw-r--r-- | 57.8 KB |
binfmt_elf_fdpic.c | -rw-r--r-- | 48.5 KB |
binfmt_em86.c | -rw-r--r-- | 2.7 KB |
binfmt_flat.c | -rw-r--r-- | 26.4 KB |
binfmt_misc.c | -rw-r--r-- | 14.8 KB |
binfmt_script.c | -rw-r--r-- | 2.7 KB |
binfmt_som.c | -rw-r--r-- | 7.1 KB |
bio-integrity.c | -rw-r--r-- | 19.9 KB |
bio.c | -rw-r--r-- | 47.6 KB |
block_dev.c | -rw-r--r-- | 42.0 KB |
buffer.c | -rw-r--r-- | 88.4 KB |
char_dev.c | -rw-r--r-- | 14.0 KB |
compat.c | -rw-r--r-- | 36.7 KB |
compat_binfmt_elf.c | -rw-r--r-- | 3.6 KB |
compat_ioctl.c | -rw-r--r-- | 45.4 KB |
coredump.c | -rw-r--r-- | 17.4 KB |
coredump.h | -rw-r--r-- | 106 bytes |
dcache.c | -rw-r--r-- | 78.2 KB |
dcookies.c | -rw-r--r-- | 6.9 KB |
direct-io.c | -rw-r--r-- | 37.3 KB |
drop_caches.c | -rw-r--r-- | 1.5 KB |
eventfd.c | -rw-r--r-- | 11.3 KB |
eventpoll.c | -rw-r--r-- | 57.6 KB |
exec.c | -rw-r--r-- | 39.2 KB |
fcntl.c | -rw-r--r-- | 16.3 KB |
fhandle.c | -rw-r--r-- | 6.5 KB |
file.c | -rw-r--r-- | 21.9 KB |
file_table.c | -rw-r--r-- | 12.3 KB |
filesystems.c | -rw-r--r-- | 6.4 KB |
fs-writeback.c | -rw-r--r-- | 39.1 KB |
fs_struct.c | -rw-r--r-- | 3.3 KB |
generic_acl.c | -rw-r--r-- | 3.9 KB |
inode.c | -rw-r--r-- | 48.6 KB |
internal.h | -rw-r--r-- | 3.4 KB |
ioctl.c | -rw-r--r-- | 15.5 KB |
ioprio.c | -rw-r--r-- | 5.0 KB |
libfs.c | -rw-r--r-- | 25.3 KB |
locks.c | -rw-r--r-- | 63.7 KB |
mbcache.c | -rw-r--r-- | 16.4 KB |
mount.h | -rw-r--r-- | 2.5 KB |
mpage.c | -rw-r--r-- | 20.0 KB |
namei.c | -rw-r--r-- | 101.3 KB |
namespace.c | -rw-r--r-- | 69.7 KB |
no-block.c | -rw-r--r-- | 688 bytes |
open.c | -rw-r--r-- | 24.8 KB |
pipe.c | -rw-r--r-- | 29.2 KB |
pnode.c | -rw-r--r-- | 9.0 KB |
pnode.h | -rw-r--r-- | 1.4 KB |
posix_acl.c | -rw-r--r-- | 9.2 KB |
proc_namespace.c | -rw-r--r-- | 7.5 KB |
read_write.c | -rw-r--r-- | 27.7 KB |
readdir.c | -rw-r--r-- | 6.8 KB |
select.c | -rw-r--r-- | 25.4 KB |
seq_file.c | -rw-r--r-- | 21.3 KB |
signalfd.c | -rw-r--r-- | 9.1 KB |
splice.c | -rw-r--r-- | 47.3 KB |
stack.c | -rw-r--r-- | 2.5 KB |
stat.c | -rw-r--r-- | 11.3 KB |
statfs.c | -rw-r--r-- | 5.3 KB |
super.c | -rw-r--r-- | 34.6 KB |
sync.c | -rw-r--r-- | 10.0 KB |
timerfd.c | -rw-r--r-- | 11.4 KB |
utimes.c | -rw-r--r-- | 5.7 KB |
xattr.c | -rw-r--r-- | 23.5 KB |
xattr_acl.c | -rw-r--r-- | 4.3 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...