https://github.com/GPflow/GPflow
Revision deb4508578f7223fa1ad5e3b6458626c4b41ef09 authored by Eric Hammy on 17 October 2019, 14:46:42 UTC, committed by GitHub on 17 October 2019, 14:46:42 UTC
1. Fix hidden bug in SGPR 2. Add the sgpr.compute_qu method from gpflow1 1. [Bug]. SGPR likelihoods were previously using full rank matrices instead of diagonal ones in both upper bound and likelihood calculation. Ie `Kdiag` was not "diag". This error was being masked by the intentional deactivation of tests comparing to the SGPR to the GPR, and what appears to be a hack to make tests working on the upper bound case. 2. [Migration]. Fixing the above broke another test, originally used for sgpr.compute_qu. The method sgpr.compute_qu had not been migrated from gpflow1, and a test that was meant to check it had been patched up to pass, erroneously. After speaking to @markvdw, concluded this method is useful, in particular to compare to SVGP model. The test has been patched up and the method ported to gpflow2.
1 parent 3b2a2ee
Tip revision: deb4508578f7223fa1ad5e3b6458626c4b41ef09 authored by Eric Hammy on 17 October 2019, 14:46:42 UTC
Fix hidden bug in SGPR (#1106)
Fix hidden bug in SGPR (#1106)
Tip revision: deb4508
| File | Mode | Size |
|---|---|---|
| __init__.py | -rw-r--r-- | 154 bytes |
| reference.py | -rw-r--r-- | 2.0 KB |
| test_broadcasted_conditionals.py | -rw-r--r-- | 8.5 KB |
| test_conditionals.py | -rw-r--r-- | 4.0 KB |
| test_config.py | -rw-r--r-- | 2.2 KB |
| test_coregion.py | -rw-r--r-- | 7.2 KB |
| test_expectations.py | -rw-r--r-- | 10.5 KB |
| test_features.py | -rw-r--r-- | 4.1 KB |
| test_gplvm.py | -rw-r--r-- | 4.1 KB |
| test_kernels.py | -rw-r--r-- | 14.8 KB |
| test_kldiv.py | -rw-r--r-- | 5.2 KB |
| test_likelihoods.py | -rw-r--r-- | 19.2 KB |
| test_logdensities.py | -rw-r--r-- | 4.0 KB |
| test_mean_functions.py | -rw-r--r-- | 11.2 KB |
| test_method_equivalence.py | -rw-r--r-- | 11.0 KB |
| test_methods.py | -rw-r--r-- | 9.4 KB |
| test_multioutput.py | -rw-r--r-- | 24.4 KB |
| test_multioutput_features.py | -rw-r--r-- | 2.2 KB |
| test_notebooks.py | -rw-r--r-- | 3.2 KB |
| test_predict.py | -rw-r--r-- | 6.9 KB |
| test_printing.py | -rw-r--r-- | 14.6 KB |
| test_prior.py | -rw-r--r-- | 2.5 KB |
| test_quadrature.py | -rw-r--r-- | 2.9 KB |
| test_scaled_euclid_dist.py | -rw-r--r-- | 1.9 KB |
| test_training.py | -rw-r--r-- | 2.9 KB |
| test_uncertain_conditional.py | -rw-r--r-- | 9.4 KB |
| test_variational.py | -rw-r--r-- | 8.1 KB |
Computing file changes ...
