Revision df38c1ce660628f05b4686eeaf0b548295ce7967 authored by Mike Kolupaev on 22 April 2019, 15:17:45 UTC, committed by Facebook Github Bot on 22 April 2019, 15:20:35 UTC
Summary: Introduce BlockBasedTableOptions::index_shortening to give users control on which key shortening techniques to be used in building index blocks. Before this patch, both separators and successor keys where shortened in indexes. With this patch, the default is set to kShortenSeparators to only shorten the separators. Since each index block has many separators and only one successor (last key), the change should not have negative impact on index block size. However it should prevent many unnecessary block loads where due to approximation introduced by shorted successor, seek would land us to the previous block and then fix it by moving to the next one. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5174 Differential Revision: D14884185 Pulled By: al13n321 fbshipit-source-id: 1b08bc8c03edcf09b6b8c16e9a7eea08ad4dd534
1 parent de76909
| File | Mode | Size |
|---|---|---|
| builder.cc | -rw-r--r-- | 10.1 KB |
| builder.h | -rw-r--r-- | 3.8 KB |
| c.cc | -rw-r--r-- | 137.0 KB |
| c_test.c | -rw-r--r-- | 58.7 KB |
| column_family.cc | -rw-r--r-- | 51.9 KB |
| column_family.h | -rw-r--r-- | 24.4 KB |
| column_family_test.cc | -rw-r--r-- | 110.9 KB |
| compact_files_test.cc | -rw-r--r-- | 13.0 KB |
| compacted_db_impl.cc | -rw-r--r-- | 5.6 KB |
| compacted_db_impl.h | -rw-r--r-- | 3.9 KB |
| compaction.cc | -rw-r--r-- | 19.2 KB |
| compaction.h | -rw-r--r-- | 14.7 KB |
| compaction_iteration_stats.h | -rw-r--r-- | 1.2 KB |
| compaction_iterator.cc | -rw-r--r-- | 30.0 KB |
| compaction_iterator.h | -rw-r--r-- | 9.1 KB |
| compaction_iterator_test.cc | -rw-r--r-- | 36.3 KB |
| compaction_job.cc | -rw-r--r-- | 64.4 KB |
| compaction_job.h | -rw-r--r-- | 6.0 KB |
| compaction_job_stats_test.cc | -rw-r--r-- | 35.5 KB |
| compaction_job_test.cc | -rw-r--r-- | 35.3 KB |
| compaction_picker.cc | -rw-r--r-- | 60.2 KB |
| compaction_picker.h | -rw-r--r-- | 12.4 KB |
| compaction_picker_fifo.cc | -rw-r--r-- | 8.6 KB |
| compaction_picker_fifo.h | -rw-r--r-- | 2.2 KB |
| compaction_picker_test.cc | -rw-r--r-- | 58.1 KB |
| compaction_picker_universal.cc | -rw-r--r-- | 33.3 KB |
| compaction_picker_universal.h | -rw-r--r-- | 4.0 KB |
| comparator_db_test.cc | -rw-r--r-- | 18.4 KB |
| convenience.cc | -rw-r--r-- | 2.3 KB |
| corruption_test.cc | -rw-r--r-- | 16.6 KB |
| cuckoo_table_db_test.cc | -rw-r--r-- | 9.8 KB |
| db_basic_test.cc | -rw-r--r-- | 41.2 KB |
| db_blob_index_test.cc | -rw-r--r-- | 13.5 KB |
| db_block_cache_test.cc | -rw-r--r-- | 26.5 KB |
| db_bloom_filter_test.cc | -rw-r--r-- | 65.6 KB |
| db_compaction_filter_test.cc | -rw-r--r-- | 27.9 KB |
| db_compaction_test.cc | -rw-r--r-- | 157.6 KB |
| db_dynamic_level_test.cc | -rw-r--r-- | 16.7 KB |
| db_encryption_test.cc | -rw-r--r-- | 2.6 KB |
| db_filesnapshot.cc | -rw-r--r-- | 5.2 KB |
| db_flush_test.cc | -rw-r--r-- | 17.3 KB |
| db_impl.cc | -rw-r--r-- | 134.6 KB |
| db_impl.h | -rw-r--r-- | 74.3 KB |
| db_impl_compaction_flush.cc | -rw-r--r-- | 111.0 KB |
| db_impl_debug.cc | -rw-r--r-- | 8.0 KB |
| db_impl_experimental.cc | -rw-r--r-- | 5.5 KB |
| db_impl_files.cc | -rw-r--r-- | 23.9 KB |
| db_impl_open.cc | -rw-r--r-- | 50.3 KB |
| db_impl_readonly.cc | -rw-r--r-- | 7.7 KB |
| db_impl_readonly.h | -rw-r--r-- | 4.8 KB |
| db_impl_secondary.cc | -rw-r--r-- | 12.9 KB |
| db_impl_secondary.h | -rw-r--r-- | 5.6 KB |
| db_impl_write.cc | -rw-r--r-- | 58.5 KB |
| db_info_dumper.cc | -rw-r--r-- | 3.7 KB |
| db_info_dumper.h | -rw-r--r-- | 481 bytes |
| db_inplace_update_test.cc | -rw-r--r-- | 5.6 KB |
| db_io_failure_test.cc | -rw-r--r-- | 18.6 KB |
| db_iter.cc | -rw-r--r-- | 54.2 KB |
| db_iter.h | -rw-r--r-- | 4.3 KB |
| db_iter_stress_test.cc | -rw-r--r-- | 20.9 KB |
| db_iter_test.cc | -rw-r--r-- | 107.2 KB |
| db_iterator_test.cc | -rw-r--r-- | 76.7 KB |
| db_log_iter_test.cc | -rw-r--r-- | 9.6 KB |
| db_memtable_test.cc | -rw-r--r-- | 9.0 KB |
| db_merge_operator_test.cc | -rw-r--r-- | 20.7 KB |
| db_options_test.cc | -rw-r--r-- | 35.7 KB |
| db_properties_test.cc | -rw-r--r-- | 63.2 KB |
| db_range_del_test.cc | -rw-r--r-- | 58.1 KB |
| db_secondary_test.cc | -rw-r--r-- | 15.5 KB |
| db_sst_test.cc | -rw-r--r-- | 37.6 KB |
| db_statistics_test.cc | -rw-r--r-- | 5.2 KB |
| db_table_properties_test.cc | -rw-r--r-- | 10.2 KB |
| db_tailing_iter_test.cc | -rw-r--r-- | 16.4 KB |
| db_test.cc | -rw-r--r-- | 204.8 KB |
| db_test2.cc | -rw-r--r-- | 130.8 KB |
| db_test_util.cc | -rw-r--r-- | 48.2 KB |
| db_test_util.h | -rw-r--r-- | 30.9 KB |
| db_universal_compaction_test.cc | -rw-r--r-- | 74.0 KB |
| db_wal_test.cc | -rw-r--r-- | 51.6 KB |
| db_write_test.cc | -rw-r--r-- | 6.7 KB |
| dbformat.cc | -rw-r--r-- | 6.2 KB |
| dbformat.h | -rw-r--r-- | 21.5 KB |
| dbformat_test.cc | -rw-r--r-- | 7.2 KB |
| deletefile_test.cc | -rw-r--r-- | 17.5 KB |
| error_handler.cc | -rw-r--r-- | 12.6 KB |
| error_handler.h | -rw-r--r-- | 2.2 KB |
| error_handler_test.cc | -rw-r--r-- | 20.6 KB |
| event_helpers.cc | -rw-r--r-- | 7.1 KB |
| event_helpers.h | -rw-r--r-- | 2.2 KB |
| experimental.cc | -rw-r--r-- | 1.5 KB |
| external_sst_file_basic_test.cc | -rw-r--r-- | 37.4 KB |
| external_sst_file_ingestion_job.cc | -rw-r--r-- | 21.7 KB |
| external_sst_file_ingestion_job.h | -rw-r--r-- | 6.1 KB |
| external_sst_file_test.cc | -rw-r--r-- | 95.3 KB |
| fault_injection_test.cc | -rw-r--r-- | 17.0 KB |
| file_indexer.cc | -rw-r--r-- | 7.5 KB |
| file_indexer.h | -rw-r--r-- | 6.1 KB |
| file_indexer_test.cc | -rw-r--r-- | 9.8 KB |
| filename_test.cc | -rw-r--r-- | 5.6 KB |
| flush_job.cc | -rw-r--r-- | 15.9 KB |
| flush_job.h | -rw-r--r-- | 5.3 KB |
| flush_job_test.cc | -rw-r--r-- | 16.3 KB |
| flush_scheduler.cc | -rw-r--r-- | 2.4 KB |
| flush_scheduler.h | -rw-r--r-- | 1.2 KB |
| forward_iterator.cc | -rw-r--r-- | 29.6 KB |
| forward_iterator.h | -rw-r--r-- | 5.5 KB |
| forward_iterator_bench.cc | -rw-r--r-- | 11.3 KB |
| in_memory_stats_history.cc | -rw-r--r-- | 1.6 KB |
| in_memory_stats_history.h | -rw-r--r-- | 1.8 KB |
| internal_stats.cc | -rw-r--r-- | 58.7 KB |
| internal_stats.h | -rw-r--r-- | 23.6 KB |
| job_context.h | -rw-r--r-- | 6.8 KB |
| listener_test.cc | -rw-r--r-- | 30.9 KB |
| log_format.h | -rw-r--r-- | 1.3 KB |
| log_reader.cc | -rw-r--r-- | 19.8 KB |
| log_reader.h | -rw-r--r-- | 6.4 KB |
| log_test.cc | -rw-r--r-- | 27.9 KB |
| log_writer.cc | -rw-r--r-- | 4.7 KB |
| log_writer.h | -rw-r--r-- | 3.8 KB |
| logs_with_prep_tracker.cc | -rw-r--r-- | 2.2 KB |
| logs_with_prep_tracker.h | -rw-r--r-- | 2.3 KB |
| lookup_key.h | -rw-r--r-- | 1.9 KB |
| malloc_stats.cc | -rw-r--r-- | 1.6 KB |
| malloc_stats.h | -rw-r--r-- | 623 bytes |
| manual_compaction_test.cc | -rw-r--r-- | 4.8 KB |
| memtable.cc | -rw-r--r-- | 36.4 KB |
| memtable.h | -rw-r--r-- | 18.8 KB |
| memtable_list.cc | -rw-r--r-- | 22.4 KB |
| memtable_list.h | -rw-r--r-- | 13.2 KB |
| memtable_list_test.cc | -rw-r--r-- | 32.1 KB |
| merge_context.h | -rw-r--r-- | 3.7 KB |
| merge_helper.cc | -rw-r--r-- | 16.1 KB |
| merge_helper.h | -rw-r--r-- | 7.9 KB |
| merge_helper_test.cc | -rw-r--r-- | 11.2 KB |
| merge_operator.cc | -rw-r--r-- | 3.1 KB |
| merge_test.cc | -rw-r--r-- | 13.4 KB |
| obsolete_files_test.cc | -rw-r--r-- | 8.3 KB |
| options_file_test.cc | -rw-r--r-- | 3.6 KB |
| perf_context_test.cc | -rw-r--r-- | 32.8 KB |
| pinned_iterators_manager.h | -rw-r--r-- | 2.4 KB |
| plain_table_db_test.cc | -rw-r--r-- | 41.7 KB |
| pre_release_callback.h | -rw-r--r-- | 1.3 KB |
| prefix_test.cc | -rw-r--r-- | 29.2 KB |
| range_del_aggregator.cc | -rw-r--r-- | 16.5 KB |
| range_del_aggregator.h | -rw-r--r-- | 13.2 KB |
| range_del_aggregator_bench.cc | -rw-r--r-- | 8.4 KB |
| range_del_aggregator_test.cc | -rw-r--r-- | 30.7 KB |
| range_tombstone_fragmenter.cc | -rw-r--r-- | 15.9 KB |
| range_tombstone_fragmenter.h | -rw-r--r-- | 9.2 KB |
| range_tombstone_fragmenter_test.cc | -rw-r--r-- | 23.6 KB |
| read_callback.h | -rw-r--r-- | 1.8 KB |
| repair.cc | -rw-r--r-- | 24.3 KB |
| repair_test.cc | -rw-r--r-- | 11.6 KB |
| snapshot_checker.h | -rw-r--r-- | 1.9 KB |
| snapshot_impl.cc | -rw-r--r-- | 767 bytes |
| snapshot_impl.h | -rw-r--r-- | 4.2 KB |
| table_cache.cc | -rw-r--r-- | 20.0 KB |
| table_cache.h | -rw-r--r-- | 7.2 KB |
| table_properties_collector.cc | -rw-r--r-- | 2.3 KB |
| table_properties_collector.h | -rw-r--r-- | 3.5 KB |
| table_properties_collector_test.cc | -rw-r--r-- | 18.3 KB |
| transaction_log_impl.cc | -rw-r--r-- | 10.7 KB |
| transaction_log_impl.h | -rw-r--r-- | 4.3 KB |
| version_builder.cc | -rw-r--r-- | 17.2 KB |
| version_builder.h | -rw-r--r-- | 1.8 KB |
| version_builder_test.cc | -rw-r--r-- | 10.4 KB |
| version_edit.cc | -rw-r--r-- | 19.9 KB |
| version_edit.h | -rw-r--r-- | 11.5 KB |
| version_edit_test.cc | -rw-r--r-- | 8.1 KB |
| version_set.cc | -rw-r--r-- | 200.8 KB |
| version_set.h | -rw-r--r-- | 45.8 KB |
| version_set_test.cc | -rw-r--r-- | 37.5 KB |
| wal_manager.cc | -rw-r--r-- | 16.4 KB |
| wal_manager.h | -rw-r--r-- | 3.3 KB |
| wal_manager_test.cc | -rw-r--r-- | 9.6 KB |
| write_batch.cc | -rw-r--r-- | 66.6 KB |
| write_batch_base.cc | -rw-r--r-- | 3.1 KB |
| write_batch_internal.h | -rw-r--r-- | 8.7 KB |
| write_batch_test.cc | -rw-r--r-- | 26.4 KB |
| write_callback.h | -rw-r--r-- | 803 bytes |
| write_callback_test.cc | -rw-r--r-- | 14.6 KB |
| write_controller.cc | -rw-r--r-- | 4.0 KB |
| write_controller.h | -rw-r--r-- | 4.7 KB |
| write_controller_test.cc | -rw-r--r-- | 4.6 KB |
| write_thread.cc | -rw-r--r-- | 27.4 KB |
| write_thread.h | -rw-r--r-- | 15.5 KB |
Computing file changes ...
