https://github.com/torvalds/linux
Revision df6c0cd9a872ebf2298f5d66d8c789f62dbe35fc authored by Jun'ichi Nomura on 30 October 2006, 21:23:56 UTC, committed by Linus Torvalds on 31 October 2006, 03:29:41 UTC
add_bd_holder() is called from bd_claim_by_kobject to put a given struct
bd_holder in the list if there is no matching entry.

There are 3 possible results of add_bd_holder():
  1. there is no matching entry and add the given one to the list
  2. there is matching entry, so just increment reference count of
     the existing one
  3. something failed during its course

1 and 2 are successful cases.  But for case 2, someone has to free the
unused struct bd_holder.

The current code frees it inside of add_bd_holder and returns same value
0 for both cases 1 and 2.  However, it's natural and less error-prone if
caller frees it since it's allocated by the caller.

Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
1 parent bcb5516
History
Tip revision: df6c0cd9a872ebf2298f5d66d8c789f62dbe35fc authored by Jun'ichi Nomura on 30 October 2006, 21:23:56 UTC
[PATCH] clean up add_bd_holder()
Tip revision: df6c0cd
File Mode Size
ABI
DocBook
RCU
accounting
aoe
arm
block
cdrom
connector
console
cpu-freq
cris
crypto
device-mapper
driver-model
drivers
dvb
early-userspace
fb
filesystems
firmware_class
fujitsu
hwmon
i2c
i2o
i386
ia64
infiniband
input
ioctl
isdn
kbuild
kdump
m68k
mips
netlabel
networking
parisc
pcmcia
power
powerpc
s390
scsi
serial
sh
sound
sparc
spi
sysctl
telephony
uml
usb
video4linux
vm
w1
watchdog
x86_64
00-INDEX -rw-r--r-- 10.4 KB
BUG-HUNTING -rw-r--r-- 7.1 KB
Changes -rw-r--r-- 11.3 KB
CodingStyle -rw-r--r-- 21.6 KB
DMA-API.txt -rw-r--r-- 20.8 KB
DMA-ISA-LPC.txt -rw-r--r-- 5.2 KB
DMA-mapping.txt -rw-r--r-- 32.0 KB
HOWTO -rw-r--r-- 28.8 KB
IO-mapping.txt -rw-r--r-- 7.8 KB
IPMI.txt -rw-r--r-- 25.2 KB
IRQ-affinity.txt -rw-r--r-- 1.3 KB
IRQ.txt -rw-r--r-- 962 bytes
MSI-HOWTO.txt -rw-r--r-- 25.4 KB
ManagementStyle -rw-r--r-- 12.9 KB
PCIEBUS-HOWTO.txt -rw-r--r-- 8.6 KB
README.DAC960 -rw-r--r-- 33.9 KB
README.cycladesZ -rw-r--r-- 293 bytes
SAK.txt -rw-r--r-- 2.9 KB
SecurityBugs -rw-r--r-- 1.8 KB
SubmitChecklist -rw-r--r-- 2.4 KB
SubmittingDrivers -rw-r--r-- 5.4 KB
SubmittingPatches -rw-r--r-- 17.8 KB
VGA-softcursor.txt -rw-r--r-- 2.0 KB
acpi-hotkey.txt -rw-r--r-- 1.3 KB
applying-patches.txt -rw-r--r-- 19.5 KB
atomic_ops.txt -rw-r--r-- 15.6 KB
basic_profiling.txt -rw-r--r-- 1.7 KB
binfmt_misc.txt -rw-r--r-- 6.0 KB
cachetlb.txt -rw-r--r-- 16.7 KB
cciss.txt -rw-r--r-- 6.5 KB
cli-sti-removal.txt -rw-r--r-- 3.9 KB
computone.txt -rw-r--r-- 17.2 KB
cpqarray.txt -rw-r--r-- 2.2 KB
cpu-hotplug.txt -rw-r--r-- 14.5 KB
cpusets.txt -rw-r--r-- 26.0 KB
cputopology.txt -rw-r--r-- 1.6 KB
dcdbas.txt -rw-r--r-- 3.6 KB
debugging-modules.txt -rw-r--r-- 759 bytes
dell_rbu.txt -rw-r--r-- 4.9 KB
devices.txt -rw-r--r-- 115.1 KB
digiepca.txt -rw-r--r-- 3.7 KB
dnotify.txt -rw-r--r-- 3.5 KB
dontdiff -rw-r--r-- 1.4 KB
ecryptfs.txt -rw-r--r-- 2.3 KB
eisa.txt -rw-r--r-- 7.1 KB
exception.txt -rw-r--r-- 12.1 KB
feature-removal-schedule.txt -rw-r--r-- 10.3 KB
floppy.txt -rw-r--r-- 8.3 KB
ftape.txt -rw-r--r-- 10.7 KB
hayes-esp.txt -rw-r--r-- 6.5 KB
highuid.txt -rw-r--r-- 2.5 KB
hpet.txt -rw-r--r-- 6.4 KB
hrtimers.txt -rw-r--r-- 8.7 KB
hw_random.txt -rw-r--r-- 2.6 KB
ibm-acpi.txt -rw-r--r-- 25.2 KB
ide.txt -rw-r--r-- 15.4 KB
initrd.txt -rw-r--r-- 13.4 KB
io_ordering.txt -rw-r--r-- 1.9 KB
ioctl-number.txt -rw-r--r-- 6.9 KB
iostats.txt -rw-r--r-- 7.1 KB
irqflags-tracing.txt -rw-r--r-- 2.6 KB
isapnp.txt -rw-r--r-- 433 bytes
java.txt -rw-r--r-- 10.7 KB
kernel-doc-nano-HOWTO.txt -rw-r--r-- 5.1 KB
kernel-docs.txt -rw-r--r-- 35.6 KB
kernel-parameters.txt -rw-r--r-- 50.3 KB
keys-request-key.txt -rw-r--r-- 6.9 KB
keys.txt -rw-r--r-- 41.8 KB
kobject.txt -rw-r--r-- 11.3 KB
kprobes.txt -rw-r--r-- 22.1 KB
kref.txt -rw-r--r-- 6.1 KB
laptop-mode.txt -rw-r--r-- 30.7 KB
ldm.txt -rw-r--r-- 3.6 KB
leds-class.txt -rw-r--r-- 2.7 KB
lockdep-design.txt -rw-r--r-- 8.8 KB
locks.txt -rw-r--r-- 2.6 KB
logo.gif -rw-r--r-- 16.0 KB
logo.txt -rw-r--r-- 563 bytes
magic-number.txt -rw-r--r-- 9.9 KB
mandatory.txt -rw-r--r-- 7.1 KB
mca.txt -rw-r--r-- 11.5 KB
md.txt -rw-r--r-- 16.9 KB
memory-barriers.txt -rw-r--r-- 75.1 KB
memory.txt -rw-r--r-- 2.1 KB
mono.txt -rw-r--r-- 2.5 KB
moxa-smartio -rw-r--r-- 16.3 KB
mtrr.txt -rw-r--r-- 10.2 KB
mutex-design.txt -rw-r--r-- 5.5 KB
nbd.txt -rw-r--r-- 1.9 KB
nfsroot.txt -rw-r--r-- 9.4 KB
nmi_watchdog.txt -rw-r--r-- 4.2 KB
nommu-mmap.txt -rw-r--r-- 10.2 KB
numastat.txt -rw-r--r-- 861 bytes
oops-tracing.txt -rw-r--r-- 11.3 KB
paride.txt -rw-r--r-- 16.7 KB
parport-lowlevel.txt -rw-r--r-- 32.5 KB
parport.txt -rw-r--r-- 8.8 KB
pci-error-recovery.txt -rw-r--r-- 17.7 KB
pci.txt -rw-r--r-- 12.6 KB
pcieaer-howto.txt -rw-r--r-- 10.6 KB
pi-futex.txt -rw-r--r-- 5.7 KB
pm.txt -rw-r--r-- 9.7 KB
pnp.txt -rw-r--r-- 6.8 KB
preempt-locking.txt -rw-r--r-- 5.2 KB
prio_tree.txt -rw-r--r-- 5.2 KB
ramdisk.txt -rw-r--r-- 6.3 KB
riscom8.txt -rw-r--r-- 1.3 KB
robust-futex-ABI.txt -rw-r--r-- 8.7 KB
robust-futexes.txt -rw-r--r-- 9.4 KB
rocket.txt -rw-r--r-- 7.6 KB
rpc-cache.txt -rw-r--r-- 8.7 KB
rt-mutex-design.txt -rw-r--r-- 32.8 KB
rt-mutex.txt -rw-r--r-- 3.5 KB
rtc.txt -rw-r--r-- 8.2 KB
sched-arch.txt -rw-r--r-- 3.3 KB
sched-coding.txt -rw-r--r-- 4.0 KB
sched-design.txt -rw-r--r-- 7.7 KB
sched-domains.txt -rw-r--r-- 3.6 KB
sched-stats.txt -rw-r--r-- 7.0 KB
serial-console.txt -rw-r--r-- 4.0 KB
sgi-ioc4.txt -rw-r--r-- 2.0 KB
sgi-visws.txt -rw-r--r-- 678 bytes
sharedsubtree.txt -rw-r--r-- 31.9 KB
smart-config.txt -rw-r--r-- 3.0 KB
smp.txt -rw-r--r-- 844 bytes
sonypi.txt -rw-r--r-- 6.2 KB
sparse.txt -rw-r--r-- 2.5 KB
specialix.txt -rw-r--r-- 14.8 KB
spinlocks.txt -rw-r--r-- 8.4 KB
stable_api_nonsense.txt -rw-r--r-- 9.3 KB
stable_kernel_rules.txt -rw-r--r-- 2.5 KB
stallion.txt -rw-r--r-- 17.6 KB
svga.txt -rw-r--r-- 14.1 KB
sx.txt -rw-r--r-- 11.3 KB
sysrq.txt -rw-r--r-- 10.1 KB
time_interpolators.txt -rw-r--r-- 1.4 KB
tipar.txt -rw-r--r-- 2.8 KB
tty.txt -rw-r--r-- 7.0 KB
unicode.txt -rw-r--r-- 6.5 KB
unshare.txt -rw-r--r-- 13.1 KB
voyager.txt -rw-r--r-- 3.4 KB
xterm-linux.xpm -rw-r--r-- 3.5 KB
zorro.txt -rw-r--r-- 2.8 KB

README.DAC960

back to top