Revision e34a314c5e49fe6b763568f6576b19f1299c33c2 authored by Dave Chinner on 27 January 2011, 01:13:35 UTC, committed by Alex Elder on 28 January 2011, 15:01:33 UTC
After test 139, kmemleak shows:
unreferenced object 0xffff880078b405d8 (size 400):
comm "xfs_io", pid 4904, jiffies 4294909383 (age 1186.728s)
hex dump (first 32 bytes):
60 c1 17 79 00 88 ff ff 60 c1 17 79 00 88 ff ff `..y....`..y....
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff81afb04d>] kmemleak_alloc+0x2d/0x60
[<ffffffff8115c6cf>] kmem_cache_alloc+0x13f/0x2b0
[<ffffffff814aaa97>] kmem_zone_alloc+0x77/0xf0
[<ffffffff814aab2e>] kmem_zone_zalloc+0x1e/0x50
[<ffffffff8147cd6b>] xfs_efi_init+0x4b/0xb0
[<ffffffff814a4ee8>] xfs_trans_get_efi+0x58/0x90
[<ffffffff81455fab>] xfs_bmap_finish+0x8b/0x1d0
[<ffffffff814851b4>] xfs_itruncate_finish+0x2c4/0x5d0
[<ffffffff814a970f>] xfs_setattr+0x8df/0xa70
[<ffffffff814b5c7b>] xfs_vn_setattr+0x1b/0x20
[<ffffffff8117dc00>] notify_change+0x170/0x2e0
[<ffffffff81163bf6>] do_truncate+0x66/0xa0
[<ffffffff81163d0b>] sys_ftruncate+0xdb/0xe0
[<ffffffff8103a002>] system_call_fastpath+0x16/0x1b
[<ffffffffffffffff>] 0xffffffffffffffff
The cause of the leak is that the "remove" parameter of IOP_UNPIN()
is never set when a CIL push is aborted. This means that the EFI
item is never freed if it was in the push being cancelled. The
problem is specific to delayed logging, but has uncovered a couple
of problems with the handling of IOP_UNPIN(remove).
Firstly, we cannot safely call xfs_trans_del_item() from IOP_UNPIN()
in the CIL commit failure path or the iclog write failure path
because for delayed loging we have no transaction context. Hence we
must only call xfs_trans_del_item() if the log item being unpinned
has an active log item descriptor.
Secondly, xfs_trans_uncommit() does not handle log item descriptor
freeing during the traversal of log items on a transaction. It can
reference a freed log item descriptor when unpinning an EFI item.
Hence it needs to use a safe list traversal method to allow items to
be removed from the transaction during IOP_UNPIN().
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Alex Elder <aelder@sgi.com>
1 parent 7db37c5
| File | Mode | Size |
|---|---|---|
| 9p | ||
| adfs | ||
| affs | ||
| afs | ||
| autofs4 | ||
| befs | ||
| bfs | ||
| btrfs | ||
| cachefiles | ||
| ceph | ||
| cifs | ||
| coda | ||
| configfs | ||
| cramfs | ||
| debugfs | ||
| devpts | ||
| dlm | ||
| ecryptfs | ||
| efs | ||
| exofs | ||
| exportfs | ||
| ext2 | ||
| ext3 | ||
| ext4 | ||
| fat | ||
| freevxfs | ||
| fscache | ||
| fuse | ||
| gfs2 | ||
| hfs | ||
| hfsplus | ||
| hostfs | ||
| hpfs | ||
| hppfs | ||
| hugetlbfs | ||
| isofs | ||
| jbd | ||
| jbd2 | ||
| jffs2 | ||
| jfs | ||
| lockd | ||
| logfs | ||
| minix | ||
| ncpfs | ||
| nfs | ||
| nfs_common | ||
| nfsd | ||
| nilfs2 | ||
| nls | ||
| notify | ||
| ntfs | ||
| ocfs2 | ||
| omfs | ||
| openpromfs | ||
| partitions | ||
| proc | ||
| qnx4 | ||
| quota | ||
| ramfs | ||
| reiserfs | ||
| romfs | ||
| squashfs | ||
| sysfs | ||
| sysv | ||
| ubifs | ||
| udf | ||
| ufs | ||
| xfs | ||
| Kconfig | -rw-r--r-- | 5.3 KB |
| Kconfig.binfmt | -rw-r--r-- | 6.4 KB |
| Makefile | -rw-r--r-- | 4.0 KB |
| aio.c | -rw-r--r-- | 46.6 KB |
| anon_inodes.c | -rw-r--r-- | 6.3 KB |
| attr.c | -rw-r--r-- | 6.6 KB |
| bad_inode.c | -rw-r--r-- | 7.8 KB |
| binfmt_aout.c | -rw-r--r-- | 12.4 KB |
| binfmt_elf.c | -rw-r--r-- | 53.7 KB |
| binfmt_elf_fdpic.c | -rw-r--r-- | 48.7 KB |
| binfmt_em86.c | -rw-r--r-- | 2.8 KB |
| binfmt_flat.c | -rw-r--r-- | 26.8 KB |
| binfmt_misc.c | -rw-r--r-- | 15.2 KB |
| binfmt_script.c | -rw-r--r-- | 2.8 KB |
| binfmt_som.c | -rw-r--r-- | 7.4 KB |
| bio-integrity.c | -rw-r--r-- | 21.2 KB |
| bio.c | -rw-r--r-- | 39.5 KB |
| block_dev.c | -rw-r--r-- | 39.1 KB |
| buffer.c | -rw-r--r-- | 87.2 KB |
| char_dev.c | -rw-r--r-- | 13.8 KB |
| compat.c | -rw-r--r-- | 55.6 KB |
| compat_binfmt_elf.c | -rw-r--r-- | 3.5 KB |
| compat_ioctl.c | -rw-r--r-- | 45.8 KB |
| dcache.c | -rw-r--r-- | 78.0 KB |
| dcookies.c | -rw-r--r-- | 6.8 KB |
| direct-io.c | -rw-r--r-- | 35.0 KB |
| drop_caches.c | -rw-r--r-- | 1.3 KB |
| eventfd.c | -rw-r--r-- | 11.0 KB |
| eventpoll.c | -rw-r--r-- | 38.9 KB |
| exec.c | -rw-r--r-- | 48.6 KB |
| fcntl.c | -rw-r--r-- | 18.3 KB |
| fifo.c | -rw-r--r-- | 3.2 KB |
| file.c | -rw-r--r-- | 11.7 KB |
| file_table.c | -rw-r--r-- | 12.1 KB |
| filesystems.c | -rw-r--r-- | 6.4 KB |
| fs-writeback.c | -rw-r--r-- | 34.2 KB |
| fs_struct.c | -rw-r--r-- | 3.9 KB |
| generic_acl.c | -rw-r--r-- | 4.7 KB |
| inode.c | -rw-r--r-- | 44.1 KB |
| internal.h | -rw-r--r-- | 2.8 KB |
| ioctl.c | -rw-r--r-- | 15.7 KB |
| ioprio.c | -rw-r--r-- | 5.0 KB |
| libfs.c | -rw-r--r-- | 25.3 KB |
| locks.c | -rw-r--r-- | 58.4 KB |
| mbcache.c | -rw-r--r-- | 16.3 KB |
| mpage.c | -rw-r--r-- | 19.7 KB |
| namei.c | -rw-r--r-- | 88.3 KB |
| namespace.c | -rw-r--r-- | 63.1 KB |
| nfsctl.c | -rw-r--r-- | 2.4 KB |
| no-block.c | -rw-r--r-- | 688 bytes |
| open.c | -rw-r--r-- | 23.9 KB |
| pipe.c | -rw-r--r-- | 28.3 KB |
| pnode.c | -rw-r--r-- | 9.3 KB |
| pnode.h | -rw-r--r-- | 1.1 KB |
| posix_acl.c | -rw-r--r-- | 8.4 KB |
| read_write.c | -rw-r--r-- | 20.8 KB |
| read_write.h | -rw-r--r-- | 542 bytes |
| readdir.c | -rw-r--r-- | 6.9 KB |
| select.c | -rw-r--r-- | 24.3 KB |
| seq_file.c | -rw-r--r-- | 17.8 KB |
| signalfd.c | -rw-r--r-- | 7.5 KB |
| splice.c | -rw-r--r-- | 46.5 KB |
| stack.c | -rw-r--r-- | 2.7 KB |
| stat.c | -rw-r--r-- | 10.5 KB |
| statfs.c | -rw-r--r-- | 5.2 KB |
| super.c | -rw-r--r-- | 26.8 KB |
| sync.c | -rw-r--r-- | 9.9 KB |
| timerfd.c | -rw-r--r-- | 6.5 KB |
| utimes.c | -rw-r--r-- | 5.6 KB |
| xattr.c | -rw-r--r-- | 15.6 KB |
| xattr_acl.c | -rw-r--r-- | 2.3 KB |
Computing file changes ...
