Revision e5ae1bb46564689e56a38f3509daffa4aca3b29c authored by Daniel Black on 27 June 2018, 19:09:50 UTC, committed by Facebook Github Bot on 27 June 2018, 19:23:07 UTC
Summary: Various rearrangements of the cch maths failed or replacing = '\0' with memset failed to convince the compiler it was nul terminated. So took the perverse option of changing strncpy to strcpy. Return null if memory couldn't be allocated. util/status.cc: In static member function ‘static const char* rocksdb::Status::CopyState(const char*)’: util/status.cc:28:15: error: ‘char* strncpy(char*, const char*, size_t)’ output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation] std::strncpy(result, state, cch - 1); ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ util/status.cc:19:18: note: length computed here std::strlen(state) + 1; // +1 for the null terminator ~~~~~~~~~~~^~~~~~~ cc1plus: all warnings being treated as errors make: *** [Makefile:645: shared-objects/util/status.o] Error 1 closes #2705 Closes https://github.com/facebook/rocksdb/pull/3870 Differential Revision: D8594114 Pulled By: anand1976 fbshipit-source-id: ab20f3a456a711e4d29144ebe630e4fe3c99ec25
1 parent a16e00b
File | Mode | Size |
---|---|---|
RocksDBCommonHelper.php | -rw-r--r-- | 11.8 KB |
amalgamate.py | -rwxr-xr-x | 4.6 KB |
build_detect_platform | -rwxr-xr-x | 21.0 KB |
cont_integration.sh | -rwxr-xr-x | 3.4 KB |
dependencies.sh | -rw-r--r-- | 2.0 KB |
dependencies_4.8.1.sh | -rw-r--r-- | 2.1 KB |
dockerbuild.sh | -rwxr-xr-x | 76 bytes |
error_filter.py | -rw-r--r-- | 5.9 KB |
fb_compile_mongo.sh | -rwxr-xr-x | 1.4 KB |
fbcode_config.sh | -rw-r--r-- | 4.5 KB |
fbcode_config4.8.1.sh | -rw-r--r-- | 3.5 KB |
format-diff.sh | -rwxr-xr-x | 3.8 KB |
gnu_parallel | -rwxr-xr-x | 238.6 KB |
make_package.sh | -rwxr-xr-x | 3.0 KB |
precommit_checker.py | -rwxr-xr-x | 5.5 KB |
regression_build_test.sh | -rwxr-xr-x | 11.3 KB |
rocksdb-lego-determinator | -rwxr-xr-x | 19.5 KB |
run_ci_db_test.ps1 | -rw-r--r-- | 14.4 KB |
setup_centos7.sh | -rwxr-xr-x | 1.0 KB |
update_dependencies.sh | -rwxr-xr-x | 3.9 KB |
version.sh | -rwxr-xr-x | 697 bytes |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...