Revision e7b526bb852cdd67b24e174da6850222f8da41b1 authored by Chris Wilson on 02 June 2010, 07:30:48 UTC, committed by Linus Torvalds on 06 June 2010, 03:37:37 UTC
Cursors need to be in the GTT domain when being accessed by the GPU. Previously this was a fortuitous byproduct of userspace using pwrite() to upload the image data into the cursor. The redundant clflush was removed in commit 9b8c4a and so the image was no longer being flushed out of the caches into main memory. One could also devise a scenario where the cursor was rendered by the GPU, prior to being attached as the cursor, resulting in similar corruption due to the missing MI_FLUSH. Fixes: Bug 28335 - Cursor corruption caused by commit 9b8c4a0b21 https://bugs.freedesktop.org/show_bug.cgi?id=28335 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Reported-and-tested-by: Jeff Chua <jeff.chua.linux@gmail.com> Tested-by: Linus Torvalds <torvalds@linux-foundation.org> Reported-by: Andy Isaacson <adi@hexapodia.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 78b3655
| File | Mode | Size |
|---|---|---|
| Kconfig | -rw-r--r-- | 9.8 KB |
| Kconfig.debug | -rw-r--r-- | 1014 bytes |
| Makefile | -rw-r--r-- | 1.6 KB |
| backing-dev.c | -rw-r--r-- | 18.7 KB |
| bootmem.c | -rw-r--r-- | 23.8 KB |
| bounce.c | -rw-r--r-- | 6.5 KB |
| compaction.c | -rw-r--r-- | 16.1 KB |
| debug-pagealloc.c | -rw-r--r-- | 2.5 KB |
| dmapool.c | -rw-r--r-- | 12.9 KB |
| fadvise.c | -rw-r--r-- | 3.5 KB |
| failslab.c | -rw-r--r-- | 1.6 KB |
| filemap.c | -rw-r--r-- | 66.2 KB |
| filemap_xip.c | -rw-r--r-- | 11.0 KB |
| fremap.c | -rw-r--r-- | 6.7 KB |
| highmem.c | -rw-r--r-- | 11.3 KB |
| hugetlb.c | -rw-r--r-- | 72.1 KB |
| hwpoison-inject.c | -rw-r--r-- | 3.2 KB |
| init-mm.c | -rw-r--r-- | 538 bytes |
| internal.h | -rw-r--r-- | 7.1 KB |
| kmemcheck.c | -rw-r--r-- | 2.8 KB |
| kmemleak-test.c | -rw-r--r-- | 3.3 KB |
| kmemleak.c | -rw-r--r-- | 47.5 KB |
| ksm.c | -rw-r--r-- | 53.0 KB |
| maccess.c | -rw-r--r-- | 1.6 KB |
| madvise.c | -rw-r--r-- | 11.3 KB |
| memcontrol.c | -rw-r--r-- | 118.3 KB |
| memory-failure.c | -rw-r--r-- | 33.7 KB |
| memory.c | -rw-r--r-- | 94.8 KB |
| memory_hotplug.c | -rw-r--r-- | 22.1 KB |
| mempolicy.c | -rw-r--r-- | 65.9 KB |
| mempool.c | -rw-r--r-- | 8.9 KB |
| migrate.c | -rw-r--r-- | 26.8 KB |
| mincore.c | -rw-r--r-- | 7.6 KB |
| mlock.c | -rw-r--r-- | 15.2 KB |
| mm_init.c | -rw-r--r-- | 3.7 KB |
| mmap.c | -rw-r--r-- | 68.6 KB |
| mmu_context.c | -rw-r--r-- | 1.4 KB |
| mmu_notifier.c | -rw-r--r-- | 8.8 KB |
| mmzone.c | -rw-r--r-- | 1.8 KB |
| mprotect.c | -rw-r--r-- | 7.6 KB |
| mremap.c | -rw-r--r-- | 13.0 KB |
| msync.c | -rw-r--r-- | 2.4 KB |
| nommu.c | -rw-r--r-- | 48.4 KB |
| oom_kill.c | -rw-r--r-- | 17.7 KB |
| page-writeback.c | -rw-r--r-- | 36.3 KB |
| page_alloc.c | -rw-r--r-- | 150.1 KB |
| page_cgroup.c | -rw-r--r-- | 11.2 KB |
| page_io.c | -rw-r--r-- | 3.3 KB |
| page_isolation.c | -rw-r--r-- | 3.6 KB |
| pagewalk.c | -rw-r--r-- | 4.7 KB |
| percpu-km.c | -rw-r--r-- | 2.7 KB |
| percpu-vm.c | -rw-r--r-- | 13.0 KB |
| percpu.c | -rw-r--r-- | 52.7 KB |
| percpu_up.c | -rw-r--r-- | 672 bytes |
| prio_tree.c | -rw-r--r-- | 6.3 KB |
| quicklist.c | -rw-r--r-- | 2.4 KB |
| readahead.c | -rw-r--r-- | 15.4 KB |
| rmap.c | -rw-r--r-- | 40.7 KB |
| shmem.c | -rw-r--r-- | 70.8 KB |
| slab.c | -rw-r--r-- | 118.3 KB |
| slob.c | -rw-r--r-- | 17.0 KB |
| slub.c | -rw-r--r-- | 109.5 KB |
| sparse-vmemmap.c | -rw-r--r-- | 6.2 KB |
| sparse.c | -rw-r--r-- | 20.5 KB |
| swap.c | -rw-r--r-- | 12.9 KB |
| swap_state.c | -rw-r--r-- | 10.4 KB |
| swapfile.c | -rw-r--r-- | 63.6 KB |
| thrash.c | -rw-r--r-- | 1.9 KB |
| truncate.c | -rw-r--r-- | 15.8 KB |
| util.c | -rw-r--r-- | 7.0 KB |
| vmalloc.c | -rw-r--r-- | 60.8 KB |
| vmscan.c | -rw-r--r-- | 80.4 KB |
| vmstat.c | -rw-r--r-- | 28.5 KB |
Computing file changes ...
