Revision e7c243c925f6d9dcb898504ff24d6650b5cbb3b1 authored by Evgeniy Polyakov on 25 August 2007, 06:36:29 UTC, committed by David S. Miller on 27 August 2007, 01:35:47 UTC
I tried to preserve bridging code as it was before, but logic is quite strange - I think we should free skb on error, since it is already unshared and thus will just leak. Herbert Xu states: > + if ((skb = skb_share_check(skb, GFP_ATOMIC)) == NULL) > + goto out; If this happens it'll be a double-free on skb since we'll return NF_DROP which makes the caller free it too. We could return NF_STOLEN to prevent that but I'm not sure whether that's correct netfilter semantics. Patrick, could you please make a call on this? Patrick McHardy states: NF_STOLEN should work fine here. Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 7c8347a
| File | Mode | Size |
|---|---|---|
| 9p | ||
| adfs | ||
| affs | ||
| afs | ||
| autofs | ||
| autofs4 | ||
| befs | ||
| bfs | ||
| cifs | ||
| coda | ||
| configfs | ||
| cramfs | ||
| debugfs | ||
| devpts | ||
| dlm | ||
| ecryptfs | ||
| efs | ||
| exportfs | ||
| ext2 | ||
| ext3 | ||
| ext4 | ||
| fat | ||
| freevxfs | ||
| fuse | ||
| gfs2 | ||
| hfs | ||
| hfsplus | ||
| hostfs | ||
| hpfs | ||
| hppfs | ||
| hugetlbfs | ||
| isofs | ||
| jbd | ||
| jbd2 | ||
| jffs2 | ||
| jfs | ||
| lockd | ||
| minix | ||
| msdos | ||
| ncpfs | ||
| nfs | ||
| nfs_common | ||
| nfsd | ||
| nls | ||
| ntfs | ||
| ocfs2 | ||
| openpromfs | ||
| partitions | ||
| proc | ||
| qnx4 | ||
| ramfs | ||
| reiserfs | ||
| romfs | ||
| smbfs | ||
| sysfs | ||
| sysv | ||
| udf | ||
| ufs | ||
| vfat | ||
| xfs | ||
| Kconfig | -rw-r--r-- | 74.3 KB |
| Kconfig.binfmt | -rw-r--r-- | 5.3 KB |
| Makefile | -rw-r--r-- | 3.7 KB |
| aio.c | -rw-r--r-- | 45.6 KB |
| anon_inodes.c | -rw-r--r-- | 5.1 KB |
| attr.c | -rw-r--r-- | 4.1 KB |
| bad_inode.c | -rw-r--r-- | 7.8 KB |
| binfmt_aout.c | -rw-r--r-- | 15.2 KB |
| binfmt_elf.c | -rw-r--r-- | 47.7 KB |
| binfmt_elf_fdpic.c | -rw-r--r-- | 47.4 KB |
| binfmt_em86.c | -rw-r--r-- | 2.8 KB |
| binfmt_flat.c | -rw-r--r-- | 26.5 KB |
| binfmt_misc.c | -rw-r--r-- | 15.5 KB |
| binfmt_script.c | -rw-r--r-- | 2.7 KB |
| binfmt_som.c | -rw-r--r-- | 7.8 KB |
| bio.c | -rw-r--r-- | 29.0 KB |
| block_dev.c | -rw-r--r-- | 34.8 KB |
| buffer.c | -rw-r--r-- | 80.5 KB |
| char_dev.c | -rw-r--r-- | 13.2 KB |
| compat.c | -rw-r--r-- | 53.8 KB |
| compat_ioctl.c | -rw-r--r-- | 104.0 KB |
| dcache.c | -rw-r--r-- | 55.5 KB |
| dcookies.c | -rw-r--r-- | 6.4 KB |
| direct-io.c | -rw-r--r-- | 34.4 KB |
| dnotify.c | -rw-r--r-- | 4.3 KB |
| dquot.c | -rw-r--r-- | 53.0 KB |
| drop_caches.c | -rw-r--r-- | 1.4 KB |
| eventfd.c | -rw-r--r-- | 5.1 KB |
| eventpoll.c | -rw-r--r-- | 36.9 KB |
| exec.c | -rw-r--r-- | 40.8 KB |
| fcntl.c | -rw-r--r-- | 14.2 KB |
| fifo.c | -rw-r--r-- | 3.1 KB |
| file.c | -rw-r--r-- | 6.2 KB |
| file_table.c | -rw-r--r-- | 6.8 KB |
| filesystems.c | -rw-r--r-- | 5.5 KB |
| fs-writeback.c | -rw-r--r-- | 20.0 KB |
| generic_acl.c | -rw-r--r-- | 4.2 KB |
| inode.c | -rw-r--r-- | 37.4 KB |
| inotify.c | -rw-r--r-- | 19.3 KB |
| inotify_user.c | -rw-r--r-- | 17.4 KB |
| internal.h | -rw-r--r-- | 934 bytes |
| ioctl.c | -rw-r--r-- | 3.7 KB |
| ioprio.c | -rw-r--r-- | 4.7 KB |
| libfs.c | -rw-r--r-- | 16.0 KB |
| locks.c | -rw-r--r-- | 57.5 KB |
| mbcache.c | -rw-r--r-- | 18.3 KB |
| mpage.c | -rw-r--r-- | 20.3 KB |
| namei.c | -rw-r--r-- | 68.8 KB |
| namespace.c | -rw-r--r-- | 46.6 KB |
| nfsctl.c | -rw-r--r-- | 2.4 KB |
| no-block.c | -rw-r--r-- | 663 bytes |
| open.c | -rw-r--r-- | 26.1 KB |
| pipe.c | -rw-r--r-- | 24.4 KB |
| pnode.c | -rw-r--r-- | 7.6 KB |
| pnode.h | -rw-r--r-- | 1006 bytes |
| posix_acl.c | -rw-r--r-- | 8.5 KB |
| quota.c | -rw-r--r-- | 12.2 KB |
| quota_v1.c | -rw-r--r-- | 5.7 KB |
| quota_v2.c | -rw-r--r-- | 20.1 KB |
| read_write.c | -rw-r--r-- | 17.9 KB |
| read_write.h | -rw-r--r-- | 542 bytes |
| readdir.c | -rw-r--r-- | 6.8 KB |
| select.c | -rw-r--r-- | 20.4 KB |
| seq_file.c | -rw-r--r-- | 10.3 KB |
| signalfd.c | -rw-r--r-- | 9.6 KB |
| splice.c | -rw-r--r-- | 39.9 KB |
| stack.c | -rw-r--r-- | 1.1 KB |
| stat.c | -rw-r--r-- | 10.6 KB |
| super.c | -rw-r--r-- | 22.1 KB |
| sync.c | -rw-r--r-- | 7.0 KB |
| timerfd.c | -rw-r--r-- | 5.0 KB |
| utimes.c | -rw-r--r-- | 4.8 KB |
| xattr.c | -rw-r--r-- | 13.8 KB |
| xattr_acl.c | -rw-r--r-- | 2.3 KB |
Computing file changes ...
