Revision ec057595cb3fb339e692898bedccd566160ba086 authored by Linus Torvalds on 06 December 2019, 20:40:35 UTC, committed by Linus Torvalds on 06 December 2019, 20:40:35 UTC
Similarly to commit 8f868d68d335 ("pipe: Fix missing mask update after
pipe_wait()") this fixes a case where the pipe rewrite ended up caching
the pipe state incorrectly over a pipe lock drop event.
It wasn't quite as obvious, because you needed to splice data from a
pipe to a file, which is a fairly unusual operation, but it's completely
wrong.
Make sure we load the pipe head/tail/size information only after we've
waited for there to be data in the pipe.
While in that file, also make one of the splice helper functions use the
canonical arghument order for pipe_empty(). That's syntactic - pipe
emptiness is just that head and tail are equal, and thus mixing up head
and tail doesn't really matter. It's still wrong, though.
Reported-by: David Sterba <dsterba@suse.cz>
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 7ada90e
| File | Mode | Size |
|---|---|---|
| bpf | ||
| cgroup | ||
| configs | ||
| debug | ||
| dma | ||
| events | ||
| gcov | ||
| irq | ||
| livepatch | ||
| locking | ||
| power | ||
| printk | ||
| rcu | ||
| sched | ||
| time | ||
| trace | ||
| .gitignore | -rw-r--r-- | 53 bytes |
| Kconfig.freezer | -rw-r--r-- | 92 bytes |
| Kconfig.hz | -rw-r--r-- | 1.7 KB |
| Kconfig.locks | -rw-r--r-- | 4.9 KB |
| Kconfig.preempt | -rw-r--r-- | 3.0 KB |
| Makefile | -rw-r--r-- | 4.3 KB |
| acct.c | -rw-r--r-- | 15.4 KB |
| async.c | -rw-r--r-- | 10.2 KB |
| audit.c | -rw-r--r-- | 61.4 KB |
| audit.h | -rw-r--r-- | 10.4 KB |
| audit_fsnotify.c | -rw-r--r-- | 5.6 KB |
| audit_tree.c | -rw-r--r-- | 25.7 KB |
| audit_watch.c | -rw-r--r-- | 14.1 KB |
| auditfilter.c | -rw-r--r-- | 34.0 KB |
| auditsc.c | -rw-r--r-- | 69.7 KB |
| backtracetest.c | -rw-r--r-- | 1.9 KB |
| bounds.c | -rw-r--r-- | 751 bytes |
| capability.c | -rw-r--r-- | 14.6 KB |
| compat.c | -rw-r--r-- | 9.2 KB |
| configs.c | -rw-r--r-- | 2.0 KB |
| context_tracking.c | -rw-r--r-- | 6.3 KB |
| cpu.c | -rw-r--r-- | 57.9 KB |
| cpu_pm.c | -rw-r--r-- | 5.6 KB |
| crash_core.c | -rw-r--r-- | 11.4 KB |
| crash_dump.c | -rw-r--r-- | 1.3 KB |
| cred.c | -rw-r--r-- | 23.3 KB |
| delayacct.c | -rw-r--r-- | 4.7 KB |
| dma.c | -rw-r--r-- | 3.3 KB |
| elfcore.c | -rw-r--r-- | 459 bytes |
| exec_domain.c | -rw-r--r-- | 1.1 KB |
| exit.c | -rw-r--r-- | 42.0 KB |
| extable.c | -rw-r--r-- | 4.4 KB |
| fail_function.c | -rw-r--r-- | 6.9 KB |
| fork.c | -rw-r--r-- | 73.1 KB |
| freezer.c | -rw-r--r-- | 4.4 KB |
| futex.c | -rw-r--r-- | 112.1 KB |
| gen_kheaders.sh | -rwxr-xr-x | 3.2 KB |
| groups.c | -rw-r--r-- | 4.9 KB |
| hung_task.c | -rw-r--r-- | 7.3 KB |
| iomem.c | -rw-r--r-- | 4.7 KB |
| irq_work.c | -rw-r--r-- | 4.7 KB |
| jump_label.c | -rw-r--r-- | 20.8 KB |
| kallsyms.c | -rw-r--r-- | 17.6 KB |
| kcmp.c | -rw-r--r-- | 5.7 KB |
| kcov.c | -rw-r--r-- | 24.8 KB |
| kexec.c | -rw-r--r-- | 7.9 KB |
| kexec_core.c | -rw-r--r-- | 31.1 KB |
| kexec_elf.c | -rw-r--r-- | 11.4 KB |
| kexec_file.c | -rw-r--r-- | 33.0 KB |
| kexec_internal.h | -rw-r--r-- | 924 bytes |
| kheaders.c | -rw-r--r-- | 1.6 KB |
| kmod.c | -rw-r--r-- | 5.0 KB |
| kprobes.c | -rw-r--r-- | 63.3 KB |
| ksysfs.c | -rw-r--r-- | 6.3 KB |
| kthread.c | -rw-r--r-- | 34.1 KB |
| latencytop.c | -rw-r--r-- | 7.2 KB |
| module-internal.h | -rw-r--r-- | 782 bytes |
| module.c | -rw-r--r-- | 115.7 KB |
| module_signature.c | -rw-r--r-- | 1.1 KB |
| module_signing.c | -rw-r--r-- | 1.1 KB |
| notifier.c | -rw-r--r-- | 15.5 KB |
| nsproxy.c | -rw-r--r-- | 6.3 KB |
| padata.c | -rw-r--r-- | 26.7 KB |
| panic.c | -rw-r--r-- | 17.2 KB |
| params.c | -rw-r--r-- | 22.7 KB |
| pid.c | -rw-r--r-- | 14.0 KB |
| pid_namespace.c | -rw-r--r-- | 11.4 KB |
| profile.c | -rw-r--r-- | 14.8 KB |
| ptrace.c | -rw-r--r-- | 36.4 KB |
| range.c | -rw-r--r-- | 3.0 KB |
| reboot.c | -rw-r--r-- | 14.1 KB |
| relay.c | -rw-r--r-- | 32.1 KB |
| resource.c | -rw-r--r-- | 42.8 KB |
| rseq.c | -rw-r--r-- | 9.8 KB |
| seccomp.c | -rw-r--r-- | 46.0 KB |
| signal.c | -rw-r--r-- | 117.9 KB |
| smp.c | -rw-r--r-- | 22.1 KB |
| smpboot.c | -rw-r--r-- | 11.7 KB |
| smpboot.h | -rw-r--r-- | 640 bytes |
| softirq.c | -rw-r--r-- | 17.1 KB |
| stackleak.c | -rw-r--r-- | 3.9 KB |
| stacktrace.c | -rw-r--r-- | 9.7 KB |
| stop_machine.c | -rw-r--r-- | 18.0 KB |
| sys.c | -rw-r--r-- | 62.0 KB |
| sys_ni.c | -rw-r--r-- | 10.0 KB |
| sysctl-test.c | -rw-r--r-- | 10.7 KB |
| sysctl.c | -rw-r--r-- | 80.5 KB |
| sysctl_binary.c | -rw-r--r-- | 3.8 KB |
| task_work.c | -rw-r--r-- | 3.1 KB |
| taskstats.c | -rw-r--r-- | 15.6 KB |
| test_kprobes.c | -rw-r--r-- | 5.9 KB |
| torture.c | -rw-r--r-- | 21.0 KB |
| tracepoint.c | -rw-r--r-- | 14.9 KB |
| tsacct.c | -rw-r--r-- | 4.6 KB |
| ucount.c | -rw-r--r-- | 5.5 KB |
| uid16.c | -rw-r--r-- | 5.1 KB |
| uid16.h | -rw-r--r-- | 442 bytes |
| umh.c | -rw-r--r-- | 19.0 KB |
| up.c | -rw-r--r-- | 2.3 KB |
| user-return-notifier.c | -rw-r--r-- | 1.3 KB |
| user.c | -rw-r--r-- | 5.5 KB |
| user_namespace.c | -rw-r--r-- | 33.2 KB |
| utsname.c | -rw-r--r-- | 3.8 KB |
| utsname_sysctl.c | -rw-r--r-- | 3.2 KB |
| watchdog.c | -rw-r--r-- | 21.4 KB |
| watchdog_hld.c | -rw-r--r-- | 7.7 KB |
| workqueue.c | -rw-r--r-- | 164.8 KB |
| workqueue_internal.h | -rw-r--r-- | 2.4 KB |
Computing file changes ...
