Revision ec2f64794bc8430c4f6b771f16136d7a0afe2c15 authored by Andrew Kryczka on 15 November 2016, 04:20:14 UTC, committed by Facebook Github Bot on 15 November 2016, 04:24:21 UTC
Summary: Adjusted AddToBuilder() to take lower_bound and upper_bound, which serve two purposes: (1) only range deletions overlapping with the interval [lower_bound, upper_bound) will be added to the output file, and (2) the output file's boundaries will not be extended before lower_bound or after upper_bound. Our computation of lower_bound/upper_bound consider both subcompaction boundaries and previous/next files within the subcompaction. Test cases are here (level subcompactions: https://gist.github.com/ajkr/63c7eae3e9667c5ebdc0a7efb74ac332, and universal subcompactions: https://gist.github.com/ajkr/5a62af77c4ebe4052a1955c496d51fdb) but can't be included in this diff as they depend on committing the API first. They fail before this change and pass after. Closes https://github.com/facebook/rocksdb/pull/1501 Reviewed By: yhchiang Differential Revision: D4171685 Pulled By: ajkr fbshipit-source-id: ee99db8
1 parent 800e515
| File | Mode | Size |
|---|---|---|
| amalgamate.py | -rwxr-xr-x | 4.6 KB |
| build_detect_platform | -rwxr-xr-x | 15.7 KB |
| cont_integration.sh | -rwxr-xr-x | 3.4 KB |
| dependencies.sh | -rw-r--r-- | 1.9 KB |
| dependencies_4.8.1.sh | -rw-r--r-- | 2.0 KB |
| dockerbuild.sh | -rwxr-xr-x | 68 bytes |
| error_filter.py | -rw-r--r-- | 6.0 KB |
| fb_compile_mongo.sh | -rwxr-xr-x | 1.4 KB |
| fbcode_config.sh | -rw-r--r-- | 4.2 KB |
| fbcode_config4.8.1.sh | -rw-r--r-- | 3.4 KB |
| format-diff.sh | -rwxr-xr-x | 3.4 KB |
| gnu_parallel | -rwxr-xr-x | 238.6 KB |
| make_new_version.sh | -rwxr-xr-x | 1.2 KB |
| make_package.sh | -rwxr-xr-x | 2.6 KB |
| precommit_checker.py | -rwxr-xr-x | 5.5 KB |
| regression_build_test.sh | -rwxr-xr-x | 11.7 KB |
| rocksdb-lego-determinator | -rwxr-xr-x | 21.5 KB |
| run_ci_db_test.ps1 | -rw-r--r-- | 9.2 KB |
| update_dependencies.sh | -rwxr-xr-x | 3.6 KB |
| version.sh | -rwxr-xr-x | 404 bytes |
Computing file changes ...
