Skip to main content

Browse the archive

https://github.com/torvalds/linux
05 April 2024, 19:05:47 UTC
Revision f1132ba3465d56622c286beef6b511fd55c6482b authored by Hsien Chang on 22 January 2019, 04:07:24 UTC, committed by Hsien Chang on 22 January 2019, 04:07:24 UTC 
Remove target_wait_for_sess_cmd()
 
There is currently a bug with the driver where there is never a call to
target_sess_cmd_list_set_waiting(), it only called
target_wait_for_sess_cmd(), which basically means that the sess_wait_list
would always be empty.

Thus, list_empty(&sess->sess_wait_list) = true,
(eg: no se_cmd I/O is quiesced, because no se_cmd in sess_wait_list),
since commit 712db3e ("scsi: ibmvscsis: Properly deregister
target sessions") in 4.9.y code.

ibmvscsi_tgt does not remove the I_T Nexus when a VM is active so we can
fix this issue by removing the call to target_wait_for_sess_cmd()
altogether.

This fix was backported from 4.20, see commit a1ad38a
https://kernel.googlesource.com/pub/scm/linux/kernel/git/mkp/scsi/+/a1ad38a61e34a67bce75c01702d056f051feaf04
1 parent 2c3c13d
History
Tip revision: f1132ba3465d56622c286beef6b511fd55c6482b authored by Hsien Chang on 22 January 2019, 04:07:24 UTC
Remove target_wait_for_sess_cmd()
Tip revision: f1132ba
File Mode Size
apparmor
integrity
keys
loadpin
selinux
smack
tomoyo
yama
Kconfig -rw-r--r-- 10.6 KB
Makefile -rw-r--r-- 1.1 KB
commoncap.c -rw-r--r-- 39.0 KB
device_cgroup.c -rw-r--r-- 20.5 KB
inode.c -rw-r--r-- 10.5 KB
lock_down.c -rw-r--r-- 2.7 KB
lsm_audit.c -rw-r--r-- 10.7 KB
min_addr.c -rw-r--r-- 1.3 KB
security.c -rw-r--r-- 43.9 KB
back to top