Revision f272696a35678438a1edd0ad1d23c8c110ede3e5 authored by Jeff King on 02 November 2016, 18:20:22 UTC, committed by Junio C Hamano on 03 November 2016, 02:36:29 UTC
The rot13-filter.pl script hardcodes "#!/usr/bin/perl", and
does not respect $PERL_PATH at all. That is a problem if the
system does not have perl at that path, or if it has a perl
that is too old to run a complicated script like the
rot13-filter (but PERL_PATH points to a more modern one).

We can fix this by using write_script() to create a new copy
of the script with the correct #!-line. In theory we could
move the whole script inside t0021-conversion.sh rather than
having it as an auxiliary file, but it's long enough that
it just makes things harder to read.

As a bonus, we can stop using the full path to the script in
the filter-process config we add (because the trash
directory is in our PATH). Not only is this shorter, but it
sidesteps any shell-quoting issues. The original was broken
when $TEST_DIRECTORY contained a space, because it was
interpolated in the outer script.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 30030a3
History
File Mode Size
nedmalloc
poll
regex
vcbuild
win32
apple-common-crypto.h -rw-r--r-- 2.7 KB
basename.c -rw-r--r-- 1.3 KB
bswap.h -rw-r--r-- 4.6 KB
fopen.c -rw-r--r-- 931 bytes
gmtime.c -rw-r--r-- 605 bytes
hstrerror.c -rw-r--r-- 530 bytes
inet_ntop.c -rw-r--r-- 4.8 KB
inet_pton.c -rw-r--r-- 6.8 KB
memmem.c -rw-r--r-- 752 bytes
mingw.c -rw-r--r-- 57.2 KB
mingw.h -rw-r--r-- 14.3 KB
mkdir.c -rw-r--r-- 468 bytes
mkdtemp.c -rw-r--r-- 153 bytes
mmap.c -rw-r--r-- 692 bytes
msvc.c -rw-r--r-- 113 bytes
msvc.h -rw-r--r-- 570 bytes
obstack.c -rw-r--r-- 13.8 KB
obstack.h -rw-r--r-- 19.1 KB
pread.c -rw-r--r-- 433 bytes
precompose_utf8.c -rw-r--r-- 4.6 KB
precompose_utf8.h -rw-r--r-- 1.3 KB
qsort.c -rw-r--r-- 1.2 KB
setenv.c -rw-r--r-- 862 bytes
sha1-chunked.c -rw-r--r-- 362 bytes
sha1-chunked.h -rw-r--r-- 81 bytes
snprintf.c -rw-r--r-- 1.5 KB
stat.c -rw-r--r-- 1.1 KB
strcasestr.c -rw-r--r-- 431 bytes
strdup.c -rw-r--r-- 169 bytes
strlcpy.c -rw-r--r-- 247 bytes
strtoimax.c -rw-r--r-- 214 bytes
strtoumax.c -rw-r--r-- 217 bytes
terminal.c -rw-r--r-- 2.5 KB
terminal.h -rw-r--r-- 142 bytes
unsetenv.c -rw-r--r-- 591 bytes
win32.h -rw-r--r-- 878 bytes
win32mmap.c -rw-r--r-- 1.1 KB
winansi.c -rw-r--r-- 15.1 KB

back to top