Revision f419a08fb329e235df0cb8e329cff770e02d171a authored by Arnd Bergmann on 25 March 2016, 21:21:47 UTC, committed by Linus Torvalds on 25 March 2016, 23:37:42 UTC
The r592 driver relies on behavior of the DMA mapping API that is normally observed but not guaranteed by the API. Instead it uses a runtime check to fail transfers if the API ever behaves When CONFIG_NEED_SG_DMA_LENGTH is not set, one of the checks turns into a comparison of a variable with itself, which gcc-6.0 now warns about: drivers/memstick/host/r592.c: In function 'r592_transfer_fifo_dma': drivers/memstick/host/r592.c:302:31: error: self-comparison always evaluates to false [-Werror=tautological-compare] (sg_dma_len(&dev->req->sg) < dev->req->sg.length)) { ^ The check itself is not a problem, so this patch just rephrases the condition in a way that gcc does not consider an indication of a mistake. We already know that dev->req->sg.length was initially R592_LFIFO_SIZE, so we can compare it to that constant again. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Maxim Levitsky <maximlevitsky@gmail.com> Cc: Quentin Lambert <lambert.quentin@gmail.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 102c259
File | Mode | Size |
---|---|---|
9p | ||
adfs | ||
affs | ||
afs | ||
autofs4 | ||
befs | ||
bfs | ||
btrfs | ||
cachefiles | ||
ceph | ||
cifs | ||
coda | ||
configfs | ||
cramfs | ||
crypto | ||
debugfs | ||
devpts | ||
dlm | ||
ecryptfs | ||
efivarfs | ||
efs | ||
exofs | ||
exportfs | ||
ext2 | ||
ext4 | ||
f2fs | ||
fat | ||
freevxfs | ||
fscache | ||
fuse | ||
gfs2 | ||
hfs | ||
hfsplus | ||
hostfs | ||
hpfs | ||
hugetlbfs | ||
isofs | ||
jbd2 | ||
jffs2 | ||
jfs | ||
kernfs | ||
lockd | ||
logfs | ||
minix | ||
ncpfs | ||
nfs | ||
nfs_common | ||
nfsd | ||
nilfs2 | ||
nls | ||
notify | ||
ntfs | ||
ocfs2 | ||
omfs | ||
openpromfs | ||
overlayfs | ||
proc | ||
pstore | ||
qnx4 | ||
qnx6 | ||
quota | ||
ramfs | ||
reiserfs | ||
romfs | ||
squashfs | ||
sysfs | ||
sysv | ||
tracefs | ||
ubifs | ||
udf | ||
ufs | ||
xfs | ||
Kconfig | -rw-r--r-- | 6.9 KB |
Kconfig.binfmt | -rw-r--r-- | 7.0 KB |
Makefile | -rw-r--r-- | 4.2 KB |
aio.c | -rw-r--r-- | 43.0 KB |
anon_inodes.c | -rw-r--r-- | 4.9 KB |
attr.c | -rw-r--r-- | 7.9 KB |
bad_inode.c | -rw-r--r-- | 4.7 KB |
binfmt_aout.c | -rw-r--r-- | 10.8 KB |
binfmt_elf.c | -rw-r--r-- | 60.7 KB |
binfmt_elf_fdpic.c | -rw-r--r-- | 47.8 KB |
binfmt_em86.c | -rw-r--r-- | 2.8 KB |
binfmt_flat.c | -rw-r--r-- | 26.4 KB |
binfmt_misc.c | -rw-r--r-- | 17.4 KB |
binfmt_script.c | -rw-r--r-- | 3.0 KB |
block_dev.c | -rw-r--r-- | 48.6 KB |
buffer.c | -rw-r--r-- | 88.6 KB |
char_dev.c | -rw-r--r-- | 13.3 KB |
compat.c | -rw-r--r-- | 37.1 KB |
compat_binfmt_elf.c | -rw-r--r-- | 3.7 KB |
compat_ioctl.c | -rw-r--r-- | 45.3 KB |
coredump.c | -rw-r--r-- | 20.6 KB |
dax.c | -rw-r--r-- | 31.9 KB |
dcache.c | -rw-r--r-- | 88.9 KB |
dcookies.c | -rw-r--r-- | 6.9 KB |
direct-io.c | -rw-r--r-- | 38.4 KB |
drop_caches.c | -rw-r--r-- | 1.6 KB |
eventfd.c | -rw-r--r-- | 12.9 KB |
eventpoll.c | -rw-r--r-- | 60.1 KB |
exec.c | -rw-r--r-- | 42.5 KB |
fcntl.c | -rw-r--r-- | 16.7 KB |
fhandle.c | -rw-r--r-- | 6.5 KB |
file.c | -rw-r--r-- | 23.5 KB |
file_table.c | -rw-r--r-- | 8.5 KB |
filesystems.c | -rw-r--r-- | 6.4 KB |
fs-writeback.c | -rw-r--r-- | 68.6 KB |
fs_pin.c | -rw-r--r-- | 2.0 KB |
fs_struct.c | -rw-r--r-- | 3.3 KB |
inode.c | -rw-r--r-- | 53.1 KB |
internal.h | -rw-r--r-- | 3.8 KB |
ioctl.c | -rw-r--r-- | 17.1 KB |
libfs.c | -rw-r--r-- | 30.3 KB |
locks.c | -rw-r--r-- | 71.5 KB |
mbcache.c | -rw-r--r-- | 11.9 KB |
mount.h | -rw-r--r-- | 3.5 KB |
mpage.c | -rw-r--r-- | 20.3 KB |
namei.c | -rw-r--r-- | 115.0 KB |
namespace.c | -rw-r--r-- | 81.6 KB |
no-block.c | -rw-r--r-- | 688 bytes |
nsfs.c | -rw-r--r-- | 3.7 KB |
open.c | -rw-r--r-- | 26.7 KB |
pipe.c | -rw-r--r-- | 26.3 KB |
pnode.c | -rw-r--r-- | 11.3 KB |
pnode.h | -rw-r--r-- | 1.8 KB |
posix_acl.c | -rw-r--r-- | 19.6 KB |
proc_namespace.c | -rw-r--r-- | 7.8 KB |
read_write.c | -rw-r--r-- | 39.0 KB |
readdir.c | -rw-r--r-- | 6.9 KB |
select.c | -rw-r--r-- | 25.3 KB |
seq_file.c | -rw-r--r-- | 22.4 KB |
signalfd.c | -rw-r--r-- | 9.2 KB |
splice.c | -rw-r--r-- | 46.2 KB |
stack.c | -rw-r--r-- | 2.5 KB |
stat.c | -rw-r--r-- | 11.9 KB |
statfs.c | -rw-r--r-- | 5.3 KB |
super.c | -rw-r--r-- | 35.0 KB |
sync.c | -rw-r--r-- | 9.9 KB |
timerfd.c | -rw-r--r-- | 13.0 KB |
userfaultfd.c | -rw-r--r-- | 35.1 KB |
utimes.c | -rw-r--r-- | 5.9 KB |
xattr.c | -rw-r--r-- | 23.2 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...